Thanks for writing this up, Galder. <br><br>The latter seems the better of the two. It may need to be implemented as a separate antscript task, as assembly may not have a hook for this.<br><br>-Adrian<br><br><div class="gmail_quote">
On Tue, Jun 30, 2009 at 5:59 PM, Galder Zamarreno <span dir="ltr"><<a href="mailto:galder.zamarreno@redhat.com">galder.zamarreno@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Hmmmmm, this has a domino effect. Because s3 module depends on infinispan-core, it now pulls all its dependencies, so we need to exclude them somehow, cos they're dependencies of the core module and hence they should reside there rather than have them in each and every module.<br>
<br>
Personally, in spite of the repetition, I prefer explicit dependency definition rather than letting maven bring all transitive dependencies and then having to go and do exclusions.<br>
<br>
More globally, I think this needs to be put the infinispan-dev list. During assembly, do we either:<br>
<br>
- Leave useTransitiveDependencies as it is, which is false, and make modules like s3 explicitly define the 3rd party dependencies that jclouds depends on.<br>
<br>
- Or set useTransitiveDependencies to true so that they're all brought in and exclude direct infinispan-core dependecies from getting to the lib directories of submodules such as s3.<br>
<br>
For the moment, and to make my life easier getting the demo working, I'm using the latter option.<br>
<br>
Thoughts?<br>
<br>
On 06/30/2009 05:47 PM, Adrian Cole wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
beware of the assemblies... they are extremely crufty compared to ant ;)<br>
<br>
On Tue, Jun 30, 2009 at 5:45 PM, Galder Zamarreno<<br>
<a href="mailto:galder.zamarreno@redhat.com" target="_blank">galder.zamarreno@redhat.com</a>> wrote:<br>
<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
On 06/30/2009 05:22 PM, Adrian Cole wrote:<br>
<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Well.. :) I setup the dependencies of jclouds, so it shouldn't bring<br>
anything crazy in! Besides, a missing dep might be symptomatic of a<br>
larger<br>
issue in the distribution assembly.<br>
<br>
</blockquote>
Ahh, maybe just found the reason why transitive dependencies are not<br>
included:<br>
<br>
src/main/resources/assemblies/bin.xml:<br>
<useTransitiveDependencies>false</useTransitiveDependencies><br>
<br>
I'm trying out with that parameter set to true.<br>
<br>
<br>
<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Anyway, let me know how it goes.<br>
<br>
on the SNAPSHOT bit, it was irrelevant to the topic. no worries on that.<br>
<br>
Thanks again for sorting this out, Galder.<br>
-a<br>
<br>
On Tue, Jun 30, 2009 at 5:11 PM, Galder Zamarreno<<br>
<a href="mailto:galder.zamarreno@redhat.com" target="_blank">galder.zamarreno@redhat.com</a>> wrote:<br>
<br>
<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
On 06/30/2009 05:00 PM, Galder Zamarreno wrote:<br>
<br>
<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
On 06/30/2009 04:55 PM, Adrian Cole wrote:<br>
<br>
many thanks, Galder. It should be a transitive dep from jclouds-s3...<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
mvn<br>
dependency:tree<br>
<br>
maybe the distribution isn't pulling in deps properly.<br>
<br>
Yeah, that looks to be the issue. At the moment I'm trying to redefine<br>
</blockquote>
them in the s3 project but maybe there's another way to do this? Google<br>
to the rescue...<br>
<br>
Hmmm, even though it's repetition, I think it might be safer to<br>
</blockquote>
redefine<br>
the transitive dependencies rather than let it bring them all. You never<br>
know what Maven might bring with it...<br>
<br>
<br>
<br>
I will be cutting a new beta within the next couple days, so maybe you<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
can<br>
switch temporarily to snapshot to ensure it will work?<br>
<br>
Hmmm, why would I need a snapshot of jclouds? I've simply been adding<br>
</blockquote>
the transitive dependencies manually in s3/pom.xml<br>
<br>
<br>
Thanks,<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
-Adrian<br>
<br>
On Tue, Jun 30, 2009 at 4:40 PM, Galder Zamarreno<<br>
<a href="mailto:galder.zamarreno@redhat.com" target="_blank">galder.zamarreno@redhat.com</a>> wrote:<br>
<br>
Hi Adrian,<br>
<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
I'm trying to make further progress with the demo and I'm<br>
encountering the<br>
following issue:<br>
<br>
Caused by: java.lang.ClassNotFoundException:<br>
org.jclouds.logging.config.LoggingModule<br>
<br>
The list of jars that is distributed does not include<br>
jclouds-core-1.0-beta-1.jar and this looks to be cos there's no direct<br>
dependency on this jar in the pom.xml for the s3 cache store module.<br>
<br>
FYI: I'm adding this dependency. I think there's a similar issue with<br>
google guice...<br>
<br>
Anyway, just letting you know of issues as I find them.<br>
<br>
See ya,<br>
--<br>
Galder Zamarreño<br>
Sr. Software Engineer<br>
Infinispan, JBoss Cache<br>
<br>
<br>
--<br>
</blockquote></blockquote></blockquote>
Galder Zamarreño<br>
Sr. Software Engineer<br>
Infinispan, JBoss Cache<br>
<br>
<br>
</blockquote></blockquote>
--<br>
Galder Zamarreño<br>
Sr. Software Engineer<br>
Infinispan, JBoss Cache<br>
<br>
</blockquote>
<br>
</blockquote>
<br>
-- <br>
Galder Zamarreño<br>
Sr. Software Engineer<br>
Infinispan, JBoss Cache<br>
</blockquote></div><br>