<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Yes, that is a good idea.<div><br></div><div>BaseCacheStoreTest is a unit test, not a functional one. Perhaps create a BaseCacheStoreFunctionalTest for <span class="Apple-style-span" style="color: rgb(84, 0, 0); ">testTwoCachesSameCacheStore(), and make sure all cache store impls extend this test?</span></div><div><font class="Apple-style-span" color="#540000"><br></font></div><div><font class="Apple-style-span" color="#540000">Cheers</font></div><div><font class="Apple-style-span" color="#540000">Manik</font></div><div><font class="Apple-style-span" color="#540000"><br></font></div><div><div><div><div>On 5 Aug 2009, at 15:33, Galder Zamarreno wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div>One thing to note about BaseCacheStoreTest is that all the tests within it work directly with CacheStore and not Cache or CacheManager.<br><br>So, for tests related to cache stores where the test interacts with Cache/CacheManager interface, I'd put them in a separate class.<br><br>On 08/05/2009 04:26 PM, Galder Zamarreno wrote:<br><blockquote type="cite">Mircea, if you were to call cache.start() in that<br></blockquote><blockquote type="cite">testTwoCachesSameCacheStore, would that work?<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">I've just seen an user report a similar whereby VAM's @Start method is<br></blockquote><blockquote type="cite">not being called in spite of them calling cache.start()<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite"><a href="https://jira.jboss.org/jira/browse/ISPN-148">https://jira.jboss.org/jira/browse/ISPN-148</a><br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">On 08/05/2009 09:55 AM, Manik Surtani wrote:<br></blockquote><blockquote type="cite"><blockquote type="cite">That's because you're not calling cache.start() in the test. :-) It<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">is an isolated test to test the CacheStore. So yes, manually calling<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">start() on the Marshaller is the correct approach if you need a<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">start()'ed marshaller.<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">Cheers<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">Manik<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">On 4 Aug 2009, at 20:01, Mircea Markus wrote:<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">Hi,<br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">VersionAwareMarshaller.start does not get called and I don't know<br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">why, can you give me an helping hand on this?<br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">See BaseCacheStoreTest.testTwoCachesSameCacheStore, the TODO there.<br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">Cheers,<br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">Mircea<br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">--<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">Manik Surtani<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><a href="mailto:manik@jboss.org">manik@jboss.org</a><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">Lead, Infinispan<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">Lead, JBoss Cache<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><a href="http://www.infinispan.org">http://www.infinispan.org</a><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><a href="http://www.jbosscache.org">http://www.jbosscache.org</a><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">_______________________________________________<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">infinispan-dev mailing list<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><a href="mailto:infinispan-dev@lists.jboss.org">infinispan-dev@lists.jboss.org</a><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a><br></blockquote></blockquote><blockquote type="cite"><br></blockquote><br>-- <br>Galder Zamarreņo<br>Sr. Software Engineer<br>Infinispan, JBoss Cache<br></div></blockquote></div><br><div apple-content-edited="true"> <span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0; "><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div>--</div><div>Manik Surtani</div><div><a href="mailto:manik@jboss.org">manik@jboss.org</a></div><div>Lead, Infinispan</div><div>Lead, JBoss Cache</div><div><a href="http://www.infinispan.org">http://www.infinispan.org</a></div><div><a href="http://www.jbosscache.org">http://www.jbosscache.org</a></div><div><br></div></div></span><br class="Apple-interchange-newline"></div></span><br class="Apple-interchange-newline"> </div><br></div></div></body></html>