<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Nice one. Good to see that we're getting there!<div><br></div><div>Some comments below:<div><div><br></div><div><div><div>On 13 Aug 2009, at 16:17, Mircea Markus wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div>Hi there,<br><br>Here is a how things are with hudson tests:<br>- hudson user still cannot bind to UDP, so we're using TCP+TCPPING. <br>There are two tests that check that in the class named: <br>TcpMPingEnvironmentTest.<br></div></blockquote><div><br></div><div>Can we disable this test by default, until we know that something has been done to allow UDP to work better on Hudson? It's just generating noise otherwise.</div><br><blockquote type="cite"><div>- I've found a workaround for the SingleStore test (one in which <br>coordinators were stopped): I've increased the TCPPING.port_range to 5 <br>and that sorted the problem.<br>- S3 cache stores failures were fixed - Adrian if you can take a look <br>would be great<br>- other intermittent failures were fixed<br><br>Besides the 2 failures in TcpMPingEnvironmentTest, there are other 6:<br>- 3 failures in TableNameUniquenessTest - caused by xsd missing from <br>the path<br>- CacheManagerXmlConfigurationTest- <br>testNamedCacheXMLClashingNamesProgrammatic<br>- CacheManagerXmlConfigurationTest-testNamedCacheXML<br>- XmlFileParsingTest-testNamedCacheFileJaxb<br><br>All above 5 are failing with the same missing xsd error. Vladimir, <br>would it be possible for you to take a look at the 6 failure above?<br></div></blockquote><div><br></div><div>I've mentioned these in a previous email, reiterating here for the record:</div><div><br></div><div>1. XSD should be generated before the test suite is run. Perhaps in the pre-test or post-compile phase.</div><div>2. The code should skip loading the schema if schema validation is disabled, following this algorithm:</div><div><br></div><div><blockquote type="cite">validating = system property "infinispan.config.validate", defaults to true.<br></blockquote><blockquote type="cite">schema file = system property "infinispan.config.schema", defaults to schemas/infinispan-config-4.0.xsd<br></blockquote><blockquote type="cite">schema URL = system property "infinispan.config.schema.url" defaults to <a href="http://www.jboss.org/infinispan/infinispan-config-4.0.xsd">http://www.jboss.org/infinispan/infinispan-config-4.0.xsd</a><br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">if (validating) {<br></blockquote><blockquote type="cite">1. try and load schema file from classpath<br></blockquote><blockquote type="cite">2. else, try and load schema file on file system<br></blockquote><blockquote type="cite">3. else, try and load from schema URL<br></blockquote><blockquote type="cite">4. else, throw an exception!<br></blockquote><blockquote type="cite">}</blockquote></div><div><br></div><div>3. The unit test suite should *not* attempt to skip schema validation. This will, on one level, test schema validation code, and on another, ensure all sample cfg files we ship with are valid.</div><div>4. We should document the above system properties. Javadoc for Configuration could be one place, but also on the wiki.</div><div><br></div><div>Cheers</div><div>Manik</div><div><span class="Apple-style-span" style="font-size: 12px; ">--</span></div></div><div apple-content-edited="true"><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0; "><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div>Manik Surtani</div><div><a href="mailto:manik@jboss.org">manik@jboss.org</a></div><div>Lead, Infinispan</div><div>Lead, JBoss Cache</div><div><a href="http://www.infinispan.org">http://www.infinispan.org</a></div><div><a href="http://www.jbosscache.org">http://www.jbosscache.org</a></div><div><br></div></div></span><br class="Apple-interchange-newline"></div></span><br class="Apple-interchange-newline"> </div><br></div></div></div></body></html>