<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On 6 Sep 2010, at 14:33, Manik Surtani wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On 6 Sep 2010, at 14:28, Mircea Markus wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><span class="Apple-style-span" style="border-collapse: separate; font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; "><div><blockquote type="cite"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div><div>I notice you've ripped this logic out of the InvocationContextInterceptor in branches/4.2.x</div><div><br></div><div><a href="http://fisheye.jboss.org/browse/Infinispan/branches/4.2.x/core/src/main/java/org/infinispan/interceptors/InvocationContextInterceptor.java?r1=2273&r2=2323&u=3#l45">http://fisheye.jboss.org/browse/Infinispan/branches/4.2.x/core/src/main/java/org/infinispan/interceptors/InvocationContextInterceptor.java?r1=2273&r2=2323&u=3#l45</a></div><div><br></div><div>Note that this is incorrect since, as I pointed out, you will miss exceptions thrown between the InvocationContextInterceptor and the LockingInterceptor.</div></div></div></blockquote>This code was committed before this discussion to take place. I needed it in because couldn't work on DLD without it). </div><div>It wil be addressed in <span class="Apple-style-span" style="color: rgb(51, 51, 51); font-family: arial, FreeSans, Helvetica, sans-serif; font-size: 14px; line-height: 19px; "><a id="key-val" href="x-msg://19/browse/ISPN-629" style="cursor: pointer; text-decoration: none; color: rgb(60, 120, 181); ">ISPN-629</a></span></div></span></blockquote><br></div><div>Ok, just be careful when rolling it back/reimplementing - it's tricky stuff. A few extra tests around it would be a good idea as well. :)</div></div></blockquote>Of course- that's why I added these [1] before making the changes :) <br>[1] <a href="http://fisheye.jboss.org/browse/Infinispan/branches/4.2.x/core/src/test/java/org/infinispan/tx/timeout">http://fisheye.jboss.org/browse/Infinispan/branches/4.2.x/core/src/test/java/org/infinispan/tx/timeout</a></div><br></body></html>