<br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
Some doubts:<br>
1) I see you don't depend on the mux implementation<br>
org.jboss.ha.core.channelfactory.MuxChannel but in the one provided in<br>
jgroups. I was recommended to use<br>
org.jboss.ha.core.channelfactory.MuxChannel, but don't remember the<br>
reason, if any it might be outdated. Did you find out there's no need<br>
for this additional dependency?<br></blockquote><div><br>I can't remember exactly the difference between the two, although I don't think there were any real benefits in the org.jboss.ha stuff, and having one class instead of another dependency is better :)<br>
</div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<br>
2) Could you clarify the licensing, I'd like to reuse some of this<br>
code if possible.<br>
I hope it will be Hibernate Search compatible, also because I see you<br>
copied some code.. could you then restore the original @authors where<br>
due? (I might be wrong and didn't check in depth, just the methods in<br>
ExecutorContext look very similar to Search's Workspace. Actually it<br>
seems you was inspired by an older copy, while some bugs where now<br>
fixed *1, so you might as well want to depend on that code instead, to<br>
get more fixes in future).<br></blockquote><div><br>Hmm, I usually use the Apache License, and I didn't really think about licensing conflicts here. I can't remember if I copied the code, but I need to look at that in more detail. Don't want to ruffle any feathers :) If any of my code ends up in Hibernate Search's backend, I'd rather use that if possible. Obviously it needs to be decoupled from the Hibernate part :)<br>
</div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<br>
3) I can't compile it:<br>
Non-resolvable parent POM: Could not find artifact<br>
net.dataforte:dataforte-parent:pom:6<br></blockquote><div><br>It's on my repo, look at my blog post.<br> <br></div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<br>
4) I'd recommend you to make the IndexOperation implementations<br>
immutable, it seems you're suffering a bit from index visibility.<br></blockquote><div><br>:)<br> <br></div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<br>
5) No tests ? :P<br>
<br></blockquote><div><br><guilty_look>I'm sure they were there a minute ago :)</guilty_look><br><br>Thanks for your comments.<br></div></div><br>Tristan<br>