<html><head><base href="x-msg://29/"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">I'll let Vladimir comment more as he wrote most of this code originally, but it sounds OK in principle. <div><br></div><div>Would you need to check the memory usage on every put and replace? Wouldn't this be expensive? Couldn't this happen periodically?<div><br><div><div>On 14 Jan 2011, at 03:22, david marion wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><span class="Apple-style-span" style="border-collapse: separate; font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; "><div class="hmmessage" style="font-size: 10pt; font-family: Tahoma; "><div style="margin-top: 0in; margin-right: 0in; margin-bottom: 0pt; margin-left: 0in; padding-top: 0px; padding-right: 0px; padding-bottom: 0px; padding-left: 0px; "><span style="font-family: Arial; color: navy; font-size: 10pt; ">I have been looking at the code and think I have a starting point on the design. Remember, the goal here is to be able to create a cache that uses expiration but has no defined cache size limit. Reading through the code, if ‘-1’ is specified for the eviction maxEntries, then a ConcurrentHashMap is created and used as the data container and no eviction is performed. Otherwise a BoundedConcurrentHashMap is created and used as the data container and eviction is performed according to the specified strategy.</span><o:p></o:p></div><div style="margin-top: 0in; margin-right: 0in; margin-bottom: 0pt; margin-left: 0in; padding-top: 0px; padding-right: 0px; padding-bottom: 0px; padding-left: 0px; "><span style="font-family: Arial; color: navy; font-size: 10pt; "> </span><o:p></o:p></div><div style="margin-top: 0in; margin-right: 0in; margin-bottom: 0pt; margin-left: 0in; padding-top: 0px; padding-right: 0px; padding-bottom: 0px; padding-left: 0px; "><span style="font-family: Arial; color: navy; font-size: 10pt; ">Eviction currently appears to happen in two different ways:</span><o:p></o:p></div><div style="margin-top: 0in; margin-right: 0in; margin-bottom: 0pt; margin-left: 0in; padding-top: 0px; padding-right: 0px; padding-bottom: 0px; padding-left: 0px; "><span style="font-family: Arial; color: navy; font-size: 10pt; "> </span><o:p></o:p></div><div style="margin-top: 0in; margin-right: 0in; margin-bottom: 0pt; margin-left: 0.75in; padding-top: 0px; padding-right: 0px; padding-bottom: 0px; padding-left: 0px; text-indent: -0.25in; "><span style="font-family: Arial; color: navy; font-size: 10pt; ">1.</span><span style="color: navy; font-size: 7pt; "><font face="Times New Roman"> <span class="Apple-converted-space"> </span></font></span><span style="font-family: Arial; color: navy; font-size: 10pt; ">If an entry is expired, then it can be evicted.</span><o:p></o:p></div><div style="margin-top: 0in; margin-right: 0in; margin-bottom: 0pt; margin-left: 0.75in; padding-top: 0px; padding-right: 0px; padding-bottom: 0px; padding-left: 0px; text-indent: -0.25in; "><span style="font-family: Arial; color: navy; font-size: 10pt; ">2.</span><span style="color: navy; font-size: 7pt; "><font face="Times New Roman"> <span class="Apple-converted-space"> </span></font></span><span style="font-family: Arial; color: navy; font-size: 10pt; ">If the number of entries in a segment of the cache contains more entries than “allowed” by the configuration.</span><o:p></o:p></div><div style="margin-top: 0in; margin-right: 0in; margin-bottom: 0pt; margin-left: 0in; padding-top: 0px; padding-right: 0px; padding-bottom: 0px; padding-left: 0px; "><span style="font-family: Arial; color: navy; font-size: 10pt; "> </span><o:p></o:p></div><div style="margin-top: 0in; margin-right: 0in; margin-bottom: 0pt; margin-left: 0in; padding-top: 0px; padding-right: 0px; padding-bottom: 0px; padding-left: 0px; "><span style="font-family: Arial; color: navy; font-size: 10pt; ">Here are the modifications that I think need to be made. I have not made any code mods yet, so I don’t know for sure if this will work. Definitely looking for feedback.</span><o:p></o:p></div><div style="margin-top: 0in; margin-right: 0in; margin-bottom: 0pt; margin-left: 0in; padding-top: 0px; padding-right: 0px; padding-bottom: 0px; padding-left: 0px; "><span style="font-family: Arial; color: navy; font-size: 10pt; "> </span><o:p></o:p></div><ol type="1" style="margin-top: 0in; "><li class="MsoNormal" style="margin-top: 0in; margin-right: 0in; margin-bottom: 0pt; margin-left: 0in; color: navy; "><span style="font-family: Arial; font-size: 10pt; ">Modify configuration in some way so that the following can be specified:</span><o:p></o:p></li><ol type="a" style="margin-top: 0in; "><li class="MsoNormal" style="margin-top: 0in; margin-right: 0in; margin-bottom: 0pt; margin-left: 0in; color: navy; "><span style="font-family: Arial; font-size: 10pt; ">The percentage value of used JVM memory (i.e. 95) at which entries should be evicted to try and avoid an OOM error.</span><o:p></o:p></li><li class="MsoNormal" style="margin-top: 0in; margin-right: 0in; margin-bottom: 0pt; margin-left: 0in; color: navy; "><span style="font-family: Arial; font-size: 10pt; ">The number of items that should be evicted when memory reaches this threshold</span><o:p></o:p></li></ol><li class="MsoNormal" style="margin-top: 0in; margin-right: 0in; margin-bottom: 0pt; margin-left: 0in; color: navy; "><span style="font-family: Arial; font-size: 10pt; ">Modify LRU and LIRS Eviction class so that the accessQueue member can be accessed by the new Eviction class so that two access queues don’t have to be maintained.</span><o:p></o:p></li><li class="MsoNormal" style="margin-top: 0in; margin-right: 0in; margin-bottom: 0pt; margin-left: 0in; color: navy; "><span style="font-family: Arial; font-size: 10pt; ">Create a new Eviction class, a subclass of LIRS, where the accessQueue is used from the Eviction strategy the user specifies and the for loop in the execute method is exited when the evicted set equals value from 1.b above.</span><o:p></o:p></li><li class="MsoNormal" style="margin-top: 0in; margin-right: 0in; margin-bottom: 0pt; margin-left: 0in; color: navy; "><span style="font-family: Arial; font-size: 10pt; ">Modify DataContainerFactory.construct() to call DefaultDataContainer.boundedDataContainer() regardless of eviction policy. This will always create a BoundedConcurrentHashMap</span><o:p></o:p></li><li class="MsoNormal" style="margin-top: 0in; margin-right: 0in; margin-bottom: 0pt; margin-left: 0in; color: navy; "><span style="font-family: Arial; font-size: 10pt; ">Create an instance of the new Eviction class in each segment.</span><o:p></o:p></li><li class="MsoNormal" style="margin-top: 0in; margin-right: 0in; margin-bottom: 0pt; margin-left: 0in; color: navy; "><span style="font-family: Arial; font-size: 10pt; ">Modify BoundedConcurrentHashMap.Segment put and replace methods such that when new values are going to be put into the Segment, the memory usage is checked and the execute method is called on the new Eviction class.</span><o:p></o:p></li></ol><div style="margin-top: 0in; margin-right: 0in; margin-bottom: 0pt; margin-left: 0in; padding-top: 0px; padding-right: 0px; padding-bottom: 0px; padding-left: 0px; "><span style="font-family: Arial; color: navy; font-size: 10pt; "> </span><o:p></o:p></div><div style="margin-top: 0in; margin-right: 0in; margin-bottom: 0pt; margin-left: 0in; padding-top: 0px; padding-right: 0px; padding-bottom: 0px; padding-left: 0px; "><span style="font-family: Arial; color: navy; font-size: 10pt; ">Questions:</span><o:p></o:p></div><div style="margin-top: 0in; margin-right: 0in; margin-bottom: 0pt; margin-left: 0in; padding-top: 0px; padding-right: 0px; padding-bottom: 0px; padding-left: 0px; "><span style="font-family: Arial; color: navy; font-size: 10pt; "> </span><o:p></o:p></div><ol type="1" style="margin-top: 0in; "><li class="MsoNormal" style="margin-top: 0in; margin-right: 0in; margin-bottom: 0pt; margin-left: 0in; color: navy; "><span style="font-family: Arial; font-size: 10pt; ">What are the implications of using a BoundedConcurrentHashMap instead of a ConcurrentHashMap when maxEntries is set to -1?</span><o:p></o:p></li></ol><div style="margin-top: 0in; margin-right: 0in; margin-bottom: 0pt; margin-left: 0in; padding-top: 0px; padding-right: 0px; padding-bottom: 0px; padding-left: 0px; "><span style="font-family: Arial; color: navy; font-size: 10pt; "> </span><o:p></o:p></div><div style="margin-top: 0in; margin-right: 0in; margin-bottom: 0pt; margin-left: 0in; padding-top: 0px; padding-right: 0px; padding-bottom: 0px; padding-left: 0px; "><span style="font-family: Arial; color: navy; font-size: 10pt; ">Thoughts</span><o:p></o:p></div><div style="margin-top: 0in; margin-right: 0in; margin-bottom: 0pt; margin-left: 0in; padding-top: 0px; padding-right: 0px; padding-bottom: 0px; padding-left: 0px; "><span style="font-family: Arial; color: navy; font-size: 10pt; "> </span><o:p></o:p></div><ol type="1" style="margin-top: 0in; "><li class="MsoNormal" style="margin-top: 0in; margin-right: 0in; margin-bottom: 0pt; margin-left: 0in; color: navy; "><span style="font-family: Arial; font-size: 10pt; ">This will not guarantee that an OOM error does not occur. It will attempt to guard against an OOM caused by putting new values into the cache. This will probably be more effective when the cache is being used in client/server mode, and less effective when used in embedded mode as to other code running in the JVM.</span><o:p></o:p></li></ol><div style="margin-top: 0in; margin-right: 0in; margin-bottom: 0pt; margin-left: 0in; padding-top: 0px; padding-right: 0px; padding-bottom: 0px; padding-left: 0px; "><span style="font-family: Arial; color: navy; font-size: 10pt; "> </span><o:p></o:p></div><div style="margin-top: 0in; margin-right: 0in; margin-bottom: 0pt; margin-left: 0in; padding-top: 0px; padding-right: 0px; padding-bottom: 0px; padding-left: 0px; "><span style="font-family: Arial; color: navy; font-size: 10pt; "> </span><o:p></o:p></div><div style="margin-top: 0in; margin-right: 0in; margin-bottom: 0pt; margin-left: 0in; padding-top: 0px; padding-right: 0px; padding-bottom: 0px; padding-left: 0px; "><span style="font-family: Arial; color: navy; font-size: 10pt; ">-- Dave Marion</span><o:p></o:p></div><br> <br><hr id="stopSpelling">From:<span class="Apple-converted-space"> </span><a href="mailto:manik@jboss.org">manik@jboss.org</a><br>Date: Tue, 11 Jan 2011 11:46:40 +0000<br>To:<span class="Apple-converted-space"> </span><a href="mailto:infinispan-dev@lists.jboss.org">infinispan-dev@lists.jboss.org</a><br>Subject: [infinispan-dev] Poor man's size-based eviction Re: ISPN-863<br><br><div>Hi Dave</div><div><br></div><div>Just saw that you signed the contributor agreement.</div><div><br></div><div>So yeah, what you may want to look into is the EvictionManager [1] which will periodically have its processEviction() [2] method called. This doesn't actually do any evictions here (named so for legacy reasons) since the current data container is self-sizing/evicting. However it is still periodically invoked to purge expired entries. </div><div><br></div><div>You can piggyback on the same invocation to test upper and lower bounds of memory utilisation (if enabled), but the bit that I still think you need to figure out is deciding which entries to evict, and how many of them to evict.</div><div><br></div><div>Cheers</div><div>Manik</div><div><br></div><div>[1] <a href="https://github.com/infinispan/infinispan/blob/master/core/src/main/java/org/infinispan/eviction/EvictionManagerImpl.java" target="_blank">https://github.com/infinispan/infinispan/blob/master/core/src/main/java/org/infinispan/eviction/EvictionManagerImpl.java</a></div><div>[2] <a href="https://github.com/infinispan/infinispan/blob/master/core/src/main/java/org/infinispan/eviction/EvictionManagerImpl.java#L84" target="_blank">https://github.com/infinispan/infinispan/blob/master/core/src/main/java/org/infinispan/eviction/EvictionManagerImpl.java#L84</a></div><br><div><div>On 10 Jan 2011, at 11:08, Manik Surtani wrote:</div><br class="ecxApple-interchange-newline"><blockquote><div style="word-wrap: break-word; ">Excellent, Dave.<div><br></div><div>You should probably come up with a design first - or maybe a prototype on your fork of the project on GitHub - and post it here for comment.</div><div><br></div><div>Cheers</div><div>Manik</div><div><br><div><div>On 8 Jan 2011, at 00:34, david marion wrote:</div><br class="ecxApple-interchange-newline"><blockquote><div class="ecxhmmessage" style="font-family: Tahoma; font-size: 10pt; "><div style="padding-bottom: 0px; padding-left: 0px; padding-right: 0px; margin-bottom: 0pt; margin-left: 0in; margin-right: 0in; padding-top: 0px; "><span style="font-family: Arial; font-size: 10pt; ">Manik,</span></div><div style="padding-bottom: 0px; padding-left: 0px; padding-right: 0px; margin-bottom: 0pt; margin-left: 0in; margin-right: 0in; padding-top: 0px; "><span style="font-family: Arial; font-size: 10pt; "> </span></div><div style="padding-bottom: 0px; text-indent: 6pt; padding-left: 0px; padding-right: 0px; margin-bottom: 0pt; margin-left: 0in; margin-right: 0in; padding-top: 0px; "><span style="font-family: Arial; font-size: 10pt; ">I am on the list. I will start getting my dev environment setup according to instructions on site.</span></div><div style="padding-bottom: 0px; padding-left: 0px; padding-right: 0px; margin-bottom: 0pt; margin-left: 0in; margin-right: 0in; padding-top: 0px; "><span style="font-family: Arial; font-size: 10pt; "> </span></div><div style="padding-bottom: 0px; padding-left: 0px; padding-right: 0px; margin-bottom: 0pt; margin-left: 0in; margin-right: 0in; padding-top: 0px; "><span style="font-family: Arial; font-size: 10pt; ">Dave Marion</span></div><span style="font-family: Arial; font-size: 10pt; "> </span><span class="ecxApple-converted-space"> </span>_______________________________________________<br>infinispan-dev mailing list<br><a href="mailto:infinispan-dev@lists.jboss.org">infinispan-dev@lists.jboss.org</a><br><a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a></div></blockquote></div><br><div><div><div>--</div><div>Manik Surtani</div><div><a href="mailto:manik@jboss.org">manik@jboss.org</a></div><div><a href="http://twitter.com/maniksurtani" target="_blank">twitter.com/maniksurtani</a></div><div><br></div><div>Lead, Infinispan</div><div><a href="http://www.infinispan.org/" target="_blank">http://www.infinispan.org</a></div><div><br></div></div><br class="ecxApple-interchange-newline"></div><br></div></div>_______________________________________________<br>infinispan-dev mailing list<br><a href="mailto:infinispan-dev@lists.jboss.org">infinispan-dev@lists.jboss.org</a><br><a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a></blockquote></div><br><div><span class="ecxApple-style-span" style="text-transform: none; text-indent: 0px; border-collapse: separate; font: normal normal normal medium/normal Helvetica; white-space: normal; letter-spacing: normal; color: rgb(0, 0, 0); word-spacing: 0px; "><div><div>--</div><div>Manik Surtani</div><div><a href="mailto:manik@jboss.org">manik@jboss.org</a></div><div><a href="http://twitter.com/maniksurtani" target="_blank">twitter.com/maniksurtani</a></div><div><br></div><div>Lead, Infinispan</div><div><a href="http://www.infinispan.org/" target="_blank">http://www.infinispan.org</a></div><div><br></div></div></span><br class="ecxApple-interchange-newline"></div><br><br>_______________________________________________ infinispan-dev mailing list<span class="Apple-converted-space"> </span><a href="mailto:infinispan-dev@lists.jboss.org">infinispan-dev@lists.jboss.org</a><span class="Apple-converted-space"> </span><a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a>_______________________________________________<br>infinispan-dev mailing list<br><a href="mailto:infinispan-dev@lists.jboss.org">infinispan-dev@lists.jboss.org</a><br><a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a></div></span></blockquote></div><br><div>
<span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; "><div><div>--</div><div>Manik Surtani</div><div><a href="mailto:manik@jboss.org">manik@jboss.org</a></div><div><a href="http://twitter.com/maniksurtani">twitter.com/maniksurtani</a></div><div><br></div><div>Lead, Infinispan</div><div><a href="http://www.infinispan.org">http://www.infinispan.org</a></div><div><br></div></div></span><br class="Apple-interchange-newline">
</div>
<br></div></div></body></html>