<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div>Great feedback, Pete. +1 to all suggestions here, I've added a few more notes inline with some of the points below. Feel like making the changes you've suggested?</div><div><br></div><div>Galder, could you pls help with the Scala-related points?</div><div><br></div><div>Cheers</div><div>Manik</div><div><br></div><br><div><div>On 18 Jan 2011, at 16:17, Pete Muir wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div>As part of getting up to speed with infinispan, I've been running through the docs and tutorials. Some thoughts<br><br>1) <a href="http://www.jboss.org/infinispan/downloads.html">http://www.jboss.org/infinispan/downloads.html</a><br></div></blockquote><div><br></div><div>+1, along with links to the Infinispan Maven wiki pages for more detailed info. But definitely +1 for a quick-access copy-and-paste snippet.</div><div><br></div><blockquote type="cite"><div>2) <a href="http://www.jboss.org/infinispan/downloads.html">http://www.jboss.org/infinispan/downloads.html</a><br><br>Suggest adding two code snippet for the dependency too:<br></div></blockquote><div><br></div><div>+1 again. This info is already up there, but +1 for easy to copy snippets.</div><div><br></div><blockquote type="cite"><div>3) <a href="http://community.jboss.org/wiki/5minutetutorialonInfinispan">http://community.jboss.org/wiki/5minutetutorialonInfinispan</a></div><div><br>Cache cache = manager.getCache();<br></div></blockquote><div><br></div><div>There were issues with angle brackets on the wiki system, this may have been fixed now. </div><blockquote type="cite"><div><font class="Apple-style-span" color="#000000"><br></font>4) <a href="http://community.jboss.org/wiki/5minutetutorialonInfinispan">http://community.jboss.org/wiki/5minutetutorialonInfinispan</a><br><br>To make this totally fool proof, might want to indicate how people can run this, e.g. in a main method on a class. This also really highlights how "lightweight" this stuff is (no need for a big server etc.)</div></blockquote><br><blockquote type="cite"><div>5) <a href="http://community.jboss.org/wiki/5minutetutorialonInfinispan">http://community.jboss.org/wiki/5minutetutorialonInfinispan</a><br><br>For the expiration, might want to adjust the values a bit. 60s is a long time to wait, and also setting the expiration to 60s, and the thread sleep to 60s is risking the assertion failing (it did for me). I would suggest something more like 5s expiration, 10s sleep.</div></blockquote><blockquote type="cite"><div><br>6) <a href="http://community.jboss.org/wiki/InstallingInfinispantutorialenvironment">http://community.jboss.org/wiki/InstallingInfinispantutorialenvironment</a><br><br>This information is really useful, and I would suggest splitting out the groovy bit and then adding a link from the 5 min tutoiral<br><br>7) <a href="http://community.jboss.org/wiki/InstallingInfinispantutorialenvironment">http://community.jboss.org/wiki/InstallingInfinispantutorialenvironment</a><br><br>Some of the instructions on this page could be clearer if they all built as code blocks. For example, following the groovy ones, I struggled reading the first paragraph, it would have been helpful to split this up and provide code snippets to use like:<br><br>$> cp $INFINISPAN_HOME/infinispan-core.jar ~/.groovy/lib/<br><br>etc.<br><br>8) <a href="http://community.jboss.org/wiki/InstallingInfinispantutorialenvironment">http://community.jboss.org/wiki/InstallingInfinispantutorialenvironment</a><br><br>The location of infinispan-core jars and dependencies has changed from $INFNISPAN_HOME/modules/core to $INIFINISPAN_HOME, the tutorial needs updating<br><br>9) <a href="http://community.jboss.org/wiki/Infinispaninteractivetutorial">http://community.jboss.org/wiki/Infinispaninteractivetutorial</a><br><br>When doing the below line, I get an error:<br><br>And now, create a cache manager indicating the file with the cache definitions.<br>groovy:000> manager = new DefaultCacheManager("sample-configurations.xml"<br>)<br>===> org.infinispan.manager.DefaultCacheManager@19cc1b@Address:<br>null<br><br>oovy:000> manager = new DefaultCacheManager("/Users/pmuir/Downloads/sample-configurations.xml")<br>ERROR java.io.IOException:<br>null<br> at org.infinispan.config.InfinispanConfiguration.newInfinispanConfiguration (InfinispanConfiguration.java:264)<br> at org.infinispan.config.InfinispanConfiguration.newInfinispanConfiguration (InfinispanConfiguration.java:282)<br> at org.infinispan.config.InfinispanConfiguration.newInfinispanConfiguration (InfinispanConfiguration.java:136)<br> at org.infinispan.manager.DefaultCacheManager.<init> (DefaultCacheManager.java:243)<br> at org.infinispan.manager.DefaultCacheManager.<init> (DefaultCacheManager.java:229)<br> at groovysh_evaluate.run (groovysh_evaluate:4)<br><br>and I don't know how to get past it, so I stopped this tutorial here.<br></div></blockquote><div><br></div><div>Hmm, could be a missing schema? Did you enable log4j TRACE level logging to see what was going on?</div><div><br></div><blockquote type="cite"><div>10) <a href="http://community.jboss.org/wiki/InfinispanInteractiveTutorialwithScala">http://community.jboss.org/wiki/InfinispanInteractiveTutorialwithScala</a><br><br>Could do with some comments explaining what each line is doing, some of the code isn't self describing<br><br>e.g.<br><br>what does me entering val defaultCache = manager.getCache[String, String]() actually achieve?<br><br></div></blockquote><div><br></div><div>Galder, care to look into this one?</div><br><blockquote type="cite"><div>11) <a href="http://community.jboss.org/wiki/InfinispanInteractiveTutorialwithScala">http://community.jboss.org/wiki/InfinispanInteractiveTutorialwithScala</a><br><br>It might be neat to split up input and output e.g. into different snippets - make it easier to read<br><br>12) <a href="http://community.jboss.org/wiki/InfinispanInteractiveTutorialwithScala">http://community.jboss.org/wiki/InfinispanInteractiveTutorialwithScala</a><br><br>For "Cache with Transaction Management" I was not seeing TX semantics being obeyed, I saw the size increment as a added key-value pairs<br></div></blockquote><div><br></div>Galder, this as well?</div><div><br><blockquote type="cite"><div>13) <a href="http://community.jboss.org/wiki/SettingupanInfinispanCluster">http://community.jboss.org/wiki/SettingupanInfinispanCluster</a><br><br>When I do gc.setTransportClass(JGroupsTransport.class.getName()); and import JGroupsTransport I get two options, one from Infinispan and one from JGroups, tutorial should saw which to import.<br></div></blockquote><div><br></div><div>It should be the Infinispan one - the fully qualified classname can be seen in the next XML snippet. Maybe the Java snippet should use the fqcn as well.</div><div><br></div><br><blockquote type="cite"><div>14) <a href="http://community.jboss.org/wiki/SettingupanInfinispanCluster">http://community.jboss.org/wiki/SettingupanInfinispanCluster</a><br><br>The CacheManager is deprecated, I guess these needs updating to 4.2 API?<br></div></blockquote><div><br></div><div>Yes.</div><br><blockquote type="cite"><div><br>15) <a href="http://community.jboss.org/wiki/SettingupanInfinispanCluster">http://community.jboss.org/wiki/SettingupanInfinispanCluster</a><br><br>I would suggest adding some instructions about how to do a simple test to see the cluster working, atm the tutorial seems to end in middle of something. There are hints in the comment, but nothing concrete<br></div></blockquote><div><br></div><div>Perhaps starting 2 nodes using main() methods, in different terminals, and reverting back to the 5-min tutorial trying stuff on alternate instances?</div><div><br></div><div>Cheers</div><div>Manik</div></div><div>
<span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; "><div><div>--</div><div>Manik Surtani</div><div><a href="mailto:manik@jboss.org">manik@jboss.org</a></div><div><a href="http://twitter.com/maniksurtani">twitter.com/maniksurtani</a></div><div><br></div><div>Lead, Infinispan</div><div><a href="http://www.infinispan.org">http://www.infinispan.org</a></div><div><br></div></div></span><br class="Apple-interchange-newline">
</div>
<br></body></html>