<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On 2 Feb 2011, at 14:47, Galder Zamarreņo wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div>Some comments, in:<br><br>name="idealdistribution/dist-sync-ideal-distribution.xml" useEvenHashing="true<br><br>Does dist-sync-ideal-distribution.xml differ in any way to dist-sync.xml? The reason I ask is cos reading the wiki, it seems like useEvenHashing "makes Infinispan plugin to use the ideal consistent hashing implementation rather than the configured one". </div></blockquote>Good point. I've removed useEvenHashing and leave the hash to be configured in ISPN. <blockquote type="cite"><div>So, if dist-sync-ideal-distribution.xml and dist-sync.xml are different, in which way are they different and way? Seems like RadarGun could already make the changes the necessary to make dist-sync use ideal CH?<span class="Apple-tab-span" style="white-space:pre"> </span><br></div></blockquote>Now they would be different in the consistent hashing class used. <br><blockquote type="cite"><div><br>Reading futther, it seems like Infinispan config must have:<br><hash numOwners="2" rehashEnabled="false" rehashRpcTimeout="60000" class="org.radargun.cachewrappers.EvenSpreadingConsistentHash"/><br><br>I think RadarGun could do these modifications without forcing users to have a separate dist-sync-*.xml file.<br></div></blockquote><div>+1. Just that right now Radargun relies on the name of the file in order to include it in the report, so two different files should be configured.</div><div>This needs to change: <a href="https://sourceforge.net/apps/trac/radargun/ticket/19">https://sourceforge.net/apps/trac/radargun/ticket/19</a></div><blockquote type="cite"><div><br>Also, if useEvenHashing="true", can't the code handling the config take the benchmarks numOfThreads and assign it to threadsPerNode? </div></blockquote><blockquote type="cite"><div><br>Also, you're saying that WebSessionBenchmark.numOfThreads and keysPerThread must be the same but in the wiki they're not. Also, as per my last comment, if there's a relationship between keysPerThread and the benchmark config, couldn't the RadarGun figure that out?<br></div></blockquote>Indeed! <a href="https://sourceforge.net/apps/trac/radargun/ticket/20">https://sourceforge.net/apps/trac/radargun/ticket/20</a><br><blockquote type="cite"><div><br>Thanks for writing this up!<br></div></blockquote>Thanks again for the excellent feedback!<br></div><br></body></html>