<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On 15 Apr 2011, at 18:00, Olaf Bergner wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div>Am 15.04.11 16:56, schrieb Manik Surtani:<br><blockquote type="cite">On 11 Apr 2011, at 13:13, Galder Zamarreņo wrote:<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite"><blockquote type="cite">- Rather than modifying PutKeyValueCommand, it might be better to subclass it and add the large object logic there? i.e. PutLargeKeyValueCommand - I'd also suggest adding a new build* method in the command factory...etc. This keeps the code more fine grained.<br></blockquote></blockquote><blockquote type="cite">I don't understand why you need a specialised PutKVCommand? How is behaviour different?<br></blockquote>In its present shape PutKVCommand will *always* attempt to read the <br>given key's value before proceeding to store the new value. I doubt that <br>we need this for large objects. To determine if we are to perform a <br>create or an update it suffices to consult the metadata cache. We won't <br>be returning the former value anyway.<br></div></blockquote><div><br></div><div>Understood. Even locking semantics would be different since you only acquire the lock on the metadata entry and not on each and every chunk. Correct?</div><div><br></div><div>So I presume you are building this as a separate Maven module, and making use of the module-specific commands as described here [1] and [2] ?</div><div><br></div><div>Cheers</div><div>Manik</div><div><br></div><div>[1] <a href="https://issues.jboss.org/browse/ISPN-256?focusedCommentId=12586154#comment-12586154">https://issues.jboss.org/browse/ISPN-256?focusedCommentId=12586154#comment-12586154</a></div><div>[2] <a href="https://github.com/infinispan/infinispan-sample-module">https://github.com/infinispan/infinispan-sample-module</a> </div><div>--</div></div><div><div><div>Manik Surtani</div><div><a href="mailto:manik@jboss.org">manik@jboss.org</a></div><div><a href="http://twitter.com/maniksurtani">twitter.com/maniksurtani</a></div><div><br></div><div>Lead, Infinispan</div><div><a href="http://www.infinispan.org">http://www.infinispan.org</a></div><div><br></div></div><br class="Apple-interchange-newline">
</div>
<br></body></html>