<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On 4 Apr 2011, at 18:24, Sanne Grinovero wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div><blockquote type="cite"><br></blockquote><blockquote type="cite">- getBasicQuery methods are deprecated. That's from the previous design right? Was it a tech preview or was it named as full fledged API?<br></blockquote><blockquote type="cite">In the former case I'd get rid of them.<br></blockquote><br>Yes that was a tech preview, I'll remove them, but maybe better keep<br>them for a single release?<br>There's a grails plugin which exposes these methods.<br></div></blockquote><div><br></div><div>Mark them as deprecated and ping the maintainer of the grails plugin?</div><br><blockquote type="cite"><div><font class="Apple-style-span" color="#006312"><br></font><blockquote type="cite">- I'm not a big fan of the constructor approach to get QueryFactory for various reasons (including the fact that it forces a concrete type and no interfaces) but it seems to be an ISPN-wide design decision<br></blockquote><blockquote type="cite">That's definitely something that could be improved in a Seam Infinispan module.<br></blockquote><br>I knew you where going to say that :) but yes this seems to be more<br>Infinispan-style.<br>I've considered something like a Search.getQueryFactory(Cache c) .. WDYT?<br></div></blockquote><div><br></div><div>+1.</div><br><blockquote type="cite"><div>This wouldn't return a "FullTextCache" but the manager, I see no<br>reason to delegate a cache like we do with a o.h.Session.<br><br><blockquote type="cite">- I'd rename QueryFactory to something else as conceptually it's more an entry point to anything related to Hibernate Search, potentially indexing, stats etc: maybe SearchManager, SearchProvider, GridSearcher, TheGridReaper?<br></blockquote>right!<br>which one? I like the first three.<br></div></blockquote><div><br></div><div>SearchManager would be inline with other Infinispan components. QueryManager perhaps?</div><br><blockquote type="cite"><div><blockquote type="cite">- is there an easy metaconfig to ask ISPN to store the HSearch indexes in ISPN :)</blockquote>No, but agree that would be awesome. would require changes though in<br>all involved projects:<br>1) H.S. would bee to be able to start on a DirectoryProvider instance we pass in<br>2) Infinispan Directory module (the submodule of H.S.) would need to<br>be able to reconfigure an existing cachemanager configuration during<br>the startup<br>3) Infinispan Core needs to be adapted for the additional configuration fields<br>currently it's not that hard, just a single property:<br><br><indexing enabled="true" indexLocalOnly="true"><br> <properties><br> <property<br> name="hibernate.search.default.directory_provider" value="infinispan" /><br></div></blockquote><div><br></div><div>Could this be the default, if no other directory provider is specified?</div><br><blockquote type="cite"><div> </properties><br></indexing><br><br> downside is that it will start a second cachemanager with a second<br>JGroups channel, instead of reusing the same.<br></div></blockquote><div><br></div><div>Could it not use the same cache manager?</div><br><blockquote type="cite"><div><br><blockquote type="cite"><br></blockquote><blockquote type="cite">- you can't do cross Cache queries today. Is that expected? for me CacheManager.getGridSearcher almost makes sense.<br></blockquote>Very interesting concept. I'll see how that fits in the code; I can't<br>add methods to the CacheManager itself, but maybe I can make sure that<br>interceptors registered on different caches share the same<br>MutableSearchFactory.<br></div></blockquote><div><br></div><div>Perhaps something for SearchManager/QueryManager... </div><div><br></div></div><div><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; "><div><div>Cheers</div><div>Manik</div><div>--</div><div>Manik Surtani</div><div><a href="mailto:manik@jboss.org">manik@jboss.org</a></div><div><a href="http://twitter.com/maniksurtani">twitter.com/maniksurtani</a></div><div><br></div><div>Lead, Infinispan</div><div><a href="http://www.infinispan.org">http://www.infinispan.org</a></div><div><br></div></div></span><br class="Apple-interchange-newline">
</div>
<br></body></html>