<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
Am 21.04.11 21:57, schrieb Manik Surtani:
<blockquote
cite="mid:10500404-D7EF-48F8-91D8-0922492F1F46@redhat.com"
type="cite">
<div>I'd prefer the tests ported to testNG for consistency pls. :)</div>
</blockquote>
Sigh. You owe me a favour. Just kidding. Luckily it's Easter, maybe
I will find some spare time that has been so lavishly allotted to me
:-)<br>
<br>
Cheers,<br>
Olaf<br>
<blockquote
cite="mid:10500404-D7EF-48F8-91D8-0922492F1F46@redhat.com"
type="cite">
<div><br>
Sent from my mobile phone</div>
<div><br>
On 21 Apr 2011, at 20:54, Olaf Bergner <<a
moz-do-not-send="true" href="mailto:olaf.bergner@gmx.de">olaf.bergner@gmx.de</a>>
wrote:<br>
<br>
</div>
<blockquote type="cite">
<div> Am 21.04.11 19:47, schrieb Manik Surtani:
<blockquote
cite="mid:179B11F1-9B21-4BC5-887E-C58E465ACDDA@jboss.org"
type="cite"><br>
<div>
<div>On 21 Apr 2011, at 18:17, Olaf Bergner wrote:</div>
<br class="Apple-interchange-newline">
<blockquote type="cite">
<div>Hi Manik,<br>
<br>
Am 21.04.11 16:11, schrieb Manik Surtani:<br>
</div>
</blockquote>
<blockquote type="cite">
<div>Since it's just a new module that doesn't affect
the current code base <br>
in any way I too think that it makes sense to have
this in 4.2.x. Are <br>
there any commit rules I should pay attention to? I.e.
do I create this <br>
module in 4.2.x and merge that into master? Or the
other way around? How <br>
do you usually handle this?<br>
</div>
</blockquote>
<div><br>
</div>
<div>Since this is a new and clean module it doesn't
matter which direction it goes. Maybe commit into 4.2.x
and cherry pick the commit onto master? Remember that
you still should use topic branches for each of these
commits and issue a pull request to upstream.</div>
</div>
</blockquote>
Topic branches are a given. So I will move Spring-Infinispan
to a new submodule using a new topic branch t_ispn961, rebase
that on 4.2.x and issue a pull request. Provided that is
accepted, I'll do likewise on master, correct?<br>
<blockquote
cite="mid:179B11F1-9B21-4BC5-887E-C58E465ACDDA@jboss.org"
type="cite">
<div>
<div><br>
</div>
<div><a moz-do-not-send="true"
href="http://community.jboss.org/wiki/InfinispanandGitHub">http://community.jboss.org/wiki/InfinispanandGitHub</a></div>
<div><br>
</div>
<div>Also have a look at one of the other modules' pom.xml
files (e.g., tree) to see how it inherits from
infinispan-parent.</div>
</div>
</blockquote>
I'll do. One hopefully minor issue, though: expecting to have
this accepted as an official Spring Extension I used JUnit
instead of TestNG since the latter isn't used in Spring land.
Do I have to port those tests or is it OK to pull JUnit in?<br>
<br>
Cheers,<br>
Olaf<br>
<blockquote
cite="mid:179B11F1-9B21-4BC5-887E-C58E465ACDDA@jboss.org"
type="cite">
<div>
<div><br>
</div>
<div>Cheers</div>
<div>Manik</div>
<div><br>
</div>
<div>--</div>
</div>
<div>
<div>
<div>Manik Surtani</div>
<div><a moz-do-not-send="true"
href="mailto:manik@jboss.org">manik@jboss.org</a></div>
<div><a moz-do-not-send="true"
href="http://twitter.com/maniksurtani">twitter.com/maniksurtani</a></div>
<div><br>
</div>
<div>Lead, Infinispan</div>
<div><a moz-do-not-send="true"
href="http://www.infinispan.org">http://www.infinispan.org</a></div>
<div><br>
</div>
</div>
<br class="Apple-interchange-newline">
</div>
<br>
<pre wrap=""><fieldset class="mimeAttachmentHeader"></fieldset>
_______________________________________________
infinispan-dev mailing list
<a moz-do-not-send="true" href="mailto:infinispan-dev@lists.jboss.org">infinispan-dev@lists.jboss.org</a>
<a moz-do-not-send="true" href="https://lists.jboss.org/mailman/listinfo/infinispan-dev">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a></pre>
</blockquote>
<br>
</div>
</blockquote>
<blockquote type="cite">
<div><span>_______________________________________________</span><br>
<span>infinispan-dev mailing list</span><br>
<span><a moz-do-not-send="true"
href="mailto:infinispan-dev@lists.jboss.org">infinispan-dev@lists.jboss.org</a></span><br>
<span><a moz-do-not-send="true"
href="https://lists.jboss.org/mailman/listinfo/infinispan-dev">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a></span></div>
</blockquote>
<pre wrap="">
<fieldset class="mimeAttachmentHeader"></fieldset>
_______________________________________________
infinispan-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:infinispan-dev@lists.jboss.org">infinispan-dev@lists.jboss.org</a>
<a class="moz-txt-link-freetext" href="https://lists.jboss.org/mailman/listinfo/infinispan-dev">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a></pre>
</blockquote>
<br>
</body>
</html>