<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On 9 Jun 2011, at 09:23, Galder Zamarreņo wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><span class="Apple-style-span" style="border-collapse: separate; font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; "><br>We don't check for ranges either anywhere else.<span class="Apple-converted-space"> </span><br><br>We could also use markers to limit the duplicate checks. IOW, use a marker to define internal commands (0) and another for externally defined user commands (1). So, then the duplicates would be check in each scope. The scope of finding duplicates in internal commands is there. So, we'd only need to check duplicates within user defined commands.</span></blockquote><br></div><div>Either way, this is hardly an expensive process, and only happens once at startup.</div><div><br></div><div>Hmm, a check is in place, to check for some custom modules against other custom modules, but this check does not test against core command ids. :-)</div><div><br></div><div><a href="https://github.com/infinispan/infinispan/blob/master/core/src/main/java/org/infinispan/util/ModuleProperties.java#L221">https://github.com/infinispan/infinispan/blob/master/core/src/main/java/org/infinispan/util/ModuleProperties.java#L221</a></div><div><br></div><div>So the JIRA really should be to enhance this check.</div><div><br></div><div>- Manik</div><div>
<div><div>--</div><div>Manik Surtani</div><div><a href="mailto:manik@jboss.org">manik@jboss.org</a></div><div><a href="http://twitter.com/maniksurtani">twitter.com/maniksurtani</a></div><div><br></div><div>Lead, Infinispan</div><div><a href="http://www.infinispan.org">http://www.infinispan.org</a></div><div><br></div></div><br class="Apple-interchange-newline">
</div>
<br></body></html>