<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">This is a very tricky one indeed. These might fail as well e.g. if we increase the number of concurrent threads running the test suite. I remember when switching from 1 thread to 10 there were many of these failing.<div>I think your suggestion makes sense.<br><div><br></div><div><div><div><div><div>On 10 Jun 2011, at 13:02, Manik Surtani wrote:</div><blockquote type="cite"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Some tests - like ExpiryTest - rely on certain timings for the test to run, and due to thread scheduling on our parallel test suite, tend to occasionally fail on certain environments such as CloudBees:<div><br></div><div><a href="https://infinispan.ci.cloudbees.com/job/Infinispan-master-JDK6-tcp/org.infinispan$infinispan-core/67/testReport/org.infinispan.expiry/ExpiryTest/org_infinispan_expiry_ExpiryTest_testLifespanExpiryInPutAll/">https://infinispan.ci.cloudbees.com/job/Infinispan-master-JDK6-tcp/org.infinispan$infinispan-core/67/testReport/org.infinispan.expiry/ExpiryTest/org_infinispan_expiry_ExpiryTest_testLifespanExpiryInPutAll/</a></div><div><br></div><div><a href="https://infinispan.ci.cloudbees.com/job/Infinispan-master-JDK6-tcp/org.infinispan$infinispan-core/67/testReport/org.infinispan.expiry/ExpiryTest/org_infinispan_expiry_ExpiryTest_testLifespanExpiryInPutAll/"></a>In this example, entries are placed in the data container with a 30 second lifespan, tested for existence, wait 30s, and test for non-existence. The failure here is that the first test for existence fails since the thread is de-scheduled for a period of time between storing the entry and the first test.</div><div><br></div><div>Upping the lifespan just moves the problem - and makes the test suite run slower (got to wait for that lifespan before testing again).</div><div><br></div><div>How about we group such tests into a new group, "timeSensitiveTests", and *don't* run these on CI environments (but *do* run them on local environments where response times are more reasonable/predictable)?</div><div><br></div><div>Thoughts?</div><div><br></div><div>Cheers</div><div>Manik<br><div>
<div><div>--</div><div>Manik Surtani</div><div><a href="mailto:manik@jboss.org">manik@jboss.org</a></div><div><a href="http://twitter.com/maniksurtani">twitter.com/maniksurtani</a></div><div><br></div><div>Lead, Infinispan</div><div><a href="http://www.infinispan.org/">http://www.infinispan.org</a></div><div><br></div></div><br class="Apple-interchange-newline">
</div>
<br></div></div>_______________________________________________<br>infinispan-dev mailing list<br><a href="mailto:infinispan-dev@lists.jboss.org">infinispan-dev@lists.jboss.org</a><br>https://lists.jboss.org/mailman/listinfo/infinispan-dev</blockquote></div><br></div></div></div></div></body></html>