<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On 17 Oct 2011, at 09:13, Dan Berindei wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div>On Fri, Oct 14, 2011 at 9:29 PM, Vladimir Blagojevic<br><<a href="mailto:vblagoje@redhat.com">vblagoje@redhat.com</a>> wrote:<br><blockquote type="cite">After Mircea's thorough review and advice from him and Sanne we are<br></blockquote><blockquote type="cite">almost ready to integrate FineGrainedAtomicMap. I say almost because<br></blockquote><blockquote type="cite">Sanne, Mircea and I concluded that two questions remain unanswered.<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">1) Should we stick fine-grained functionality under current AtomicMap<br></blockquote><blockquote type="cite">and discard legacy AtomicMap? FineGrainedAtomicMap seems to offer a<br></blockquote><blockquote type="cite">super-set of AtomicMap features and we should not confuse users with yet<br></blockquote><blockquote type="cite">another AtomicMap; at the same time we have less headache maintaining<br></blockquote><blockquote type="cite">AtomicMap codebase.<br></blockquote><blockquote type="cite"><br></blockquote><br>How's the performance of the fine grained AtomicMap compared to the old one?<br>If the performance is identical then I see no reason to keep the old<br>one around, otherwise we already have problems keeping up with the<br>performance of JBossCache 1.4 (see<br><a href="http://community.jboss.org/message/630238">http://community.jboss.org/message/630238</a>) so I would keep the old one<br>around.<br></div></blockquote><div><br></div><div>+1. A simple test that does puts would tell us that straight away.</div><div>If we choose to allow both fine grained(FGAM) and non-faine grained maps(AM), then we also need to be concerned with the following transactional aspect: what happens if tx1 access key "k" using a FGAM and tx access same "k" using an AM. Perhaps not allow that kind of mixed access for now?</div><blockquote type="cite"><div><font class="Apple-style-span" color="#000000"><br></font><blockquote type="cite">2) This one is a bit technical. What should we do if tx1 deletes entire<br></blockquote><blockquote type="cite">AtomicMap while tx2 updates entries in the same Map. Should we create a<br></blockquote><blockquote type="cite">new Map and apply deltas to a new fresh map *or* simply discard delta<br></blockquote><blockquote type="cite">changes because entire Map has been deleted?<br></blockquote><blockquote type="cite"><br></blockquote><br>I would say not simply discard the changes, but throw an exception and<br>roll back tx2 as well.<br></div></blockquote>That would work. Also if a FGAM method is called and that FGAM has been deleted/replaced then the FGAM method should throw an exception. <br><blockquote type="cite"><div><br>Cheers<br>Dan<br>_______________________________________________<br>infinispan-dev mailing list<br><a href="mailto:infinispan-dev@lists.jboss.org">infinispan-dev@lists.jboss.org</a><br>https://lists.jboss.org/mailman/listinfo/infinispan-dev<br></div></blockquote></div><br></body></html>