<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">We're actually in the process of setting up BuildHive. Galder's on it. :)<div><br><div><div>On 28 May 2012, at 17:20, Adrian Cole wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><p>FWIW, might be a good idea trying buildhive a bit, then deciding. It is working pretty well for jenkins-ci projects, and so much easier than fetch, cherry-pick, test push loop. </p><p>In jclouds, we are setting this up as community members are starting to be more brave (ex refactor things that other PRs can trip), and I've needed to put $1 into the jar a few times merging ;)</p><p>Seems a pragmatic 'wait and see' to try BuildHive a while, but of course, you know better than me about what's the right choice here.</p><p>If you are having any struggle setting up that, let me or Andrew Phillips know, as we had a change into BuilHive recently to deal with our massive build :)</p><p>Have fun!<br>
-A</p>
<div class="gmail_quote">On May 28, 2012 1:41 AM, "Manik Surtani" <<a href="mailto:manik@jboss.org">manik@jboss.org</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I don't think everyone has to handle tens of PRs a day. It's more like one per person per day, which IMO isn't unreasonable as long as everyone does their fair share.<br>
<br>
On 27 May 2012, at 14:51, Bela Ban wrote:<br>
<br>
> +1000. I completely agree that if someone has to handle tens of pull<br>
> requests per day, he will *not* seriously look into the request, test it<br>
> etc. So IMO this is a farce, and we might as well go back to trusting<br>
> people, rather than wasting their time...<br>
><br>
><br>
><br>
> On 5/25/12 1:47 PM, Sanne Grinovero wrote:<br>
>> guys, please don't take me as the one who is again complaining about<br>
>> failing tests; I'm having doubts about the development process and the<br>
>> amount of time this is wasting on all of us.<br>
>><br>
>> We're all humans and do mistakes, still it happens so extremely often<br>
>> that this is getting systemic, and discipline could definitely be<br>
>> improved: people regularly send pull requests with failing tests or<br>
>> broken code, and very regularly this is just merged in master.<br>
>><br>
>> I did it myself a couple of days ago: didn't notice a failure, all<br>
>> looked good, sent a pull, it was merged with no complaints. Three days<br>
>> later, I resume my work and am appalled to see that it was broken. Now<br>
>> fixing it, but I'll have to send another pull and wait for it - which<br>
>> feels very pointless, as I'm pretty sure nobody is checking anyway.<br>
>><br>
>> It looks like as the pull request procedure is having this effect:<br>
>><br>
>> # patch writer is not as carefull as he used to be: "someone else<br>
>> will check if it's fine or not. I have no time to run the tests<br>
>> again..".<br>
>><br>
>> # reviewer has as quick look. "Looks good - in fact I don't care<br>
>> much, it's not my code and need to return to my own issues.. worst<br>
>> case someone else will fix it blaming the original author"<br>
>><br>
>> And then again some incomplete test makes it to master, or a patch<br>
>> which doesn't even compile is integrated.<br>
>><br>
>> This pull request process is being a big failure. Shall we stop<br>
>> wasting time on it and just push on master?<br>
>><br>
>> Which doesn't mean I'm suggesting "let's make it worse" | "unleash<br>
>> hell": we should all take responsibility on any change very seriously.<br>
>><br>
>> Again, I'm not enjoying the role of "whom who complains on the<br>
>> testsuite again". Just stating a fact, and trying to propose something<br>
>> to make it work better. We have great individuals on this team, but we<br>
>> need to admit that team work isn't working and we should deal with it<br>
>> at it's best; denying it won't help.<br>
>><br>
>> Cheers,<br>
>> Sanne<br>
><br>
><br>
> --<br>
> Bela Ban, JGroups lead (<a href="http://www.jgroups.org/" target="_blank">http://www.jgroups.org</a>)<br>
> _______________________________________________<br>
> infinispan-dev mailing list<br>
> <a href="mailto:infinispan-dev@lists.jboss.org">infinispan-dev@lists.jboss.org</a><br>
> <a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a><br>
<br>
--<br>
Manik Surtani<br>
<a href="mailto:manik@jboss.org">manik@jboss.org</a><br>
<a href="http://twitter.com/maniksurtani" target="_blank">twitter.com/maniksurtani</a><br>
<br>
Lead, Infinispan<br>
<a href="http://www.infinispan.org/" target="_blank">http://www.infinispan.org</a><br>
<br>
<br>
<br>
<br>
_______________________________________________<br>
infinispan-dev mailing list<br>
<a href="mailto:infinispan-dev@lists.jboss.org">infinispan-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a><br>
</blockquote></div>
_______________________________________________<br>infinispan-dev mailing list<br><a href="mailto:infinispan-dev@lists.jboss.org">infinispan-dev@lists.jboss.org</a><br>https://lists.jboss.org/mailman/listinfo/infinispan-dev</blockquote></div><br><div apple-content-edited="true">
<span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; "><div><div>--</div><div>Manik Surtani</div><div><a href="mailto:manik@jboss.org">manik@jboss.org</a></div><div><a href="http://twitter.com/maniksurtani">twitter.com/maniksurtani</a></div><div><br></div><div>Lead, Infinispan</div><div><a href="http://www.infinispan.org">http://www.infinispan.org</a></div><div><br></div></div></span><br class="Apple-interchange-newline">
</div>
<br></div></body></html>