<div class="gmail_quote">On Mon, Jun 25, 2012 at 10:48 PM, Sanne Grinovero <span dir="ltr"><<a href="mailto:sanne@infinispan.org" target="_blank">sanne@infinispan.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div><div>On 25 June 2012 20:06, Dan Berindei <<a href="mailto:dan.berindei@gmail.com" target="_blank">dan.berindei@gmail.com</a>> wrote:<br>
> On Mon, Jun 25, 2012 at 5:58 PM, Sanne Grinovero <<a href="mailto:sanne@infinispan.org" target="_blank">sanne@infinispan.org</a>><br>
> wrote:<br>
>><br>
>> Hi all,<br>
>> the testsuite on master is regularly hanging for me, and I get all<br>
>> threads waiting while this one is spinning on the put() operation.<br>
>><br>
>> java.lang.Thread.State: RUNNABLE<br>
>> at java.util.HashMap.put(HashMap.java:374)<br>
>> at org.testng.SuiteRunner.runTest(SuiteRunner.java:320)<br>
>> at org.testng.SuiteRunner.access$000(SuiteRunner.java:34)<br>
>> at org.testng.SuiteRunner$SuiteWorker.run(SuiteRunner.java:351)<br>
>> at<br>
>> org.testng.internal.thread.ThreadUtil$CountDownLatchedRunnable.run(ThreadUtil.java:147)<br>
>> at<br>
>> java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)<br>
>> at<br>
>> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)<br>
>> at java.lang.Thread.run(Thread.java:662)<br>
>><br>
>><br>
>> Clearly the parallel testsuite is not synchronizing properly on the<br>
>> HashMap, this looks like a TestNG bug.<br>
>><br>
>> So I've tried to update to latest 6.5.2; from the Changelog this looks<br>
>> like fixed, as is a very long list of other issues; not least<br>
>><br>
>> "Fixed: Skipped tests were not always counted"<br>
>><br>
>> which might address the strange numbers we had noticed on Jenkins.<br>
>><br>
><br>
> Excellent!<br>
><br>
><br>
>><br>
>> But I'm still unable to run the full testsuite; what follows are the<br>
>> reasons from several different attempts:<br>
>><br>
>><br>
>> testng-SyncBasicSingleLockOptimisticTest) Exiting because<br>
>> lock.singlelock.SyncBasicSingleLockOptimisticTest has NOT shut down<br>
>> all the cache managers it has started !!!!!!!<br>
>><br>
>> testng-SyncBasicSingleLockOptimisticTest) Exiting because<br>
>> lock.singlelock.SyncBasicSingleLockOptimisticTest has NOT shut down<br>
>> all the cache managers it has started !!!!!<br>
>><br>
>> (testng-BasicSingleLockOptimisticTest) Exiting because<br>
>> lock.singlelock.BasicSingleLockOptimisticTest has NOT shut down all<br>
>> the cache managers it has started !!!!!!!<br>
>><br>
>> (testng-BasicSingleLockOptimisticTest) Exiting because<br>
>> lock.singlelock.BasicSingleLockOptimisticTest has NOT shut down all<br>
>> the cache managers it has started !!!!!!!<br>
>><br>
>> (testng-SyncBasicSingleLockOptimisticTest) Exiting because<br>
>> lock.singlelock.SyncBasicSingleLockOptimisticTest has NOT shut down<br>
>> all the cache managers it has started !!!!!!!<br>
>><br>
>><br>
>> Looking into the BasicSingleLockOptimisticTest I'm not seeing how this<br>
>> could be possible, so I'm wondering if this could be a problem related<br>
>> to the TestNG update? Any thoughts?<br>
>><br>
><br>
> Galder and I saw the same thing with another test in Jenkins:<br>
> <a href="https://issues.jboss.org/browse/ISPN-2117?focusedCommentId=12702926&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-12702926" target="_blank">https://issues.jboss.org/browse/ISPN-2117?focusedCommentId=12702926&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-12702926</a><br>
><br>
> To reiterate here, there was/is another concurrency issue in the<br>
> maven-surefire-plugin that caused it to sometimes skip @AfterMethod methods<br>
> after a failure. Galder upgraded the plugin to 2.12 hoping it would fix the<br>
> problem, but if you're still seeing I guess that wasn't enough...<br>
<br>
</div></div>Thanks Dan! Strange that this happens to me consistently on the same<br>
test.. do you know what is supposed to trigger this @AfterMethod<br>
failure? Is there a reference to the Surefire issue?<br>
<br></blockquote></div><br>I'm not sure why you can reproduce it so reliably, but it's probably related to the fact that this test always fails for you (and it doesn't fail for us).<br><br>I didn't find any related issue in the surefire JIRA, if you can still reproduce it with maven-surefire-report-plugin 2.12 I'd say create a new issue yourself and paste the ConcurrentModificationException stack trace from your logs (or give it to me and I'll create the issue).<br>
<br>I had a quick look at the 2.12 source code and it seems like the problem is still there: TestSetRunListener.writeTestOutput can still modify the list of lines in testStdOut after a failure (because our caches keep on running and logging stuff), and in parallel TestSetRunListener.testFailed will call TestSetRunListener.getAsString, which will iterate over testStdOut. Since there is no synchronization in either writeTestOutput or in getAsString, it's possible to get a ConcurrentModificationException there.<br>
<br><br>Cheers<br>Dan<br><br>