<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">Fair point. <br>
Done!<br>
<br>
On 06/27/2012 03:39 PM, Dan Berindei wrote:<br>
</div>
<blockquote
cite="mid:CA+nfvwRNNjSkz0wbzPmi5nJdJXeN=6qknDLDL_ObV3WqmTWJGw@mail.gmail.com"
type="cite">
<div class="gmail_quote">On Wed, Jun 27, 2012 at 3:36 PM, Adrian
Nistor <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:anistor@redhat.com" target="_blank">anistor@redhat.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
Yup.<br>
<br>
No iteration on elements here. Copying is done atomically
because it is<br>
based on ArrayList's constructor which uses
Collection.toArray() which<br>
is also atomic in this case because the passed in List happens
to be<br>
wrapped by Collections.synchronizedList() in all usages. I
tested this<br>
and it fixes the issue.<br>
<div class="HOEnZb">
<div class="h5"><br>
</div>
</div>
</blockquote>
<div><br>
You should also add a comment with this info to the pull req,
otherwise the maintainers of surefire might reject it :)<br>
<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div class="HOEnZb">
<div class="h5">
On 06/27/2012 03:13 PM, Sanne Grinovero wrote:<br>
> Are you sure that resolved the problem?<br>
><br>
> When you wrap a list into a new ArrayList, it might
still need to<br>
> iterate on it's elements, depending on which
implementation of List is<br>
> being used.<br>
><br>
> So that might indeed fix it but depends on the List
implementation :-(<br>
><br>
> On 27 June 2012 13:03, Sanne Grinovero <<a
moz-do-not-send="true"
href="mailto:sanne@infinispan.org">sanne@infinispan.org</a>>
wrote:<br>
>> On 27 June 2012 12:51, Adrian Nistor <<a
moz-do-not-send="true" href="mailto:anistor@redhat.com">anistor@redhat.com</a>>
wrote:<br>
>>> I've just submitted the surefire
ConcurrentModificationException issue<br>
>>> (<a moz-do-not-send="true"
href="http://jira.codehaus.org/browse/SUREFIRE-879"
target="_blank">http://jira.codehaus.org/browse/SUREFIRE-879</a>)
and also created a pull<br>
>>> request for the (trivial) fix. Let's hope
they will be quick to handle<br>
>>> it. This has the potential of eliminating
many of our random test failures.<br>
>> Awesome!<br>
> _______________________________________________<br>
> infinispan-dev mailing list<br>
> <a moz-do-not-send="true"
href="mailto:infinispan-dev@lists.jboss.org">infinispan-dev@lists.jboss.org</a><br>
> <a moz-do-not-send="true"
href="https://lists.jboss.org/mailman/listinfo/infinispan-dev"
target="_blank">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a><br>
<br>
<br>
_______________________________________________<br>
infinispan-dev mailing list<br>
<a moz-do-not-send="true"
href="mailto:infinispan-dev@lists.jboss.org">infinispan-dev@lists.jboss.org</a><br>
<a moz-do-not-send="true"
href="https://lists.jboss.org/mailman/listinfo/infinispan-dev"
target="_blank">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a><br>
</div>
</div>
</blockquote>
</div>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
infinispan-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:infinispan-dev@lists.jboss.org">infinispan-dev@lists.jboss.org</a>
<a class="moz-txt-link-freetext" href="https://lists.jboss.org/mailman/listinfo/infinispan-dev">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a></pre>
</blockquote>
<br>
<br>
</body>
</html>