Guys, what does this mean for the transition of the test suite to the new (5.1+) configuration API? Will it also have to wait until 6.0?<br>I did a search today and there are still about 10 callers in production
code for the deprecated Cache.getConfiguration() method... I didn't have time to count the callers in test code :)<br>
<br>Dan<br><br><br><div class="gmail_quote">On Tue, Aug 14, 2012 at 2:48 PM, Manik Surtani <span dir="ltr"><<a href="mailto:manik@jboss.org" target="_blank">manik@jboss.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="word-wrap:break-word">I agree with Galder. These will change in 6.0 anyway.<div><div><div class="h5"><br><div><div>On 14 Aug 2012, at 10:02, Galder Zamarreņo <<a href="mailto:galder@redhat.com" target="_blank">galder@redhat.com</a>> wrote:</div>
<br><blockquote type="cite">Hmmm, I'm not sure this is the right time to actually change the API, that'd be IMO when we redesign the cache loaders.<br><br>Instead, I'd add a new interface with the new method and extend the current CacheLoader. It's a bit messy but should only be temporary until we have an agreement on the cache loader interface.<br>
<br>IOW, I'd rather change once, in a major release, than change now and then change again in 6.0.<br><br>Thoughts?<br><br>On Aug 9, 2012, at 8:54 AM, Tristan Tarrant wrote:<br><br><blockquote type="cite">Yes, I'm introducing interfaces: the whole org.infinispan.configuration <br>
is quite lacking in that respect ;)<br><br>Tristan<br><br>On 08/08/2012 07:27 PM, Sanne Grinovero wrote:<br><blockquote type="cite">I'd suggest to keep an interface in the API signature, much better<br>than an abstract class.<br>
<br>+1 to change the API, more changes are expected soon anyway.<br><br>Sanne<br><br><br>On 8 August 2012 18:51, Tristan Tarrant <<a href="mailto:ttarrant@redhat.com" target="_blank">ttarrant@redhat.com</a>> wrote:<br>
<blockquote type="cite">Hi guys,<br><br>as part of ISPN-1978, I'm migrating the Cache Loaders to the new<br>configuration builder APIs. I want to change the init() method of the<br>CacheLoaders which has the following signature<br>
<br>public void init(CacheLoaderConfig config, Cache<?, ?> cache,<br>StreamingMarshaller m) throws CacheLoaderException<br><br>to the following:<br><br>public void init(AbstractLoaderConfiguration config, Cache<?, ?> cache,<br>
StreamingMarshaller m) throws CacheLoaderException<br><br>This will break all existing cache loaders/stores: I'll fix all the ones<br>bundled in the distribution, but do we need to provide compatibility<br>with third party loaders ?<br>
<br>Tristan<br><br>_______________________________________________<br>infinispan-dev mailing list<br><a href="mailto:infinispan-dev@lists.jboss.org" target="_blank">infinispan-dev@lists.jboss.org</a><br><a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a><br>
</blockquote>_______________________________________________<br>infinispan-dev mailing list<br><a href="mailto:infinispan-dev@lists.jboss.org" target="_blank">infinispan-dev@lists.jboss.org</a><br><a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a><br>
</blockquote><br>_______________________________________________<br>infinispan-dev mailing list<br><a href="mailto:infinispan-dev@lists.jboss.org" target="_blank">infinispan-dev@lists.jboss.org</a><br><a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a><br>
</blockquote><br>--<br>Galder Zamarreņo<br>Sr. Software Engineer<br>Infinispan, JBoss Cache<br><br><br>_______________________________________________<br>infinispan-dev mailing list<br><a href="mailto:infinispan-dev@lists.jboss.org" target="_blank">infinispan-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a><br></blockquote></div><br></div></div><div>
<span style="text-indent:0px;letter-spacing:normal;font-variant:normal;text-align:-webkit-auto;font-style:normal;font-weight:normal;line-height:normal;border-collapse:separate;text-transform:none;font-size:medium;white-space:normal;font-family:Helvetica;word-spacing:0px"><span style="text-indent:0px;letter-spacing:normal;font-variant:normal;text-align:-webkit-auto;font-style:normal;font-weight:normal;line-height:normal;border-collapse:separate;text-transform:none;font-size:medium;white-space:normal;font-family:Helvetica;word-spacing:0px"><div style="word-wrap:break-word">
<span style="text-indent:0px;letter-spacing:normal;font-variant:normal;font-style:normal;font-weight:normal;line-height:normal;border-collapse:separate;text-transform:none;font-size:medium;white-space:normal;font-family:Helvetica;word-spacing:0px"><div style="word-wrap:break-word">
<div>--</div><div>Manik Surtani</div><div><a href="mailto:manik@jboss.org" target="_blank">manik@jboss.org</a></div><div><a href="http://twitter.com/maniksurtani" target="_blank">twitter.com/maniksurtani</a></div><div><br>
</div><div><div>Founder and Project Lead, Infinispan</div><div><a href="http://www.infinispan.org" target="_blank">http://www.infinispan.org</a></div><div><br></div><div>Platform Architect, JBoss Data Grid</div><div><a href="http://red.ht/data-grid" target="_blank">http://red.ht/data-grid</a></div>
</div></div></span></div></span></span>
</div>
<br></div></div><br>_______________________________________________<br>
infinispan-dev mailing list<br>
<a href="mailto:infinispan-dev@lists.jboss.org">infinispan-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a><br></blockquote></div><br>