<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Awesome. I guess folks are working on fixing these?<div><br><div><div>On 11 Oct 2012, at 17:12, Sanne Grinovero <<a href="mailto:sanne@infinispan.org">sanne@infinispan.org</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">Yes thanks! the tests don't deadlock anymore, they just fail consistently:<br><br>Failed tests:<br>testForceCommitXid(org.infinispan.tx.recovery.admin.SimpleCacheRecoveryAdminTest):<br>expected:<false> but was:<true><br> timeBasedTakeOffline(org.infinispan.xsite.offline.OfflineStatusTest):<br>expected:<false> but was:<true><br> indexWasStored(org.infinispan.loaders.decorators.BatchAsyncCacheStoreTest):<br>expected:<false> but was:<true><br> testTwoNamedCachesSameNode(org.infinispan.tx.TransactionsSpanningDistributedCachesTest):<br>Timed out waiting for rebalancing to complete on node<br>TransactionsSpanningDistributedCachesTest-NodeS-50037, expected member<br>list is [TransactionsSpanningDistributedCachesTest-NodeS-50037,<br>TransactionsSpanningDistributedCachesTest-NodeT-374], current member<br>list is [TransactionsSpanningDistributedCachesTest-NodeS-50037]!<br><br>Tests run: 1640, Failures: 4, Errors: 0, Skipped: 0<br><br>Not perfect, but a nice progress.<br><br>Cheers,<br>Sanne<br><br><br>On 11 October 2012 12:47, Manik Surtani <<a href="mailto:manik@jboss.org">manik@jboss.org</a>> wrote:<br><blockquote type="cite">Sanne, does this fix the test suite for you? For whatever reason, this<br>issue appears on your machine more often than anyone else's … :)<br><br>On 3 Oct 2012, at 12:56, Dan Berindei <<a href="mailto:dan.berindei@gmail.com">dan.berindei@gmail.com</a>> wrote:<br><br>Thanks for the workaround, Bela!<br>I've included it in <a href="https://github.com/infinispan/infinispan/pull/1358">https://github.com/infinispan/infinispan/pull/1358</a>.<br><br><br>On Wed, Oct 3, 2012 at 9:32 AM, Bela Ban <<a href="mailto:bban@redhat.com">bban@redhat.com</a>> wrote:<br><blockquote type="cite"><br><br><br>On 10/2/12 6:02 PM, Dan Berindei wrote:<br><br><blockquote type="cite"><blockquote type="cite">The members should be updated in viewAccepted(). When you connect a<br>channel, then viewAccepted() will be called *before* JChannel.connect()<br>returns, so the main thread won't have a chance of accessing members<br>before that.<br><br><br></blockquote>Ok, if viewAccepted() is guaranteed to be called before connect()<br>returns<br>then you're right, the latch is superfluous. We only need to call<br>viewAccepted() ourselves if the channel was injected (which we already<br>do).<br><br>In this particular case, however, we don't get a viewAccepted() call or<br>an<br>exception from connect(), so I'm not sure it would have been better<br>(easier<br>to debug) without the latch.<br></blockquote><br><br>This is due to <a href="https://issues.jboss.org/browse/JGRP-1522">https://issues.jboss.org/browse/JGRP-1522</a>, which was<br>introduced in 3.2.0; when this is fixed, you will get a viewAccepted().<br>The workaround is to set NAKACK{2}.become_server_queue_size=0.<br><br>--<br>Bela Ban, JGroups lead (<a href="http://www.jgroups.org">http://www.jgroups.org</a>)<br>_______________________________________________<br>infinispan-dev mailing list<br><a href="mailto:infinispan-dev@lists.jboss.org">infinispan-dev@lists.jboss.org</a><br>https://lists.jboss.org/mailman/listinfo/infinispan-dev<br></blockquote><br><br>_______________________________________________<br>infinispan-dev mailing list<br><a href="mailto:infinispan-dev@lists.jboss.org">infinispan-dev@lists.jboss.org</a><br>https://lists.jboss.org/mailman/listinfo/infinispan-dev<br><br><br>--<br>Manik Surtani<br>manik@jboss.org<br>twitter.com/maniksurtani<br><br>Platform Architect, JBoss Data Grid<br>http://red.ht/data-grid<br><br><br>_______________________________________________<br>infinispan-dev mailing list<br>infinispan-dev@lists.jboss.org<br>https://lists.jboss.org/mailman/listinfo/infinispan-dev<br></blockquote><br>_______________________________________________<br>infinispan-dev mailing list<br><a href="mailto:infinispan-dev@lists.jboss.org">infinispan-dev@lists.jboss.org</a><br>https://lists.jboss.org/mailman/listinfo/infinispan-dev</blockquote></div><br><div apple-content-edited="true">
<span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; border-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; "><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; border-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; "><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; border-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; "><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div>--</div><div>Manik Surtani</div><div><a href="mailto:manik@jboss.org">manik@jboss.org</a></div><div><a href="http://twitter.com/maniksurtani">twitter.com/maniksurtani</a></div><div><br></div><div><div>Platform Architect, JBoss Data Grid</div><div><a href="http://red.ht/data-grid">http://red.ht/data-grid</a></div></div></div></span></div></span></div></span>
</div>
<br></div></body></html>