<html>
<head>
<meta http-equiv="content-type" content="text/html; charset=ISO-8859-1">
</head>
<body text="#000000" bgcolor="#FFFFFF">
Hi all,<br>
sorry for this being a bit late (but since it is before CR1 it is
not that late :), but the XSite config looks a bit redundant and we
should improve it a bit before release<br>
<br>
<div class="container" title="Hint: double-click to select code">
<div class="line number1 index0 alt2"><code class="xml plain"><</code><code
class="xml keyword">global</code><code class="xml plain">></code></div>
<div class="line number2 index1 alt1"><code class="xml spaces"> </code><code
class="xml plain">...</code></div>
<div class="line number3 index2 alt2"><code class="xml spaces"> </code><code
class="xml plain"><</code><code class="xml keyword">sites</code>
<code class="xml color1">local</code><code class="xml plain">=</code><code
class="xml string">"LON"</code><code class="xml plain">/></code></div>
<div class="line number4 index3 alt1"><code class="xml spaces"> </code><code
class="xml plain">...</code></div>
<div class="line number5 index4 alt2"><code class="xml plain"></</code><code
class="xml keyword">global</code><code class="xml plain">></code></div>
</div>
<br>
Since this just provides the local logical name for this site I
would instead use<br>
<br>
<div class="container" title="Hint: double-click to select code">
<div class="line number1 index0 alt2"><code class="xml plain"><</code><code
class="xml keyword">global</code><code class="xml plain">></code></div>
<div class="line number2 index1 alt1"><code class="xml spaces"> </code><code
class="xml plain">...</code></div>
<div class="line number3 index2 alt2"><code class="xml spaces"> </code><code
class="xml plain"><</code><code class="xml keyword">site</code>
<code>name</code><code class="xml color1"></code><code
class="xml plain">=</code><code class="xml string">"LON"</code><code
class="xml plain">/></code></div>
<div class="line number4 index3 alt1"><code class="xml spaces"> </code><code
class="xml plain">...</code></div>
<div class="line number5 index4 alt2"><code class="xml plain"></</code><code
class="xml keyword">global</code><code class="xml plain">></code></div>
</div>
<br>
In the cache declaration we have the following:<br>
<br>
<code class="xml plain"> <</code><code class="xml keyword">sites</code><code
class="xml plain">></code>
<div class="line number3 index2 alt2"><code class="xml spaces"> </code><code
class="xml plain"><</code><code class="xml keyword">backups</code>
<code class="xml color1">backupSites</code><code class="xml plain">=</code><code
class="xml string">"NYC,SFO"</code><code class="xml plain">></code></div>
<div class="line number4 index3 alt1"><code class="xml spaces"> </code><code
class="xml plain"><</code><code class="xml keyword">backup</code>
<code class="xml color1">site</code><code class="xml plain">=</code><code
class="xml string">"NYC"</code> <code class="xml color1">backupFailurePolicy</code><code
class="xml plain">=</code><code class="xml string">"WARN"</code>
<code class="xml color1">strategy</code><code class="xml plain">=</code><code
class="xml string">"SYNC"</code> <code class="xml color1">timeout</code><code
class="xml plain">=</code><code class="xml string">"12000"</code><code
class="xml plain">/></code></div>
<div class="line number5 index4 alt2"><code class="xml spaces"> </code><code
class="xml plain"><</code><code class="xml keyword">backup</code>
<code class="xml color1">site</code><code class="xml plain">=</code><code
class="xml string">"SFO"</code> <code class="xml color1">backupFailurePolicy</code><code
class="xml plain">=</code><code class="xml string">"IGNORE"</code>
<code class="xml color1">strategy</code><code class="xml plain">=</code><code
class="xml string">"ASYNC"</code><code class="xml plain">/></code></div>
<div class="line number6 index5 alt1"><code class="xml spaces"> </code><code
class="xml plain"><</code><code class="xml keyword">backup</code>
<code class="xml color1">site</code><code class="xml plain">=</code><code
class="xml string">"LON"</code> <code class="xml color1">strategy</code><code
class="xml plain">=</code><code class="xml string">"SYNC"</code><code
class="xml plain">/></code></div>
<div class="line number7 index6 alt2"><code class="xml spaces"> </code><code
class="xml plain"></</code><code class="xml keyword">backups</code><code
class="xml plain">></code></div>
<div class="line number8 index7 alt1"><code class="xml spaces"> </code><code
class="xml plain"></</code><code class="xml keyword">sites</code><code
class="xml plain">></code></div>
<br>
Instead of dumping a list inside an XML attribute (backupSites),
can't we just skip that attribute and add an enabled attribute to
each backup element ? Also the "backup" prefix to the failure policy
is redundant and can be dropped altogether.<br>
Also, while I understand the rationale behind giving a "home
element" to all xsite-related configurations (<sites>), I do
feel it is unnecessary, so I suggest:<br>
<br>
<code class="xml spaces"> </code><code class="xml plain"><</code><code
class="xml keyword">backups</code><code class="xml string"></code><code
class="xml plain">></code>
<div class="line number4 index3 alt1"><code class="xml spaces"> </code><code
class="xml plain"><</code><code class="xml keyword">backup</code>
<code class="xml color1">site</code><code class="xml plain">=</code><code
class="xml string">"NYC"</code> <code class="xml color1">failurePolicy</code><code
class="xml plain">=</code><code class="xml string">"WARN"</code>
<code class="xml color1">strategy</code><code class="xml plain">=</code><code
class="xml string">"SYNC"</code> <code class="xml color1">timeout</code><code
class="xml plain">=</code><code class="xml string">"12000"</code><code
class="xml plain"> enabled="true"/></code></div>
<div class="line number5 index4 alt2"><code class="xml spaces"> </code><code
class="xml plain"><</code><code class="xml keyword">backup</code>
<code class="xml color1">site</code><code class="xml plain">=</code><code
class="xml string">"SFO"</code> <code class="xml color1">failurePolicy</code><code
class="xml plain">=</code><code class="xml string">"IGNORE"</code>
<code class="xml color1">strategy</code><code class="xml plain">=</code><code
class="xml string">"ASYNC"</code><code class="xml plain">
enabled="true"/></code></div>
<div class="line number6 index5 alt1"><code class="xml spaces"> </code><code
class="xml plain"><</code><code class="xml keyword">backup</code>
<code class="xml color1">site</code><code class="xml plain">=</code><code
class="xml string">"LON"</code> <code class="xml color1">strategy</code><code
class="xml plain">=</code><code class="xml string">"SYNC"</code><code
class="xml plain"> enabled="false"/></code></div>
<div class="line number7 index6 alt2"><code class="xml spaces"> </code><code
class="xml plain"></</code><code class="xml keyword">backups</code><code
class="xml plain">></code></div>
<br>
This means that <backupFor/> also moves as a direct child
element of a cache declaration.<br>
<br>
Just my 2¢<br>
<br>
Tristan<br>
<br>
<br>
<br>
</body>
</html>