<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On 18 Oct 2012, at 06:11, Tristan Tarrant wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">
<meta http-equiv="content-type" content="text/html; charset=ISO-8859-1">
<div text="#000000" bgcolor="#FFFFFF">
Hi all,<br>
sorry for this being a bit late (but since it is before CR1 it is
not that late :), but the XSite config looks a bit redundant and we
should improve it a bit before release<br>
<br>
<div class="container" title="Hint: double-click to select code">
<div class="line number1 index0 alt2"><code class="xml plain"><</code><code class="xml keyword">global</code><code class="xml plain">></code></div>
<div class="line number2 index1 alt1"><code class="xml spaces"> </code><code class="xml plain">...</code></div>
<div class="line number3 index2 alt2"><code class="xml spaces"> </code><code class="xml plain"><</code><code class="xml keyword">sites</code>
<code class="xml color1">local</code><code class="xml plain">=</code><code class="xml string">"LON"</code><code class="xml plain">/></code></div>
<div class="line number4 index3 alt1"><code class="xml spaces"> </code><code class="xml plain">...</code></div>
<div class="line number5 index4 alt2"><code class="xml plain"></</code><code class="xml keyword">global</code><code class="xml plain">></code></div>
</div>
<br>
Since this just provides the local logical name for this site I
would instead use<br>
<br>
<div class="container" title="Hint: double-click to select code">
<div class="line number1 index0 alt2"><code class="xml plain"><</code><code class="xml keyword">global</code><code class="xml plain">></code></div>
<div class="line number2 index1 alt1"><code class="xml spaces"> </code><code class="xml plain">...</code></div>
<div class="line number3 index2 alt2"><code class="xml spaces"> </code><code class="xml plain"><</code><code class="xml keyword">site</code>
<code>name</code><code class="xml color1"></code><code class="xml plain">=</code><code class="xml string">"LON"</code><code class="xml plain">/></code></div>
<div class="line number4 index3 alt1"><code class="xml spaces"> </code><code class="xml plain">...</code></div>
<div class="line number5 index4 alt2"><code class="xml plain"></</code><code class="xml keyword">global</code><code class="xml plain">></code></div></div></div></blockquote>+1, looks better.<br><blockquote type="cite"><div text="#000000" bgcolor="#FFFFFF"><div class="container" title="Hint: double-click to select code">
</div>
<br>
In the cache declaration we have the following:<br>
<br>
<code class="xml plain"> <</code><code class="xml keyword">sites</code><code class="xml plain">></code>
<div class="line number3 index2 alt2"><code class="xml spaces"> </code><code class="xml plain"><</code><code class="xml keyword">backups</code>
<code class="xml color1">backupSites</code><code class="xml plain">=</code><code class="xml string">"NYC,SFO"</code><code class="xml plain">></code></div>
<div class="line number4 index3 alt1"><code class="xml spaces"> </code><code class="xml plain"><</code><code class="xml keyword">backup</code>
<code class="xml color1">site</code><code class="xml plain">=</code><code class="xml string">"NYC"</code> <code class="xml color1">backupFailurePolicy</code><code class="xml plain">=</code><code class="xml string">"WARN"</code>
<code class="xml color1">strategy</code><code class="xml plain">=</code><code class="xml string">"SYNC"</code> <code class="xml color1">timeout</code><code class="xml plain">=</code><code class="xml string">"12000"</code><code class="xml plain">/></code></div>
<div class="line number5 index4 alt2"><code class="xml spaces"> </code><code class="xml plain"><</code><code class="xml keyword">backup</code>
<code class="xml color1">site</code><code class="xml plain">=</code><code class="xml string">"SFO"</code> <code class="xml color1">backupFailurePolicy</code><code class="xml plain">=</code><code class="xml string">"IGNORE"</code>
<code class="xml color1">strategy</code><code class="xml plain">=</code><code class="xml string">"ASYNC"</code><code class="xml plain">/></code></div>
<div class="line number6 index5 alt1"><code class="xml spaces"> </code><code class="xml plain"><</code><code class="xml keyword">backup</code>
<code class="xml color1">site</code><code class="xml plain">=</code><code class="xml string">"LON"</code> <code class="xml color1">strategy</code><code class="xml plain">=</code><code class="xml string">"SYNC"</code><code class="xml plain">/></code></div>
<div class="line number7 index6 alt2"><code class="xml spaces"> </code><code class="xml plain"></</code><code class="xml keyword">backups</code><code class="xml plain">></code></div>
<div class="line number8 index7 alt1"><code class="xml spaces"> </code><code class="xml plain"></</code><code class="xml keyword">sites</code><code class="xml plain">></code></div>
<br>
Instead of dumping a list inside an XML attribute (backupSites),
can't we just skip that attribute and add an enabled attribute to
each backup element ? Also the "backup" prefix to the failure policy
is redundant and can be dropped altogether.<br></div></blockquote>I like that more than the list approach, +1.<br><blockquote type="cite"><div text="#000000" bgcolor="#FFFFFF">
Also, while I understand the rationale behind giving a "home
element" to all xsite-related configurations (<sites>), I do
feel it is unnecessary, so I suggest:<br>
<br>
<code class="xml spaces"> </code><code class="xml plain"><</code><code class="xml keyword">backups</code><code class="xml string"></code><code class="xml plain">></code>
<div class="line number4 index3 alt1"><code class="xml spaces"> </code><code class="xml plain"><</code><code class="xml keyword">backup</code>
<code class="xml color1">site</code><code class="xml plain">=</code><code class="xml string">"NYC"</code> <code class="xml color1">failurePolicy</code><code class="xml plain">=</code><code class="xml string">"WARN"</code>
<code class="xml color1">strategy</code><code class="xml plain">=</code><code class="xml string">"SYNC"</code> <code class="xml color1">timeout</code><code class="xml plain">=</code><code class="xml string">"12000"</code><code class="xml plain"> enabled="true"/></code></div>
<div class="line number5 index4 alt2"><code class="xml spaces"> </code><code class="xml plain"><</code><code class="xml keyword">backup</code>
<code class="xml color1">site</code><code class="xml plain">=</code><code class="xml string">"SFO"</code> <code class="xml color1">failurePolicy</code><code class="xml plain">=</code><code class="xml string">"IGNORE"</code>
<code class="xml color1">strategy</code><code class="xml plain">=</code><code class="xml string">"ASYNC"</code><code class="xml plain">
enabled="true"/></code></div>
<div class="line number6 index5 alt1"><code class="xml spaces"> </code><code class="xml plain"><</code><code class="xml keyword">backup</code>
<code class="xml color1">site</code><code class="xml plain">=</code><code class="xml string">"LON"</code> <code class="xml color1">strategy</code><code class="xml plain">=</code><code class="xml string">"SYNC"</code><code class="xml plain"> enabled="false"/></code></div>
<div class="line number7 index6 alt2"><code class="xml spaces"> </code><code class="xml plain"></</code><code class="xml keyword">backups</code><code class="xml plain">></code></div>
<br>
This means that <backupFor/> also moves as a direct child
element of a cache declaration.<br></div></blockquote>Not sure sure about this one, I think having all the xsite related configuration grouped under one element kind of makes sense. I don't have strong feelings about it though.<br><blockquote type="cite"><div text="#000000" bgcolor="#FFFFFF">
<br>
Just my 2¢</div></blockquote><blockquote type="cite"><div text="#000000" bgcolor="#FFFFFF"><font class="Apple-style-span" color="#000000"><br></font>
Tristan<br>
<br>
<br>
<br>
</div>
_______________________________________________<br>infinispan-dev mailing list<br><a href="mailto:infinispan-dev@lists.jboss.org">infinispan-dev@lists.jboss.org</a><br>https://lists.jboss.org/mailman/listinfo/infinispan-dev</blockquote></div><br><div apple-content-edited="true">
<span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; "><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; "><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; "><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; "><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; "><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div>Cheers,</div><div>-- <br>Mircea Markus</div><div>Infinispan lead (<a href="http://www.infinispan.org">www.infinispan.org</a>)</div><div><br></div></div></span></div></span></div></span></div></span><br class="Apple-interchange-newline"></span><br class="Apple-interchange-newline">
</div>
<br></body></html>