+1, it doesn't make sense to integrate a test that you know is failing.<br><br><br><div class="gmail_quote">On Thu, Oct 25, 2012 at 5:52 PM, Vladimir Blagojevic <span dir="ltr"><<a href="mailto:vblagoje@redhat.com" target="_blank">vblagoje@redhat.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi,<br>
<br>
I noticed that we recently have had many PR for unit tests integration<br>
into master. Would it not make more sense to integrate unit tests with<br>
actual fixes rather than having them merged directly to master as PRs?<br>
I'd say leave a unit test attached/referenced in JIRA and a<br>
developer/contributor fixing the issue will integrate both the fix and<br>
the unit test in a single PR.<br>
<br>
WDYT?<br>
<br>
Regards,<br>
Vladimir<br>
<br>
<br>
<br>
_______________________________________________<br>
infinispan-dev mailing list<br>
<a href="mailto:infinispan-dev@lists.jboss.org">infinispan-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a><br>
</blockquote></div><br>