<div class="gmail_extra"><br><div class="gmail_quote">On Tue, Dec 4, 2012 at 11:32 AM, Mircea Markus <span dir="ltr"><<a href="mailto:mmarkus@redhat.com" target="_blank">mmarkus@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="word-wrap:break-word"><div class="im"><br><div><div>On 4 Dec 2012, at 09:22, Sanne Grinovero wrote:</div><br><blockquote type="cite"><span style="border-collapse:separate;font-family:Helvetica;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:-webkit-auto;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;font-size:medium">[...]<br>
<br>I don't think the cache should ever be in an illegal state to be used<br>after being started. So Infinispan should not require tests to wait<br>for a "cluster to be formed", I'd rather guarantee that after a cache<br>
is started it's usable.<br></span></blockquote></div></div>+1. Unless the test relies/verifies internal state, e.g. locks being acquired, data present in the data container etc.<div><br></div></div></blockquote></div>
<br>It's not just a question of what you want to check, it's also a question of what you don't want to check... I think in general a test should focus on a specific issue, and we know state transfer is always a potential source of (unrelated) failures. So I'd rather have tests that do test state transfer and command forwarding, and tests that avoid state transfer and command forwarding (by waiting for the cluster to form completely).<br>
<br>I'm pretty sure this is another instance of ISPN-2473, and once we have a fix (and a unit test) for this particular failure, MarshallExternalPojosTest could very well wait for the cluster to form and ignore any state transfer-related issues.<br>
<br>BTW, I also got an exception yesterday in MarshallExternalPojosTest and I investigated it, but in my case the error was much weirder: two nodes both opened a TCP connection to each other, yet none of them received the forwarded command. I've asked Bela to investigate as well, but he didn't find anything suspicious in JGroups.<br>
<br><br><br></div>