<div dir="ltr"><div><div>Galder, the CacheManager.getUserTransaction() javadoc says the method should return "a" UserTransaction. It doesn't mandate any connection with any active TM, in fact based on this issue I think Ehcache will always return their own UserTransaction object: <a href="https://github.com/jsr107/jsr107spec/issues/28">https://github.com/jsr107/jsr107spec/issues/28</a><br>
</div><div><br>The Javadoc of the methods in UserTransaction and in TransactionManager in the standard are identical. So if they don't behave the same, that's a bug in the TM.<br><br>Case in point, I just looked at JBossTS version 4.16.3 and UserTransactionImple doesn't do anything except extend BaseTransaction. TransactionManagerImple also extends BaseTransaction and adds a few extra methods. BaseTransaction doesn't have any instance state (it's all statics and thread locals), so UserTransactionImple and TransactionManagerImple are identical except for the extra methods in TransactionManagerImple.<br>
<br></div>Cheers<br></div>Dan<br><br></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Feb 8, 2013 at 11:18 AM, Galder Zamarreño <span dir="ltr"><<a href="mailto:galder@redhat.com" target="_blank">galder@redhat.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I'm no transactions expert, but I did consider that and I highly doubt it's that simple.<br>
<br>
Even if it might probably just work, you'll never be able to guarantee that such UserTransaction behaves just like You-Fav-JTATM-UserTransaction without throrough testing.<br>
<br>
Go to your IDE (dunno where JBoss TS source code is online…) and open up:<br>
- com.arjuna.ats.internal.jta.transaction.arjunacore.UserTransactionImple<br>
- com.arjuna.ats.internal.jta.transaction.arjunacore.BaseTransaction<br>
<br>
Cheers,<br>
<div class="HOEnZb"><div class="h5"><br>
On Feb 7, 2013, at 2:17 PM, Dan Berindei <<a href="mailto:dan.berindei@gmail.com">dan.berindei@gmail.com</a>> wrote:<br>
<br>
> Do we really need to expose the TransactionManager's UserTransaction implementation?<br>
><br>
> Looking at the interface, it seems like a subset of TransactionManager, so couldn't we return a custom UserTransaction that just delegates to the TransactionManager?<br>
><br>
><br>
> On Thu, Feb 7, 2013 at 2:06 PM, Manik Surtani <<a href="mailto:msurtani@redhat.com">msurtani@redhat.com</a>> wrote:<br>
> Ok. Then a separate Lookup is what we'd need, I guess. Not pretty, but oh well.<br>
><br>
> On 7 Feb 2013, at 11:41, Galder Zamarreño <<a href="mailto:galder@redhat.com">galder@redhat.com</a>> wrote:<br>
><br>
> ><br>
> > On Feb 7, 2013, at 12:31 PM, Manik Surtani <<a href="mailto:msurtani@redhat.com">msurtani@redhat.com</a>> wrote:<br>
> ><br>
> >><br>
> >> On 7 Feb 2013, at 11:23, Galder Zamarreño <<a href="mailto:galder@redhat.com">galder@redhat.com</a>> wrote:<br>
> >><br>
> >>> Hi all,<br>
> >>><br>
> >>> I'm back with a more food for thought wrt JSR-107 impl. Our CacheManager adapter needs to implement:<br>
> >>><br>
> >>> UserTransaction getUserTransaction();<br>
> >>><br>
> >>> The problem there is that there's no standard way of getting a UserTransaction given a JTA TransactionManager.<br>
> >>><br>
> >>> It really is down to each TransactionManager provider to give a UserTransaction instance (whether JNDI, static…etc).<br>
> >>><br>
> >>> So, we need a way to lookup a UserTransaction.<br>
> >>><br>
> >>> One option is to add a getUserTransaction to TransactionManagerLookup, but that will break existing clients.<br>
> >><br>
> >> You mean it would break existing TML implementations?<br>
> ><br>
> > ^ Yeah, potentially yeah.<br>
> ><br>
> >> Do we know of any custom TML implementations though?<br>
> ><br>
> > Yes:<br>
> > - <a href="https://github.com/hibernate/hibernate-orm/blob/master/hibernate-infinispan/src/main/java/org/hibernate/cache/infinispan/tm/HibernateTransactionManagerLookup.java" target="_blank">https://github.com/hibernate/hibernate-orm/blob/master/hibernate-infinispan/src/main/java/org/hibernate/cache/infinispan/tm/HibernateTransactionManagerLookup.java</a><br>
> > - <a href="https://github.com/jbossas/jboss-as/blob/master/clustering/infinispan/src/main/java/org/jboss/as/clustering/infinispan/TransactionManagerProvider.java" target="_blank">https://github.com/jbossas/jboss-as/blob/master/clustering/infinispan/src/main/java/org/jboss/as/clustering/infinispan/TransactionManagerProvider.java</a><br>
> ><br>
> >><br>
> >>><br>
> >>> Alternatively, define a org.infinispan.transaction.lookup.UserTransactionLookup interface which is configurable. We'd then need to implement for existing TML classes.<br>
> >>><br>
> >>> If anyone has any other ideas, let us know.<br>
> >>><br>
> >>> Cheers,<br>
> >>> --<br>
> >>> Galder Zamarreño<br>
> >>> <a href="mailto:galder@redhat.com">galder@redhat.com</a><br>
> >>> <a href="http://twitter.com/galderz" target="_blank">twitter.com/galderz</a><br>
> >>><br>
> >>> Project Lead, Escalante<br>
> >>> <a href="http://escalante.io" target="_blank">http://escalante.io</a><br>
> >>><br>
> >>> Engineer, Infinispan<br>
> >>> <a href="http://infinispan.org" target="_blank">http://infinispan.org</a><br>
> >>><br>
> >>><br>
> >>> _______________________________________________<br>
> >>> infinispan-dev mailing list<br>
> >>> <a href="mailto:infinispan-dev@lists.jboss.org">infinispan-dev@lists.jboss.org</a><br>
> >>> <a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a><br>
> >><br>
> >> --<br>
> >> Manik Surtani<br>
> >> <a href="mailto:manik@jboss.org">manik@jboss.org</a><br>
> >> <a href="http://twitter.com/maniksurtani" target="_blank">twitter.com/maniksurtani</a><br>
> >><br>
> >> Platform Architect, JBoss Data Grid<br>
> >> <a href="http://red.ht/data-grid" target="_blank">http://red.ht/data-grid</a><br>
> >><br>
> >><br>
> >> _______________________________________________<br>
> >> infinispan-dev mailing list<br>
> >> <a href="mailto:infinispan-dev@lists.jboss.org">infinispan-dev@lists.jboss.org</a><br>
> >> <a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a><br>
> ><br>
> ><br>
> > --<br>
> > Galder Zamarreño<br>
> > <a href="mailto:galder@redhat.com">galder@redhat.com</a><br>
> > <a href="http://twitter.com/galderz" target="_blank">twitter.com/galderz</a><br>
> ><br>
> > Project Lead, Escalante<br>
> > <a href="http://escalante.io" target="_blank">http://escalante.io</a><br>
> ><br>
> > Engineer, Infinispan<br>
> > <a href="http://infinispan.org" target="_blank">http://infinispan.org</a><br>
> ><br>
> ><br>
> > _______________________________________________<br>
> > infinispan-dev mailing list<br>
> > <a href="mailto:infinispan-dev@lists.jboss.org">infinispan-dev@lists.jboss.org</a><br>
> > <a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a><br>
><br>
> --<br>
> Manik Surtani<br>
> <a href="mailto:manik@jboss.org">manik@jboss.org</a><br>
> <a href="http://twitter.com/maniksurtani" target="_blank">twitter.com/maniksurtani</a><br>
><br>
> Platform Architect, JBoss Data Grid<br>
> <a href="http://red.ht/data-grid" target="_blank">http://red.ht/data-grid</a><br>
><br>
><br>
> _______________________________________________<br>
> infinispan-dev mailing list<br>
> <a href="mailto:infinispan-dev@lists.jboss.org">infinispan-dev@lists.jboss.org</a><br>
> <a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a><br>
><br>
> _______________________________________________<br>
> infinispan-dev mailing list<br>
> <a href="mailto:infinispan-dev@lists.jboss.org">infinispan-dev@lists.jboss.org</a><br>
> <a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a><br>
<br>
<br>
--<br>
Galder Zamarreño<br>
<a href="mailto:galder@redhat.com">galder@redhat.com</a><br>
<a href="http://twitter.com/galderz" target="_blank">twitter.com/galderz</a><br>
<br>
Project Lead, Escalante<br>
<a href="http://escalante.io" target="_blank">http://escalante.io</a><br>
<br>
Engineer, Infinispan<br>
<a href="http://infinispan.org" target="_blank">http://infinispan.org</a><br>
<br>
<br>
_______________________________________________<br>
infinispan-dev mailing list<br>
<a href="mailto:infinispan-dev@lists.jboss.org">infinispan-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a><br>
</div></div></blockquote></div><br></div>