<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">What if we include that verbose info in
toString() only if trace is enabled? :) <br>
<br>
On 02/20/2013 02:36 PM, Dan Berindei wrote:<br>
</div>
<blockquote
cite="mid:CA+nfvwQJm3D2BvffY6GX3BT0OoR2s05Yo0y9PU9Hu6eyu7BM=Q@mail.gmail.com"
type="cite">
<div dir="ltr">
<div class="gmail_extra"><br>
<br>
<div class="gmail_quote">On Wed, Feb 20, 2013 at 11:49 AM,
Mircea Markus <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:mmarkus@redhat.com" target="_blank">mmarkus@redhat.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="word-wrap:break-word">
<div>I always liked this idea of categories but never
saw it at use. Are there any projects that use this
logging approach?</div>
<br>
<div>
<div class="im">
<div>On 20 Feb 2013, at 09:57, Sanne Grinovero
wrote:</div>
<br>
<blockquote type="cite">
<div>+1 for using categories<br>
<br>
We could even experiment combining multiple
categories, for example in<br>
this case you could have a "RPCDispatcher"
category and also have a<br>
"RPCDispatcher.includeCacheEntries" which will
make descriptions<br>
more/less verbose.</div>
</blockquote>
<div><br>
</div>
</div>
<div>
That's not what I understand by a category -
"logical process" as defined by David. I consider
"Remoting" or "Rehashing" a category, but
RPCDIspatcher is just an entity (too fine grained)
and RPCDispatcher.includeCacheEntries even more so.</div>
<div><br>
</div>
<div>Also that wouldn't necessarily solve the problem
Manik raised: in this particular case the toString
of StateResponseCommand is huge. Adrian/Dan is this
needed for debugging state transfer issues? If so +1
for managing it with the verbose flag.</div>
</div>
<br>
</div>
</blockquote>
<div><br>
</div>
<div>Yeah, we couldn't introduce a
RpcDispatcher.includeCacheEntries category anyway because
the cache entries are included in the command's toString()
- the logger can't do anything to filter them out.<br>
</div>
</div>
<br>
</div>
<div class="gmail_extra">I think we could eliminate the cache
entries from StateResponseCommand.toString() (and the segment
owners from ConsistentHash.toString()), and only log them
separately, under a different category/class name.<br>
</div>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
infinispan-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:infinispan-dev@lists.jboss.org">infinispan-dev@lists.jboss.org</a>
<a class="moz-txt-link-freetext" href="https://lists.jboss.org/mailman/listinfo/infinispan-dev">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a></pre>
</blockquote>
<br>
</body>
</html>