<html>
  <head>
    <meta content="text/html; charset=ISO-8859-1"
      http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    <div class="moz-cite-prefix">Will remove it then.<br>
      <br>
      Thanks!<br>
      <br>
      On 03/13/2013 02:46 PM, Manik Surtani wrote:<br>
    </div>
    <blockquote
      cite="mid:76150E3A-DAEC-41EA-842A-F08C1A20E29B@redhat.com"
      type="cite">
      <meta http-equiv="Content-Type" content="text/html;
        charset=ISO-8859-1">
      Correct answer, Dan.
      <div><br>
      </div>
      <div>And yes, it can now be removed.</div>
      <div><br>
        <div>
          <div>On 12 Mar 2013, at 13:52, Dan Berindei &lt;<a
              moz-do-not-send="true"
              href="mailto:dan.berindei@gmail.com">dan.berindei@gmail.com</a>&gt;
            wrote:</div>
          <br class="Apple-interchange-newline">
          <blockquote type="cite">
            <div dir="ltr">
              <div>I think the field was needed because
                InboundInvocationHandlerImpl was using
                ComponentRegistry.getComponent(ResponseGenerator.class),
                and there wasn't anyone actually creating the
                ResponseGenerator component.<br>
                <br>
              </div>
              Since <a moz-do-not-send="true"
                href="https://issues.jboss.org/browse/ISPN-1793">https://issues.jboss.org/browse/ISPN-1793</a>,
              ComponentRegistry creates the ResponseGenerator component
              explicitly, so the field in CacheImpl is no longer needed.<br>
              <br>
            </div>
            <div class="gmail_extra"><br>
              <br>
              <div class="gmail_quote">On Tue, Mar 12, 2013 at 1:53 PM,
                Mircea Markus <span dir="ltr">&lt;<a
                    moz-do-not-send="true"
                    href="mailto:mmarkus@redhat.com" target="_blank">mmarkus@redhat.com</a>&gt;</span>
                wrote:<br>
                <blockquote class="gmail_quote" style="margin:0 0 0
                  .8ex;border-left:1px #ccc solid;padding-left:1ex">git
                  annotate points to Mr. Surtani :-)<br>
                  <div>
                    <div class="h5"><br>
                      On 12 Mar 2013, at 11:43, Adrian Nistor wrote:<br>
                      <br>
                      &gt; And this is how it looked in 5.1.x<br>
                      &gt; <a moz-do-not-send="true"
href="https://github.com/anistor/infinispan/blob/5.1.x/core/src/main/java/org/infinispan/CacheImpl.java#L139"
                        target="_blank">https://github.com/anistor/infinispan/blob/5.1.x/core/src/main/java/org/infinispan/CacheImpl.java#L139</a><br>
                      &gt;<br>
                      &gt; On 03/12/2013 01:40 PM, Adrian Nistor wrote:<br>
                      &gt;&gt; Hi,<br>
                      &gt;&gt;<br>
                      &gt;&gt; does anyone know what issue is the unused
                      (but injected)<br>
                      &gt;&gt; CacheImpl.responseGenerator field
                      supposed to cure? See here:<br>
                      &gt;&gt; <a moz-do-not-send="true"
href="https://github.com/anistor/infinispan/blob/master/core/src/main/java/org/infinispan/CacheImpl.java#L139"
                        target="_blank">https://github.com/anistor/infinispan/blob/master/core/src/main/java/org/infinispan/CacheImpl.java#L139</a><br>
                      &gt;&gt;<br>
                      &gt;&gt;<br>
                      &gt;&gt; The accompanying comment does not seem to
                      be valid anymore. There is no<br>
                      &gt;&gt; jira for it and the tests run fine
                      without it. Can't we just remove it?<br>
                      &gt;&gt;<br>
                      &gt;&gt; Cheers<br>
                      &gt;&gt;
                      _______________________________________________<br>
                      &gt;&gt; infinispan-dev mailing list<br>
                      &gt;&gt; <a moz-do-not-send="true"
                        href="mailto:infinispan-dev@lists.jboss.org">infinispan-dev@lists.jboss.org</a><br>
                      &gt;&gt; <a moz-do-not-send="true"
                        href="https://lists.jboss.org/mailman/listinfo/infinispan-dev"
                        target="_blank">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a><br>
                      &gt;<br>
                      &gt;
                      _______________________________________________<br>
                      &gt; infinispan-dev mailing list<br>
                      &gt; <a moz-do-not-send="true"
                        href="mailto:infinispan-dev@lists.jboss.org">infinispan-dev@lists.jboss.org</a><br>
                      &gt; <a moz-do-not-send="true"
                        href="https://lists.jboss.org/mailman/listinfo/infinispan-dev"
                        target="_blank">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a><br>
                      <br>
                    </div>
                  </div>
                  Cheers,<br>
                  <span class="HOEnZb"><font color="#888888">--<br>
                      Mircea Markus<br>
                      Infinispan lead (<a moz-do-not-send="true"
                        href="http://www.infinispan.org/"
                        target="_blank">www.infinispan.org</a>)<br>
                    </font></span>
                  <div class="HOEnZb">
                    <div class="h5"><br>
                      <br>
                      <br>
                      <br>
                      <br>
                      _______________________________________________<br>
                      infinispan-dev mailing list<br>
                      <a moz-do-not-send="true"
                        href="mailto:infinispan-dev@lists.jboss.org">infinispan-dev@lists.jboss.org</a><br>
                      <a moz-do-not-send="true"
                        href="https://lists.jboss.org/mailman/listinfo/infinispan-dev"
                        target="_blank">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a><br>
                    </div>
                  </div>
                </blockquote>
              </div>
              <br>
            </div>
            _______________________________________________<br>
            infinispan-dev mailing list<br>
            <a moz-do-not-send="true"
              href="mailto:infinispan-dev@lists.jboss.org">infinispan-dev@lists.jboss.org</a><br>
            <a class="moz-txt-link-freetext" href="https://lists.jboss.org/mailman/listinfo/infinispan-dev">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a></blockquote>
        </div>
        <br>
        <div apple-content-edited="true">
          <span class="Apple-style-span" style="border-collapse:
            separate; color: rgb(0, 0, 0); font-family: Helvetica;
            font-style: normal; font-variant: normal; font-weight:
            normal; letter-spacing: normal; line-height: normal;
            orphans: 2; text-align: -webkit-auto; text-indent: 0px;
            text-transform: none; white-space: normal; widows: 2;
            word-spacing: 0px; border-spacing: 0px;
            -webkit-text-decorations-in-effect: none;
            -webkit-text-size-adjust: auto; -webkit-text-stroke-width:
            0px; font-size: medium; ">
            <div style="word-wrap: break-word; -webkit-nbsp-mode: space;
              -webkit-line-break: after-white-space; "><span
                class="Apple-style-span" style="border-collapse:
                separate; color: rgb(0, 0, 0); font-family: Helvetica;
                font-style: normal; font-variant: normal; font-weight:
                normal; letter-spacing: normal; line-height: normal;
                orphans: 2; text-align: -webkit-auto; text-indent: 0px;
                text-transform: none; white-space: normal; widows: 2;
                word-spacing: 0px; border-spacing: 0px;
                -webkit-text-decorations-in-effect: none;
                -webkit-text-size-adjust: auto;
                -webkit-text-stroke-width: 0px; font-size: medium; ">
                <div style="word-wrap: break-word; -webkit-nbsp-mode:
                  space; -webkit-line-break: after-white-space; "><span
                    class="Apple-style-span" style="border-collapse:
                    separate; color: rgb(0, 0, 0); font-family:
                    Helvetica; font-style: normal; font-variant: normal;
                    font-weight: normal; letter-spacing: normal;
                    line-height: normal; orphans: 2; text-indent: 0px;
                    text-transform: none; white-space: normal; widows:
                    2; word-spacing: 0px; border-spacing: 0px;
                    -webkit-text-decorations-in-effect: none;
                    -webkit-text-size-adjust: auto;
                    -webkit-text-stroke-width: 0px; font-size: medium; ">
                    <div style="word-wrap: break-word;
                      -webkit-nbsp-mode: space; -webkit-line-break:
                      after-white-space; ">
                      <div>--</div>
                      <div>Manik Surtani</div>
                      <div><a moz-do-not-send="true"
                          href="mailto:manik@jboss.org">manik@jboss.org</a></div>
                      <div><a moz-do-not-send="true"
                          href="http://twitter.com/maniksurtani">twitter.com/maniksurtani</a></div>
                      <div><br>
                      </div>
                      <div>
                        <div>Platform Architect, JBoss Data Grid</div>
                        <div><a moz-do-not-send="true"
                            href="http://red.ht/data-grid">http://red.ht/data-grid</a></div>
                      </div>
                    </div>
                  </span></div>
              </span></div>
          </span>
        </div>
        <br>
      </div>
      <br>
      <fieldset class="mimeAttachmentHeader"></fieldset>
      <br>
      <pre wrap="">_______________________________________________
infinispan-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:infinispan-dev@lists.jboss.org">infinispan-dev@lists.jboss.org</a>
<a class="moz-txt-link-freetext" href="https://lists.jboss.org/mailman/listinfo/infinispan-dev">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a></pre>
    </blockquote>
    <br>
  </body>
</html>