<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">Hi Sanne<br><br>On Tue, Mar 19, 2013 at 4:12 PM, Sanne Grinovero <span dir="ltr"><<a href="mailto:sanne@infinispan.org" target="_blank">sanne@infinispan.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Mircea,<br>
what I was most looking forward was to you comment on the interceptor<br>
order generated for DIST+cachestores<br>
- we don't think the ClusteredCacheLoader should be needed at all<br></blockquote><div><br></div><div>Agree, ClusteredCacheLoader should not be necessary.<br></div><div><br>James, if you're still seeing problems with numOwners=1, could you create an issue in JIRA?<br>
<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
- each DIST node is loading from the CacheLoader (any) rather than<br>
loading from its peer nodes for non-owned entries (!!)<br>
<br></blockquote><div><br></div><div>Sometimes loading stuff from a local disk is faster than going remote, e.g. if you have numOwners=2 and both owners have to load the same entry from disk and send it to the originator twice. <br>
<br>Still, most of the time the entry is going to be in memory on the owner nodes, so the local load is slower (especially with a shared cache store, where loading is over the network as well).<br><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
This has come up on several threads now and I think it's critically<br>
wrong, as I commented previously this also introduces many<br>
inconsistencies - as far as I understand it.<br>
<br></blockquote><div><br></div><div>Is there a JIRA for this already?<br><br></div><div>Yes, loading a stale entry from the local cache store is definitely not a good thing, but we actually delete the non-owned entries after the initial state transfer. There may be some consistency issues if one uses a DIST_SYNC cache with a shared async cache store, but fully sync configurations should be fine.<br>
<br></div><div>OTOH, if the cache store is not shared, the chances of finding the entry in the local store on a non-owner are slim to none, so it doesn't make sense to do the lookup.<br><br></div><div>Implementation-wise, just changing the interceptor order is probably not enough. If the key doesn't exist in the cache, the CacheLoaderInterceptor will still try to load it from the cache store after the remote lookup, so we'll need a marker in the invocation context to avoid the extra cache store load. Actually, since this is just a performance issue, it could wait until we implement tombstones everywhere.<br>
<br></div><div> <br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
BTW your gist wouldn't work, the metadata cache needs to load certain<br>
elements too. But nice you spotted the need to potentially filter what<br>
"preload" means in the scope of each cache, as the metadata one should<br>
only preload metadata, while in the original configuration this data<br>
would indeed be duplicated.<br>
Opened: <a href="https://issues.jboss.org/browse/ISPN-2938" target="_blank">https://issues.jboss.org/browse/ISPN-2938</a><br>
<span class="HOEnZb"><font color="#888888"><br>
Sanne<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
On 19 March 2013 11:51, Mircea Markus <<a href="mailto:mmarkus@redhat.com">mmarkus@redhat.com</a>> wrote:<br>
><br>
> On 16 Mar 2013, at 01:19, Sanne Grinovero wrote:<br>
><br>
>> Hi Adrian,<br>
>> let's forget about Lucene details and focus on DIST.<br>
>> With numOwners=1 and having two nodes the entries should be stored<br>
>> roughly 50% on each node, I see nothing wrong with that<br>
>> considering you don't need data failover in a read-only use case<br>
>> having all the index available in the shared CacheLoader.<br>
>><br>
>> In such a scenario, and having both nodes preloaded all data, in case<br>
>> of a get() operation I would expect<br>
>> either:<br>
>> A) to be the owner, hence retrieve the value from local in-JVM reference<br>
>> B) to not be the owner, so to forward the request to the other node<br>
>> having roughly 50% chance per key to be in case A or B.<br>
>><br>
>> But when hitting case B) it seems that instead of loading from the<br>
>> other node, it hits the CacheLoader to fetch the value.<br>
>><br>
>> I already had asked James to verify with 4 nodes and numOwners=2, the<br>
>> result is the same so I suggested him to ask here;<br>
>> BTW I think numOwners=1 is perfectly valid and should work as with<br>
>> numOwners=1, the only reason I asked him to repeat<br>
>> the test is that we don't have much tests on the numOwners=1 case and<br>
>> I was assuming there might be some (wrong) assumptions<br>
>> affecting this.<br>
>><br>
>> Note that this is not "just" a critical performance problem but I'm<br>
>> also suspecting it could provide inconsistent reads, in two classes of<br>
>> problems:<br>
>><br>
>> # non-shared CacheStore with stale entries<br>
>> If for non-owned keys it will hit the local CacheStore first, where<br>
>> you might expect to not find anything, so to forward the request to<br>
>> the right node. What if this node has been the owner in the past? It<br>
>> might have an old entry locally stored, which would be returned<br>
>> instead of the correct value which is owned on a different node.<br>
>><br>
>> # shared CacheStore using write-behind<br>
>> When using an async CacheStore by definition the content of the<br>
>> CacheStore is not trustworthy if you don't check on the owner first<br>
>> for entries in memory.<br>
>><br>
>> Both seem critical to me, but the performance impact is really bad too.<br>
>><br>
>> I hoped to make some more tests myself but couldn't look at this yet,<br>
>> any help from the core team would be appreciated.<br>
> I think you have a fair point and reads/writes to the data should be coordinated through its owners both for performance and (more importantly) correctness.<br>
> Mind creating a JIRA for this?<br>
><br>
>><br>
>> @Ray, thanks for mentioning the ClusterCacheLoader. Wasn't there<br>
>> someone else with a CacheLoader issue recently who had worked around<br>
>> the problem by using a ClusterCacheLoader ?<br>
>> Do you remember what the scenario was?<br>
>><br>
>> Cheers,<br>
>> Sanne<br>
>><br>
>> On 15 March 2013 15:44, Adrian Nistor <<a href="mailto:anistor@redhat.com">anistor@redhat.com</a>> wrote:<br>
>>> Hi James,<br>
>>><br>
>>> I'm not an expert on InfinispanDirectory but I've noticed in [1] that<br>
>>> the lucene-index cache is distributed with numOwners = 1. That means<br>
>>> each cache entry is owned by just one cluster node and there's nowhere<br>
>>> else to go in the cluster if the key is not available in local memory,<br>
>>> thus it needs fetching from the cache store. This can be solved with<br>
>>> numOwners > 1.<br>
>>> Please let me know if this solves your problem.<br>
>>><br>
>>> Cheers!<br>
>>><br>
>>> On 03/15/2013 05:03 PM, James Aley wrote:<br>
>>>> Hey all,<br>
>>>><br>
>>>> <OT><br>
>>>> Seeing as this is my first post, I wanted to just quickly thank you<br>
>>>> all for Infinispan. So far I'm really enjoying working with it - great<br>
>>>> product!<br>
>>>> </OT><br>
>>>><br>
>>>> I'm using the InfinispanDirectory for a Lucene project at the moment.<br>
>>>> We use Lucene directly to build a search product, which has high read<br>
>>>> requirements and likely very large indexes. I'm hoping to make use of<br>
>>>> a distribution mode cache to keep the whole index in memory across a<br>
>>>> cluster of machines (the index will be too big for one server).<br>
>>>><br>
>>>> The problem I'm having is that after loading a filesystem-based Lucene<br>
>>>> directory into InfinispanDirectory via LuceneCacheLoader, no nodes are<br>
>>>> retrieving data from the cluster - they instead look up keys in their<br>
>>>> local CacheLoaders, which involves lots of disk I/O and is very slow.<br>
>>>> I was hoping to just use the CacheLoader to initialize the caches, but<br>
>>>> from there on read only from RAM (and network, of course). Is this<br>
>>>> supported? Maybe I've misunderstood the purpose of the CacheLoader?<br>
>>>><br>
>>>> To explain my observations in a little more detail:<br>
>>>> * I start a cluster of two servers, using [1] as the cache config.<br>
>>>> Both have a local copy of the Lucene index that will be loaded into<br>
>>>> the InfinispanDirectory via the loader. This is a test configuration,<br>
>>>> where I've set numOwners=1 so that I only need two servers for<br>
>>>> distribution to happen.<br>
>>>> * Upon startup, things look good. I see the memory usage of the JVM<br>
>>>> reflect a pretty near 50/50 split of the data across both servers.<br>
>>>> Logging indicates both servers are in the cluster view, all seems<br>
>>>> fine.<br>
>>>> * When I send a search query to either one of the nodes, I notice the following:<br>
>>>> - iotop shows huge (~100MB/s) disk I/O on that node alone from the<br>
>>>> JVM process.<br>
>>>> - no change in network activity between nodes (~300b/s, same as when idle)<br>
>>>> - memory usage on the node running the query increases dramatically,<br>
>>>> and stays higher even after the query is finished.<br>
>>>><br>
>>>> So it seemed to me like each node was favouring use of the CacheLoader<br>
>>>> to retrieve keys that are not in memory, instead of using the cluster.<br>
>>>> Does that seem reasonable? Is this the expected behaviour?<br>
>>>><br>
>>>> I started to investigate this by turning on trace logging, in this<br>
>>>> made me think perhaps the cause was that the CacheLoader's interceptor<br>
>>>> is higher priority in the chain than the the distribution interceptor?<br>
>>>> I'm not at all familiar with the design in any level of detail - just<br>
>>>> what I picked up in the last 24 hours from browsing the code, so I<br>
>>>> could easily be way off. I've attached the log snippets I thought<br>
>>>> relevant in [2].<br>
>>>><br>
>>>> Any advice offered much appreciated.<br>
>>>> Thanks!<br>
>>>><br>
>>>> James.<br>
>>>><br>
>>>><br>
>>>> [1] <a href="https://www.refheap.com/paste/12531" target="_blank">https://www.refheap.com/paste/12531</a><br>
>>>> [2] <a href="https://www.refheap.com/paste/12543" target="_blank">https://www.refheap.com/paste/12543</a><br>
>>>> _______________________________________________<br>
>>>> infinispan-dev mailing list<br>
>>>> <a href="mailto:infinispan-dev@lists.jboss.org">infinispan-dev@lists.jboss.org</a><br>
>>>> <a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a><br>
>>><br>
>>> _______________________________________________<br>
>>> infinispan-dev mailing list<br>
>>> <a href="mailto:infinispan-dev@lists.jboss.org">infinispan-dev@lists.jboss.org</a><br>
>>> <a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a><br>
>> _______________________________________________<br>
>> infinispan-dev mailing list<br>
>> <a href="mailto:infinispan-dev@lists.jboss.org">infinispan-dev@lists.jboss.org</a><br>
>> <a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a><br>
><br>
> Cheers,<br>
> --<br>
> Mircea Markus<br>
> Infinispan lead (<a href="http://www.infinispan.org" target="_blank">www.infinispan.org</a>)<br>
><br>
><br>
><br>
><br>
><br>
> _______________________________________________<br>
> infinispan-dev mailing list<br>
> <a href="mailto:infinispan-dev@lists.jboss.org">infinispan-dev@lists.jboss.org</a><br>
> <a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a><br>
_______________________________________________<br>
infinispan-dev mailing list<br>
<a href="mailto:infinispan-dev@lists.jboss.org">infinispan-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a><br>
</div></div></blockquote></div><br></div></div>