<div dir="ltr"><div>Yeah, I don't think you could extract the hash from the "cache of hashes" without computing the hash in the first place...<br><br></div>My idea was to wrap the key in a KeyWithHash object and cache the hash there (since we're looking up the same key in a lot of maps during a single invocation). <br>
<br>Sorry Galder, I forgot about your patch, but I still think we'd need a wrapper for keys in order to cache the hash code even if we could define an Equivalence function.<br><br><br></div><div class="gmail_extra"><br>
<br><div class="gmail_quote">On Thu, Apr 25, 2013 at 2:27 PM, Sanne Grinovero <span dir="ltr"><<a href="mailto:sanne@infinispan.org" target="_blank">sanne@infinispan.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im">On 25 April 2013 11:51, Galder Zamarreño <<a href="mailto:galder@redhat.com">galder@redhat.com</a>> wrote:<br>
><br>
> On Apr 22, 2013, at 3:09 PM, Dan Berindei <<a href="mailto:dan.berindei@gmail.com">dan.berindei@gmail.com</a>> wrote:<br>
><br>
>><br>
>><br>
>><br>
>> On Mon, Apr 22, 2013 at 2:37 PM, Sanne Grinovero <<a href="mailto:sanne@infinispan.org">sanne@infinispan.org</a>> wrote:<br>
>> We also have been toying with the idea to hash each key only once,<br>
>> instead of both with the consistent hash (to assign the node owner)<br>
>> and once in the CHM backing the datacontainer.<br>
>> I doubt we need the datacontainer to implement Map at all, but at<br>
>> least if we go this way we don't want the hash to be affected by the<br>
>> VM instance or different nodes won't agree on the expected owner ;-)<br>
>><br>
>><br>
>> For consistent hashing it would probably be better to cache the hash after applying MurmurHash to it anyway. So we could in theory hack our CHMV8 to use a cached hash code computed with MurmurHash and a cluster-specific salt.<br>
><br>
> ^ Rather than hacking CHMv8, better to provide an Equivalence function (which CHMv8 will have an instance variable of) for the keys which keeps the cache of hashes or something… once that work is committed, we can discuss further :)<br>
<br>
</div>+1 to use your cool implementation. Don't like too much the sound of<br>
"cache the hashes or something", I didn't actually look at the code,<br>
but from gut feeling I would hope the Equivalence function to be<br>
stateless? We might be able to pass the to-be-reused hash as a<br>
parameter in primitive form.<br>
<span class="HOEnZb"><font color="#888888"><br>
Sanne<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
_______________________________________________<br>
infinispan-dev mailing list<br>
<a href="mailto:infinispan-dev@lists.jboss.org">infinispan-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a></div></div></blockquote></div><br></div>