<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, May 3, 2013 at 1:49 PM, Galder Zamarreņo <span dir="ltr"><<a href="mailto:galder@redhat.com" target="_blank">galder@redhat.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Here's what I replied in a separate email last. Since then the issue has been sorted:<br>
<br>
> The reason I designed a byte[] specific Equivalence class is to avoid<br>
doing instanceof on the type passed. This would slow things in a<br>
critical path, hence, I designed a purely byte[] Equivalence class,<br>
and why there's no instanceof in AnyEquivalence either, to be as<br>
performant as possible.<br>
<br>
So yeah, as you suggest, the workaround would be for AnyEquivalence to<br>
check if the parameter is a byte[], in which case, delegate to<br>
ByteArrayEquivalence, but to reiterate, this is only a workaround and<br>
not the optimal solution.<br>
<br></blockquote><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I also checked if the Hot Rod server could add this itself to the<br>
caches, but this is complex stuff because it's given a cache manager<br>
already built, so it'd need to go and change the default configuration<br>
to apply this change programmatically, which is not easy because<br>
you're given a Configuration object and not the buillder, and making<br>
Configuration mutable just for that, where you're just trying to<br>
override what it's been configured in the cache manager is a hack.<br>
<br>
Since we controlled the way the servers are started via Infinispan<br>
Server, I assumed we controlled its configuration, hence I expected<br>
configuring BAEquivalence to be a safe assumption. We've made a bad<br>
job of waiting to integrate this and test Infinispan Server until now,<br>
with 7 days since the pull req has been up. Maybe the pull req test<br>
execution needs to also execute the Infinispan Servers testsuite<br>
automatically to avoid future issues....<br></blockquote><div><br></div><div>-1 to add more stuff to the pull request build, it already takes half a day for all the pull requests to be revalidated after a push to master. (10 PRs * 30 mins/PR = 5h)<br>
<br></div><div>Besides, if this change broke Infinispan Server, isn't there a risk that it broke 3rd party applications relying on the HotRod server as well?<br><br></div><div> <br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div><br>
On May 2, 2013, at 5:05 PM, Tristan Tarrant <<a href="mailto:ttarrant@redhat.com" target="_blank">ttarrant@redhat.com</a>> wrote:<br>
<br>
</div><div><div>> Hi all (Galder in particular),<br>
><br>
> the integration of ISPN-2281 has caused breakage of Infinispan Server<br>
> because the caches created by the server have key/value equivalence set<br>
> to AnyEquivalence instead of ByteArrayEquivalence (like the testsuite does).<br>
> I believe the fix rests in making AnyEquivalence true to its name and<br>
> handle array equivalence too.<br>
><br>
> HotRod on Infinispan Server is essentially broken until this is fixed.<br>
><br>
> Tristan<br>
> _______________________________________________<br>
> infinispan-dev mailing list<br>
> <a href="mailto:infinispan-dev@lists.jboss.org" target="_blank">infinispan-dev@lists.jboss.org</a><br>
> <a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a><br>
<br>
<br>
</div></div><div>--<br>
Galder Zamarreņo<br>
<a href="mailto:galder@redhat.com" target="_blank">galder@redhat.com</a><br>
<a href="http://twitter.com/galderz" target="_blank">twitter.com/galderz</a><br>
<br>
Project Lead, Escalante<br>
<a href="http://escalante.io" target="_blank">http://escalante.io</a><br>
<br>
Engineer, Infinispan<br>
<a href="http://infinispan.org" target="_blank">http://infinispan.org</a><br>
<br>
<br>
</div><div><div>_______________________________________________<br>
infinispan-dev mailing list<br>
<a href="mailto:infinispan-dev@lists.jboss.org" target="_blank">infinispan-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a><br>
</div></div></blockquote></div><br></div></div>