<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, May 13, 2013 at 8:44 PM, Sanne Grinovero <span dir="ltr"><<a href="mailto:sanne@infinispan.org" target="_blank">sanne@infinispan.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">On 13 May 2013 18:32, Manik Surtani <<a href="mailto:msurtani@redhat.com">msurtani@redhat.com</a>> wrote:<br>
><br>
> On 13 May 2013, at 16:25, Mircea Markus <<a href="mailto:mmarkus@redhat.com">mmarkus@redhat.com</a>> wrote:<br>
><br>
>><br>
>> On 13 May 2013, at 15:05, Manik Surtani wrote:<br>
>><br>
>>>> 100% agree, most users will have to interact with AdvancedCache at some point - if only because of lock() and withFlags().<br>
>>><br>
>>> I've seen quite a bit of end-user code that doesn't touch AdvancedCache.<br>
>> I'm on Dan's side here, I think it's pretty popular through the users and should be considered as public API. A note on the same lines, we also recommend all our users to use Flag.IGNORE_RETURN_VALUE, which again goes trough AdvancedCache.<br>
><br>
> So you're saying getTimeService() should be in EmbeddedCacheManager? That's Dan's argument... I really don't think this should be accessible by end-user applications.<br>
<br>
</div>+1 to keep it hidden, but SPI kind of API wouldn't be too bad.<br>
<br></blockquote><div><br></div><div>If we want to keep it hidden, then I think it would be best to leave the getTimeService() method only in ComponentRegistry/GlobalComponentRegistry and remove it from the AdvancedCache interface. <br>
<br>We might want to remove it from the configuration, too.<br><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
More importantly, I'd design it in such a way that different Caches<br>
could be using a different one. Doesn't have to be supported in the<br>
current code implementation, I just mean API-wise this should not be<br>
on a "global" component but on a Cache-specific one.<br>
<span class="HOEnZb"><font color="#888888"></font></span><br></blockquote></div><br></div><div class="gmail_extra">Any particular usage in mind for having a different time service in each cache?<br><br></div><div class="gmail_extra">
We definitely need a global component, because JGroupsTransport uses it, so we'd have to support both.<br><br></div><div class="gmail_extra">Cheers<br></div><div class="gmail_extra">Dan<br><br></div></div>