<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Aug 15, 2013 at 11:45 AM, Radim Vansa <span dir="ltr"><<a href="mailto:rvansa@redhat.com" target="_blank">rvansa@redhat.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"><div class="im">
<div>On 08/15/2013 03:57 PM, Ray Tsang
wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr"><br>
<div class="gmail_extra"><br>
<br>
<div class="gmail_quote">On Thu, Aug 15, 2013 at 9:48 AM,
Galder Zamarreño <span dir="ltr"><<a href="mailto:galder@redhat.com" target="_blank">galder@redhat.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><br>
On Aug 14, 2013, at 11:14 PM, Ray Tsang <<a href="mailto:saturnism@gmail.com" target="_blank">saturnism@gmail.com</a>>
wrote:<br>
<br>
> I actually did not enjoy writing parsers and config
builders etc…<br>
<br>
</blockquote>
<div><br>
</div>
<div>
<div>i felt that writing the parsers are error prone -
there are many places to touch when adding a property -
maybe I just didn't follow the best example...</div>
<div><br>
</div>
<div>
i'm just thinking out loud but perhaps there is a way to
consolidate the configuration builder, configuration,
configuration parser, and xsd with a single set of
metadata - after all, I think they are all trying to set
the same set of properties.</div>
</div>
</div>
</div>
</div>
</blockquote>
<br></div>
Well, it's true that the Maven build process could generate at least
the XSD automatically, and automatic parsing is not that complicated
- in fact I've done this in RadarGun, changing Mircea's original
setter-way.<br>
But in order to be able to use the programmatic configuration, you
have either write the builder yourself or generate it with some tool
(I don't think it would be right to generate further Java sources
during the Maven build, even if it is possible). And using tool for
generation of some Java code based on another code seems to me as
another nasty complication.<br>
Alltogether, writing *Configuration and *ConfigurationBuilder should
be enough, all the rest can be managed by runtime/build.<div class="im"><br></div></div></blockquote><div><br></div><div style>+1. It just feel very redundant the way it is now. condensing into Configuration and ConfigurationBuilder sounds great too, at least it's completely typesafe at this point. </div>
<div style><br></div><div style>Otherwise, the way it is now, we have to keep property names in sync, and documentation in sync, and default values in sync, etc.. and 52 parser vs as7 parser? =(</div><div style> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"><div class="im">
<br>
<blockquote type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">
<div>
</div>
<div><br>
</div>
<div> </div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">^
Why not? Too verbose? Too many classes?<br>
<br>
I'd rather improve this than carry on supporting
property-based configuration (any other type safety
advocates?)<br>
</blockquote>
<div><br>
</div>
<div>+1, the fact that I had to test both was a
nuance...</div>
</div>
</div>
</div>
</blockquote></div>
+1 as well<span class="HOEnZb"><font color="#888888"><br>
<br>
Radim<br>
</font></span></div>
<br>_______________________________________________<br>
infinispan-dev mailing list<br>
<a href="mailto:infinispan-dev@lists.jboss.org">infinispan-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a><br></blockquote></div><br></div></div>