<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Sep 9, 2013 at 12:34 PM, Tristan Tarrant <span dir="ltr"><<a href="mailto:ttarrant@redhat.com" target="_blank">ttarrant@redhat.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class="im">On 09/09/2013 11:18 AM, Dan Berindei wrote:<br>
> Hi guys<br>
><br>
> As you know, I'm working on ISPN-3051, allowing each node to take a<br>
> higher or lower proportion of the entries in the cache. I've<br>
> implemented this by adding a float "loadFactor" setting in each node's<br>
> configuration, with 1 being the default and any positive value being<br>
> accepted (including 0).<br>
><br>
> There are two questions I wanted to ask you about the configuration:<br>
><br>
> 1. What do you think about the "loadFactor" name? I started having<br>
> doubts about it, since it has a very different meaning in HashMap. I<br>
> have come up with a couple alternatives, but I don't love any of them:<br>
> "proportionalLoad" and "proportionalCapacity".<br>
</div>Since this is "per-node", you want to use the "node" word in there, so<br>
"nodeCapacity" would be good. Can this value change at runtime ?<br></blockquote><div><br>
</div><div>nodeCapacity by itself would sound like we're limiting the actual number of keys held on this node, so I feel it would be misleading. You do have a point about having "node" in the name though... how about "nodeScale"?<br>
<br>The value can't change at runtime. TBH, I haven't even considered it.<br></div><div><br> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div class="im">> 2. Where should we put this setting? I have added it as<br>
> CacheConfiguration.clustering().hash().loadFactor(), but I can't think<br>
> of a reason for having different values for each cache, so we might as<br>
> well put it in the global configuration.<br>
</div>Yes, global sounds good. And don't forget server :)<br>
<span class=""><font color="#888888"><br></font></span></blockquote><div><br></div><div>I guess the others disagree, so I'll keep it at the cache level.<br><br></div><div>I'll try to remember about server ;)<br><br>
</div><div>Cheers<br>Dan<br></div></div><br></div></div>