<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Jun 6, 2014 at 4:31 PM, Sanne Grinovero <span dir="ltr"><<a href="mailto:sanne@infinispan.org" target="_blank">sanne@infinispan.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">I'm having several failures, these are blocking our progress on Query.<br>
<br>
Should I disable them all?<br></blockquote><div><br></div><div>You could disable them, but I'm not quite sure how that would help the query module... surely you don't need to run the core tests every time you modify something in query?</div>
<div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<br>
Sample output of three different runs:<br>
<br>
Failed tests:<br>
ThreadLocalLeakTest.testCheckThreadLocalLeaks:87 IllegalState Thread<br>
locals st...<br></blockquote><div><br></div><div>I couldn't reproduce this failure on my machine, but I modified ThreadLocalLeakTest to ignore that particular thread-local: <a href="https://github.com/infinispan/infinispan/pull/2614">https://github.com/infinispan/infinispan/pull/2614</a></div>
<div>You're the only one that reported seeing it, so please test the PR on your machine and integrate it.</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
StateTransferOverwriteTest>BaseTxStateTransferOverwriteTest.testStateTransferInBetweenPrepareCommitWithPutIfAbsent:104->BaseTxStateTransferOverwriteTest.doStateTransferInBetweenPrepareCommit:265<br>
» Runtime<br>
Tests run: 5430, Failures: 2, Errors: 0, Skipped: 0<br></blockquote><div><br></div><div>I've created <a href="https://issues.jboss.org/browse/ISPN-4368">https://issues.jboss.org/browse/ISPN-4368</a> for Will to look into, I'm not sure we need the "placeholder" key that is causing the random failures.</div>
<div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<br>
Failed tests:<br>
ThreadLocalLeakTest.testCheckThreadLocalLeaks:87 IllegalState Thread<br>
locals st...<br>
StateTransferOverwriteTest>BaseTxStateTransferOverwriteTest.testStateTransferInBetweenPrepareCommitWithPutIfAbsent:104->BaseTxStateTransferOverwriteTest.doStateTransferInBetweenPrepareCommit:265<br>
» Runtime<br>
L1StateTransferOverwriteTest>BaseTxStateTransferOverwriteTest.testStateTransferInBetweenPrepareCommitWithPut:84->BaseTxStateTransferOverwriteTest.doStateTransferInBetweenPrepareCommit:265<br>
» Runtime<br></blockquote><div><br></div><div>The L1StateTransferOverwriteTest failure seems to have the same cause as StateTransferOverwriteTest failure.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
Tests run: 5430, Failures: 3, Errors: 0, Skipped: 0<br>
<br>
Failed tests:<br>
ThreadLocalLeakTest.testCheckThreadLocalLeaks:87 IllegalState Thread<br>
locals st...<br>
CacheNotifierImplInitialTransferDistTest.testCreateAfterIterationBeganAndSegmentNotCompleteValueOwnerClustered:611->testIterationBeganAndSegmentNotComplete:510<br>
expected [11] but found [6]<br></blockquote><div><br class="">I've seen this a couple times on my machine as well, I've created <a href="https://issues.jboss.org/browse/ISPN-4370">https://issues.jboss.org/browse/ISPN-4370</a></div>
<div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
Tests run: 5430, Failures: 2, Errors: 0, Skipped: 0</blockquote><div><br></div><div><br></div><div>I'd let Will investigate ISPN-4368 and ISPN-4370 for a bit before disabling those tests - he may be able to issue a PR for them quite quickly.<br>
</div><div><br></div><div>Still, just because I don't like disabling tests it doesn't mean I don't appreciate your stability reports - keep 'em coming!</div><div><br></div><div><br></div><div>Cheers</div>
<div>
Dan</div><div><br></div></div><br></div></div>