<div dir="ltr"><div><br></div><div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jun 9, 2014 at 12:43 PM, Sanne Grinovero <span dir="ltr"><<a href="mailto:sanne@infinispan.org" target="_blank">sanne@infinispan.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Hi Dan!<br>
<br>
The reason is that I'm making substantial API changes in the Query<br>
module, and I've lost count on how many other modules and integration<br>
tests depend on it: I need to run all the testsuite to evaluate where<br>
I'm heading.. I don't need it just as last touches but continually, to<br>
be able to make good choices while work is in progress.<br></blockquote><div><br></div><div>Wouldn't "mvn install -DskipTests" be enough for testing dependencies?</div><div>You could then use "mvn surefire:test -pl query,lucene-directory" to run just the tests you're interested in.</div>
<div>I have a script that does just that - even for core, I don't want to think about whether I changed something in commons or not, but I almost never want to run the commons tests :)</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<br>
Not only I'm changing API but also substantial changes in the<br>
dependency tree.. without a working testsuite I can't make progress.<br>
I'm working around it by deleting core in a temporary commit... :-/<br>
(and even so the suite takes more than an hour ??!)<br>
<br></blockquote><div><br></div><div>1 hour just for the core, or for everything? I used to get about 1h for everything, if just the core takes that long to fail it's definitely a problem. There was also a bit of a slowdown after the JGroups 3.5.0.Beta7 upgrade (ISPN-4355), but that should be fixed now.</div>
<div><div><br></div><div>I was also thinking of moving the failsafe plugin to the "extras" profile, so that we can avoid running the server integration tests in dev builds. But disabling the extras profile also disables the bundling for OSGi, so perhaps a separate profile would be better.</div>
<div><br></div><div>Dan</div></div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
I'll test your PRs ASAP, thanks a lot.<br>
<br>
Cheers,<br>
Sanne<br>
<div class=""><div class="h5"><br>
<br>
On 9 June 2014 10:19, Dan Berindei <<a href="mailto:dan.berindei@gmail.com">dan.berindei@gmail.com</a>> wrote:<br>
><br>
><br>
><br>
> On Fri, Jun 6, 2014 at 4:31 PM, Sanne Grinovero <<a href="mailto:sanne@infinispan.org">sanne@infinispan.org</a>><br>
> wrote:<br>
>><br>
>> I'm having several failures, these are blocking our progress on Query.<br>
>><br>
>> Should I disable them all?<br>
><br>
><br>
> You could disable them, but I'm not quite sure how that would help the query<br>
> module... surely you don't need to run the core tests every time you modify<br>
> something in query?<br>
><br>
>><br>
>><br>
>> Sample output of three different runs:<br>
>><br>
>> Failed tests:<br>
>> ThreadLocalLeakTest.testCheckThreadLocalLeaks:87 IllegalState Thread<br>
>> locals st...<br>
><br>
><br>
> I couldn't reproduce this failure on my machine, but I modified<br>
> ThreadLocalLeakTest to ignore that particular thread-local:<br>
> <a href="https://github.com/infinispan/infinispan/pull/2614" target="_blank">https://github.com/infinispan/infinispan/pull/2614</a><br>
> You're the only one that reported seeing it, so please test the PR on your<br>
> machine and integrate it.<br>
><br>
><br>
>><br>
>><br>
>> StateTransferOverwriteTest>BaseTxStateTransferOverwriteTest.testStateTransferInBetweenPrepareCommitWithPutIfAbsent:104->BaseTxStateTransferOverwriteTest.doStateTransferInBetweenPrepareCommit:265<br>
>> » Runtime<br>
>> Tests run: 5430, Failures: 2, Errors: 0, Skipped: 0<br>
><br>
><br>
> I've created <a href="https://issues.jboss.org/browse/ISPN-4368" target="_blank">https://issues.jboss.org/browse/ISPN-4368</a> for Will to look<br>
> into, I'm not sure we need the "placeholder" key that is causing the random<br>
> failures.<br>
><br>
>><br>
>><br>
>> Failed tests:<br>
>> ThreadLocalLeakTest.testCheckThreadLocalLeaks:87 IllegalState Thread<br>
>> locals st...<br>
>><br>
>> StateTransferOverwriteTest>BaseTxStateTransferOverwriteTest.testStateTransferInBetweenPrepareCommitWithPutIfAbsent:104->BaseTxStateTransferOverwriteTest.doStateTransferInBetweenPrepareCommit:265<br>
>> » Runtime<br>
>><br>
>> L1StateTransferOverwriteTest>BaseTxStateTransferOverwriteTest.testStateTransferInBetweenPrepareCommitWithPut:84->BaseTxStateTransferOverwriteTest.doStateTransferInBetweenPrepareCommit:265<br>
>> » Runtime<br>
><br>
><br>
> The L1StateTransferOverwriteTest failure seems to have the same cause as<br>
> StateTransferOverwriteTest failure.<br>
><br>
>><br>
>> Tests run: 5430, Failures: 3, Errors: 0, Skipped: 0<br>
>><br>
>> Failed tests:<br>
>> ThreadLocalLeakTest.testCheckThreadLocalLeaks:87 IllegalState Thread<br>
>> locals st...<br>
>><br>
>> CacheNotifierImplInitialTransferDistTest.testCreateAfterIterationBeganAndSegmentNotCompleteValueOwnerClustered:611->testIterationBeganAndSegmentNotComplete:510<br>
>> expected [11] but found [6]<br>
><br>
><br>
> I've seen this a couple times on my machine as well, I've created<br>
> <a href="https://issues.jboss.org/browse/ISPN-4370" target="_blank">https://issues.jboss.org/browse/ISPN-4370</a><br>
><br>
>><br>
>> Tests run: 5430, Failures: 2, Errors: 0, Skipped: 0<br>
><br>
><br>
><br>
> I'd let Will investigate ISPN-4368 and ISPN-4370 for a bit before disabling<br>
> those tests - he may be able to issue a PR for them quite quickly.<br>
><br>
> Still, just because I don't like disabling tests it doesn't mean I don't<br>
> appreciate your stability reports - keep 'em coming!<br>
><br>
><br>
> Cheers<br>
> Dan<br>
><br>
><br>
><br>
</div></div><div class=""><div class="h5">> _______________________________________________<br>
> infinispan-dev mailing list<br>
> <a href="mailto:infinispan-dev@lists.jboss.org">infinispan-dev@lists.jboss.org</a><br>
> <a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a><br>
<br>
_______________________________________________<br>
infinispan-dev mailing list<br>
<a href="mailto:infinispan-dev@lists.jboss.org">infinispan-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a></div></div></blockquote></div><br></div></div></div>