<div dir="ltr">Nice idea! I am using [1] to monitor the PRs I was involved in, which does a pretty good job, but it's annoying that it misses some updates (like the build status, most of the time).<div><br></div><div>I have one suggestion: most PRs are ready for review the moment they are issued, so I think that should be the default - no label required.</div>
<div>I would add instead a "Do not integrate yet" label :)<br><div><br></div><div><br></div><div>[1] <a href="https://prs.paas.allizom.org/infinispan/infinispan">https://prs.paas.allizom.org/infinispan/infinispan</a></div>
</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Aug 4, 2014 at 11:02 AM, Radim Vansa <span dir="ltr"><<a href="mailto:rvansa@redhat.com" target="_blank">rvansa@redhat.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Great, thanks, Sanne! I was often in-doubt what's the actual status of<br>
my PR, now I will check these :)<br>
<br>
Btw., "Ready for review" suggests that I think that it could be<br>
integrated after a proper review. There are situations (such as my [1])<br>
where I need some advice about the PR - should that be considered "Ready<br>
for review", or would be some label "Advice/Review requested" fit<br>
better? Of course, having thousand labels is not desirable, that's why I<br>
am asking how coarse grained this should be.<br>
<br>
Radim<br>
<br>
[1] <a href="https://github.com/infinispan/infinispan/pull/2585" target="_blank">https://github.com/infinispan/infinispan/pull/2585</a><br>
<div class="HOEnZb"><div class="h5"><br>
On 08/01/2014 09:50 PM, Sanne Grinovero wrote:<br>
> .. and from who.<br>
><br>
> It's sometimes unclear which PRs are there in need for review, or<br>
> which have been commented on and are waiting for fixes / polishing /<br>
> rebase / denial.<br>
><br>
> Hope these labels help:<br>
> <a href="https://github.com/infinispan/infinispan/pulls" target="_blank">https://github.com/infinispan/infinispan/pulls</a><br>
><br>
> And you can bookmark them!<br>
> <a href="https://github.com/infinispan/infinispan/pulls?q=is%3Aopen+is%3Apr+label%3A%22Ready+for+Review%22" target="_blank">https://github.com/infinispan/infinispan/pulls?q=is%3Aopen+is%3Apr+label%3A%22Ready+for+Review%22</a><br>
><br>
> Cheers,<br>
> Sanne<br>
> _______________________________________________<br>
> infinispan-dev mailing list<br>
> <a href="mailto:infinispan-dev@lists.jboss.org">infinispan-dev@lists.jboss.org</a><br>
> <a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a><br>
<br>
<br>
</div></div><span class="HOEnZb"><font color="#888888">--<br>
Radim Vansa <<a href="mailto:rvansa@redhat.com">rvansa@redhat.com</a>><br>
JBoss DataGrid QA<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
_______________________________________________<br>
infinispan-dev mailing list<br>
<a href="mailto:infinispan-dev@lists.jboss.org">infinispan-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a><br>
</div></div></blockquote></div><br></div>