<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Oct 22, 2014 at 10:43 AM, Vojtech Juranek <span dir="ltr"><<a href="mailto:vjuranek@redhat.com" target="_blank">vjuranek@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><span class="">On Tuesday 21 October 2014 12:46:42 Sanne Grinovero wrote:<br>
> I'm sceptical though on embarking into a PR process which assumes that<br>
> we're going to be able to keep the testsuite green just because we<br>
> decide so; let's first work on a green testsuite, and then proof that<br>
> we can keep it that way for a resonsable time..<br>
<br>
</span>+1, green testsuite is a mandatory condition for any other action.<br>
Let's start with smaller steps - I'd propose to make green Master JDK 7 first.<br></blockquote><div><br></div><div>+1</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<br>
Currently [1] there fails these tests:<br>
* ExampleConfigsIT.testXsiteConfig - should be fixed by PR #2973<br></blockquote><div><br></div><div>Integrated</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
* HotRodRemoteCacheIT.testPutAsync - I investigated it few days ago, it's IMHO a not a random failure but a regular bug - ISPN-4813<br></blockquote><div><br></div><div>Does anyone volunteer for ISPN-4813?</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
* HotRodRemoteCacheIT.testCustom*, testEven* - I'll volunteer on investigating this issue<br>
* StateTransferSuppressIT.testRebalanceWith* - any volunteer for investigating this one?<br></blockquote><div><br></div><div>I'll get this one, it might be related to the partition handling work. </div><div><br></div><div>There are a couple more failures in the last 5 days that we should probably look at: </div><div><a href="http://ci.infinispan.org/project.html?projectId=Infinispan&buildTypeId=bt8&page=1&tab=tests">http://ci.infinispan.org/project.html?projectId=Infinispan&buildTypeId=bt8&page=1&tab=tests</a></div><div><br></div><div> <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
Once the root causes are investigated, we can fix the issues and try to keep this build green.<br>
<span class=""><br>
> then we can talk about<br>
> building something on reliable foundations.<br>
<br>
</span>actually, if there's a failing test and it's clear which commit has caused it, we can stop merging PRs from the developer<br>
who has introduced the regression until he fix it. This should be clear message, that the first thing he should<br>
work on is to fix the test. IMHO we can start with it now and don't need green testsuite for it<br></blockquote><div><br></div><div>In theory that sounds good, but who do we stop merging for on account the current failures? :)</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<br>
[1] <a href="http://ci.infinispan.org/viewLog.html?buildId=13323&tab=buildResultsDiv&buildTypeId=bt8&logTab=" target="_blank">http://ci.infinispan.org/viewLog.html?buildId=13323&tab=buildResultsDiv&buildTypeId=bt8&logTab=</a><br>
<br>_______________________________________________<br>
infinispan-dev mailing list<br>
<a href="mailto:infinispan-dev@lists.jboss.org">infinispan-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a><br></blockquote></div><br></div></div>