<p dir="ltr">Good point. It works now (the issue is fixed) but we need to monitor both projects. I'll see how far that can be automated. Can I have ci spam you in case of failures? </p>
<br><div class="gmail_quote"><div dir="ltr">On Thu, 30 Jul 2015 15:34 Scott Marlow <<a href="mailto:smarlow@redhat.com">smarlow@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Thanks Sanne, this is a big help! IMO, we should run the Hibernate 5.0<br>
testsuite again with Infinispan 8.x/master before releasing Infinispan<br>
8.0.0.Final.<br>
<br>
Scott<br>
<br>
On 07/29/2015 07:24 PM, Sanne Grinovero wrote:<br>
> I'm fixing the ORM testsuite so that we can run it on both versions as<br>
> <a href="https://hibernate.atlassian.net/browse/HHH-10001" rel="noreferrer" target="_blank">https://hibernate.atlassian.net/browse/HHH-10001</a><br>
><br>
> Looks promising:<br>
> After working around the testsuite problem I'm down to two errors -<br>
> which seem more likely related to my changes than the Infinispan<br>
> version change - but will need some sleep before debugging those ;)<br>
><br>
> Sanne<br>
><br>
> On 29 July 2015 at 23:09, Sanne Grinovero <<a href="mailto:sanne@infinispan.org" target="_blank">sanne@infinispan.org</a>> wrote:<br>
>> On 29 July 2015 at 22:08, Sanne Grinovero <<a href="mailto:sanne@infinispan.org" target="_blank">sanne@infinispan.org</a>> wrote:<br>
>>> On 29 July 2015 at 21:58, Scott Marlow <<a href="mailto:smarlow@redhat.com" target="_blank">smarlow@redhat.com</a>> wrote:<br>
>>>> With Paul's HHH-9999 fix, we can now compile and pass the ORM tests with<br>
>>>> Infinispan 7.3.x. We can also compile Hibernate 5.0 against Infinispan<br>
>>>> 8.0.0.Beta2 but get ORM test failures <a href="http://pastebin.com/T2Yt3gdn" rel="noreferrer" target="_blank">http://pastebin.com/T2Yt3gdn</a><br>
>>><br>
>>> Let me guess.. you expect Infinispan 8 to parse configuration files<br>
>>> meant for Infinispan 7?<br>
>><br>
>> I was wrong, the problem is caused by this commit, which makes<br>
>> Infinispan now very picky on not having used AbstractInfinispanTest as<br>
>> a base class:<br>
>> <a href="https://github.com/infinispan/infinispan/commit/c9dfb" rel="noreferrer" target="_blank">https://github.com/infinispan/infinispan/commit/c9dfb</a><br>
>><br>
>> Hibernate uses the Infinispan core testing helpers, but doesn't use<br>
>> TestNG so I'm not sure what the best solution is here.<br>
>> Should we set the thread name consistently in all Hibernate tests too?<br>
>> Seems quite pointless, the tests aren't run in parallel either.<br>
>><br>
>> Could the helper be made a bit more tolerant for other use cases? Or<br>
>> maybe I should add a system property to have it change behaviour?<br>
>> I'd prefer to set the system property for Infinispan's own use, and<br>
>> default to lenient so that other people can reuse the helpers w/o<br>
>> these contraints.<br>
>><br>
>> Thanks,<br>
>> Sanne<br>
> _______________________________________________<br>
> infinispan-dev mailing list<br>
> <a href="mailto:infinispan-dev@lists.jboss.org" target="_blank">infinispan-dev@lists.jboss.org</a><br>
> <a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a><br>
><br>
_______________________________________________<br>
infinispan-dev mailing list<br>
<a href="mailto:infinispan-dev@lists.jboss.org" target="_blank">infinispan-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a><br>
</blockquote></div>