<div dir="ltr"><div>I have added a license as well as configuration snippets on use. I think its probably best for infinispan if it were transferred to the Infinispan org.</div><div><br></div><div>Looking forward to your feedback.</div><div><br></div><div>Thanks,</div><div>Simon</div><br><div class="gmail_extra"><br><div class="gmail_quote">On 27 August 2015 at 12:21, Tristan Tarrant <span dir="ltr"><<a href="mailto:ttarrant@redhat.com" target="_blank">ttarrant@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Thank you Simon, this is excellent news !<br>
<span class=""><br>
On 27/08/2015 12:49, Simon Paulger wrote:<br>
> Hi,<br>
><br>
> This is now done and is available to see here:<br>
> <a href="https://github.com/spaulg/infinispan-cachestore-redis" rel="noreferrer" target="_blank">https://github.com/spaulg/infinispan-cachestore-redis</a>. I used the remote<br>
> store within the infinispan repo as a base of reference.<br>
<br>
</span>I see there is no license associated with that repo. I think you should<br>
add one.<br>
Would like the repo to become officially owned by the Infinispan<br>
organization ?<br>
<span class=""><br>
><br>
> There are some points that my be worth further discussion. They are:<br>
> 1. the cache loader size method return type is limited to int. Redis<br>
> servers can hold much more than Integer.MAX_VALUE and the Jedis client<br>
> method for counting items on the Redis server returns longs for each<br>
> server, which in addition must be totalled up for each server if using a<br>
> Redis cluster topology. To get around this I am checking for a long over<br>
> Integer.MAX_VALUE and logging a warn, then returning Integer.MAX_VALUE.<br>
<br>
</span>This is a last-minute change we could do in Infinispan 8's<br>
AdvancedCacheLoader.<br>
<span class=""><br>
> 2. Redis handles expiration. I am using lifespan to immediately set the<br>
> expiration of the cache entry in Redis, and when that lifespan is<br>
> reached the item is immediately purged by Redis itself. This means,<br>
> there is no idle time, and there is no purge method implementation.<br>
<br>
</span>Good :)<br>
<span class=""><br>
> 3. A few unit tests around expiration had to be disabled as they require<br>
> changes to time. As expiration is handled by Redis, I would have to<br>
> change the system time to make Redis force expiration. For now, they are<br>
> just disabled.<br>
<br>
</span>Absolutely reasonable.<br>
<span class=""><br>
<br>
> I have built it against the Jedis client. I also tried 2 other clients,<br>
> lettuce and redisson, but felt that Jedis gave the best implementation<br>
> as a) it didn't try to do too much (by this I mean running background<br>
> monitoring threads that try to detect failure and perform automatic<br>
> failover of Redis slaves) and b) had all the API features I needed to<br>
> make the implementation work efficiently.<br>
><br>
> Jedis supports 3 main modes of operation. They are, single server, Redis<br>
> sentinel and Redis cluster. Redis versions that should be supported are<br>
> 2.8+ and 3.0+.<br>
><br>
> I haven't tested this beyond the unit tests distributed with Infinispan<br>
> which are starting full Redis servers in single server, sentinel and<br>
> cluster configurations to run the tests, but I am hoping to start<br>
> working on getting integration in to Wildfly 10, which I can test with a<br>
> cache container for web sessions and a simple counter web app.<br>
<br>
</span>I will take a look at the code.<br>
<br>
Thanks again for this awesome contribution.<br>
<span class="HOEnZb"><font color="#888888"><br>
Tristan<br>
</font></span><div class="HOEnZb"><div class="h5">--<br>
Tristan Tarrant<br>
Infinispan Lead<br>
JBoss, a division of Red Hat<br>
_______________________________________________<br>
infinispan-dev mailing list<br>
<a href="mailto:infinispan-dev@lists.jboss.org">infinispan-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a><br>
</div></div></blockquote></div><br></div></div>