<div dir="ltr">+1 from me.<div><br></div><div>But since we are JDK8 based, how about using Optional for "optional" parameters and "nothing" for required ones?</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Oct 30, 2015 at 10:08 AM, Tristan Tarrant <span dir="ltr"><<a href="mailto:ttarrant@redhat.com" target="_blank">ttarrant@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">During the review of [1] both Pedro and Will asked about whether a field<br>
could be null or not and I really wished I could use some kind of<br>
@NotNull annotation to clarify that. We already have findbugs included<br>
in our maven reports so what do you all think if we adopt those<br>
annotations just like we already do for the jcip ones ?<br>
<br>
Tristan<br>
<br>
<br>
[1] <a href="https://github.com/infinispan/infinispan/pull/3726" rel="noreferrer" target="_blank">https://github.com/infinispan/infinispan/pull/3726</a><br>
<span class="HOEnZb"><font color="#888888">--<br>
Tristan Tarrant<br>
Infinispan Lead<br>
JBoss, a division of Red Hat<br>
_______________________________________________<br>
infinispan-dev mailing list<br>
<a href="mailto:infinispan-dev@lists.jboss.org">infinispan-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a><br>
</font></span></blockquote></div><br></div>