<div dir="ltr">Hey Adrian!<div><br></div><div>+1. There are some more rules in our checkstyle module and I'm planning to turn them on soon (however I agree, the import one introduces probably the biggest amount of changes).</div><div><br></div><div>Checkstyle should be enabled by default [3] and it executes fine on my local machine. However if you're not building the checkstyle module with the same reactor as the rest of the project, it may happen that Maven downloads it from Nexus (this is exactly what happened in case of [4]). The situation should be fixed automatically as soon as TeamCity rebuilds and redeploys new SNAPSHOT. </div><div><br></div><div>Thanks</div><div>Sebastian</div><div><br></div><div>[3] <a href="https://github.com/infinispan/infinispan/blob/master/parent/pom.xml#L1196">https://github.com/infinispan/infinispan/blob/master/parent/pom.xml#L1196</a></div><div>[4] <a href="https://gist.github.com/slaskawi/390e87f867218a62e867dab4c1395aee#file-gistfile1-txt-L60">https://gist.github.com/slaskawi/390e87f867218a62e867dab4c1395aee#file-gistfile1-txt-L60</a></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Aug 17, 2016 at 1:01 AM, Adrian Nistor <span dir="ltr"><<a href="mailto:anistor@redhat.com" target="_blank">anistor@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000">
<div>The master branch was building fine
anyway because checkstyle does not seem to be included in default
lifecycle yet, so I'm not sure why this generates so much
commotion.<br>
But we should stop being lenient about these checkstyle violations
and fail the build from now on. ATM there are no more violations
for the currently enabled rules, so it is about time :).<br>
This approach seems to work fine for hibernate-ogm and
hibernate-search, and they have tons of style rules. We only have
three.<div><div class="h5"><br>
<br>
On 08/16/2016 11:25 PM, Sebastian Laskawiec wrote:<br>
</div></div></div><div><div class="h5">
<blockquote type="cite">
<div dir="ltr">I also integrated Adrian's PR with additional fixed
(thank you Adrian!): <a href="https://github.com/infinispan/infinispan/pull/4510" target="_blank">https://github.com/<wbr>infinispan/infinispan/pull/<wbr>4510</a>
<div><br>
</div>
<div>The master branch builds fine now.</div>
<div><br>
</div>
<div>Thanks</div>
<div>Sebastian</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Tue, Aug 16, 2016 at 10:16 PM,
Sebastian Laskawiec <span dir="ltr"><<a href="mailto:slaskawi@redhat.com" target="_blank">slaskawi@redhat.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">Hey Galder, Sanne!
<div><br>
</div>
<div>The author is no longer anonymous! It was me [1]!</div>
<div><br>
</div>
<div>Jokes aside; Galder - may I ask you to double check
your configuration? I extracted formatter archive and it
seems to be fine [2]. Perhaps you didn't enable it
(watch out, the formatter name was changed some time ago
from Horizon to Infinispan) or this is some tooling
problem (which probably should be reported to
Jetbrains). Anyway - could you please double check it?
I'll try to catch you tomorrow on IRC and talk about
it...</div>
<div><br>
</div>
<div>BTW - There are 2 different errors in your output -
the first one is the start import which should be
avoided. The second one is duplicated import (also
should be avoided). Please don't confuse those two.</div>
<div><br>
</div>
<div>@Sanne - before you trow a 'git revert' axe on me -
may I ask you to import the latest formatter and check
if the amount of imports before replacing them with star
looks correctly? It looks fine to me but I may have some
old installation, old configuration etc...</div>
<div><br>
</div>
<div>Thanks</div>
<div>Sebastian "the Troublemaker"</div>
<div><br>
</div>
<div>[1] <a href="https://www.youtube.com/watch?v=a43kowi2ncI" target="_blank">https://www.youtube.com/wa<wbr>tch?v=a43kowi2ncI</a></div>
<div>[2] unzip IntelliJ_IDEA_Code_Style<wbr>.jar and look
into attached XML. Those two properties are responsible
for star imports. </div>
<div><option name="CLASS_COUNT_TO_USE_IMPOR<wbr>T_ON_DEMAND"
value="999" /></div>
<div><option name="NAMES_COUNT_TO_USE_IMPOR<wbr>T_ON_DEMAND"
value="999" /></div>
<div><br>
</div>
</div>
<div>
<div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Tue, Aug 16, 2016 at 8:21
PM, Sanne Grinovero <span dir="ltr"><<a href="mailto:sanne@infinispan.org" target="_blank">sanne@infinispan.org</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Please
don't forget Eclipse users. It's hard enough to
contribute to<br>
Infinispan for non-IDEA users; if you enforce
specific style rules, at<br>
the very least provide compatible formatters for
the other IDEs or the<br>
barrier for contributors becomes too high.<br>
<br>
Galder: to answer your specific question I'd
personally say you should<br>
revert the offending commit. I don't know who did
it nor who merged<br>
it, but it's just not nice for others that such
things get merged<br>
carelessly. Errors can be forgiven, but should be
fixed by those who<br>
create the mess ;)<br>
<div>
<div><br>
On 16 August 2016 at 16:37, Galder Zamarreño
<<a href="mailto:galder@redhat.com" target="_blank">galder@redhat.com</a>>
wrote:<br>
> Hi all,<br>
><br>
> After integrating [1] I'm getting build
errors such as:<br>
><br>
> [INFO] --- maven-checkstyle-plugin:2.17:c<wbr>heckstyle
(checkstyle) @ infinispan-core ---<br>
> [INFO] Starting audit...<br>
> /home/g/0/infinispan/git/core/<wbr>src/main/java/org/infinispan/m<wbr>arshall/core/internal/Internal<wbr>ExternalizerTable.java:55:
error: Using the '.*' form of import should be
avoided - org.infinispan.marshall.exts.*<wbr>.<br>
> /home/g/0/infinispan/git/core/<wbr>src/main/java/org/infinispan/m<wbr>arshall/core/ExternalizerTable<wbr>.java:76:
error: Using the '.*' form of import should be
avoided - org.infinispan.marshall.exts.*<wbr>.<br>
> /home/g/0/infinispan/git/core/<wbr>src/test/java/org/infinispan/f<wbr>ilter/CompositeKeyValueFilterC<wbr>onverter.java:11:1:
error: Duplicate import to line 10 -
org.infinispan.metadata.Metada<wbr>ta.<br>
><br>
> Even after installing the latest style
for IntelliJ [2], reformatting
InternalExternalizerTable.java won't fix those
how errors.<br>
><br>
> So, what do we do? :(<br>
><br>
> Cheers,<br>
><br>
> [1] <a href="https://github.com/infinispan/infinispan/commit/313b19301055c6267c6f2ea9065a7ab1b68099fe" rel="noreferrer" target="_blank">https://github.com/infinispan/<wbr>infinispan/commit/313b19301055<wbr>c6267c6f2ea9065a7ab1b68099fe</a><br>
> [2] <a href="https://github.com/infinispan/infinispan/blob/master/ide-settings/intellij/IntelliJ_IDEA_Code_Style.jar" rel="noreferrer" target="_blank">https://github.com/infinispan/<wbr>infinispan/blob/master/ide-set<wbr>tings/intellij/IntelliJ_IDEA_C<wbr>ode_Style.jar</a><br>
> --<br>
> Galder Zamarreño<br>
> Infinispan, Red Hat<br>
><br>
><br>
> ______________________________<wbr>_________________<br>
> infinispan-dev mailing list<br>
> <a href="mailto:infinispan-dev@lists.jboss.org" target="_blank">infinispan-dev@lists.jboss.org</a><br>
> <a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailma<wbr>n/listinfo/infinispan-dev</a><br>
<br>
______________________________<wbr>_________________<br>
infinispan-dev mailing list<br>
<a href="mailto:infinispan-dev@lists.jboss.org" target="_blank">infinispan-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailma<wbr>n/listinfo/infinispan-dev</a></div>
</div>
</blockquote>
</div>
<br>
</div>
</div>
</div>
</blockquote>
</div>
<br>
</div>
<br>
<fieldset></fieldset>
<br>
<pre>______________________________<wbr>_________________
infinispan-dev mailing list
<a href="mailto:infinispan-dev@lists.jboss.org" target="_blank">infinispan-dev@lists.jboss.org</a>
<a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" target="_blank">https://lists.jboss.org/<wbr>mailman/listinfo/infinispan-<wbr>dev</a></pre>
</blockquote>
<p><br>
</p>
</div></div></div>
<br>______________________________<wbr>_________________<br>
infinispan-dev mailing list<br>
<a href="mailto:infinispan-dev@lists.jboss.org">infinispan-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/<wbr>mailman/listinfo/infinispan-<wbr>dev</a><br></blockquote></div><br></div>