<div dir="ltr">Hey David!<div><br></div><div>It's Java Util Logging (so the JDKLogger implementation).</div><div><br></div><div>Thanks</div><div>Sebastian</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Sep 30, 2016 at 1:53 PM, David M. Lloyd <span dir="ltr"><<a href="mailto:david.lloyd@redhat.com" target="_blank">david.lloyd@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On 09/30/2016 01:53 AM, Sebastian Laskawiec wrote:<br>
> Hey!<br>
><br>
> A while ago I asked Radim and Dan about these kind of constructs [1]:<br>
><br>
> private boolean trace = logger.isTraceEnabled(); //stored in a field<br>
><br>
> ... called in some method ...<br>
> if(trace)<br>
> logger.tracef(...);<br>
> ...<br>
><br>
> At first they seemed wrong to me, because if one changes logging level<br>
> (using JMX for example), the code won't notice it. I also though it's<br>
> quite ok to use tracef directly, because JIT will inline and optimize it.<br>
><br>
> Unfortunately my benchmarks [2] show that I was wrong. Logger#tracef<br>
> indeed checks if the logging level is enabled but since JBoss Logging<br>
> may use different backends, the check is not trivial and is not inlined<br>
> (at least with default settings).<br>
<br>
</span>What backend where you using with your test?<br>
<span class=""><br>
> The performance results look like this:<br>
> Benchmark Mode Cnt Score Error Units<br>
</span>> MyBenchmark.noVariable thrpt 20 *717252060.124* ± 13420522.229 ops/s<br>
> MyBenchmark.withVariable thrpt 20 *2358360244.627* ± 50214969.572 ops/s<br>
<span class="im HOEnZb">><br>
> So if you even see a construct like this: logger.debuf or logger.tracef<br>
> - make sure you check if the logging level is enabled (and the check<br>
> result is stored in a field).<br>
><br>
> That was a bit surprising and interesting lesson :D<br>
><br>
> Thanks<br>
> Sebastian<br>
><br>
> [1] <a href="https://github.com/infinispan/infinispan/pull/4538#discussion_r80666086" rel="noreferrer" target="_blank">https://github.com/infinispan/<wbr>infinispan/pull/4538#<wbr>discussion_r80666086</a><br>
> [2] <a href="https://github.com/slaskawi/jboss-logging-perf-test" rel="noreferrer" target="_blank">https://github.com/slaskawi/<wbr>jboss-logging-perf-test</a><br>
><br>
><br>
</span><span class="im HOEnZb">> ______________________________<wbr>_________________<br>
> infinispan-dev mailing list<br>
> <a href="mailto:infinispan-dev@lists.jboss.org">infinispan-dev@lists.jboss.org</a><br>
> <a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/<wbr>mailman/listinfo/infinispan-<wbr>dev</a><br>
><br>
<br>
--<br>
</span><span class="HOEnZb"><font color="#888888">- DML<br>
</font></span><div class="HOEnZb"><div class="h5">______________________________<wbr>_________________<br>
infinispan-dev mailing list<br>
<a href="mailto:infinispan-dev@lists.jboss.org">infinispan-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/<wbr>mailman/listinfo/infinispan-<wbr>dev</a></div></div></blockquote></div><br></div>