<div dir="ltr">The reason the SLF4J api was shaded was that some of our dependencies used it directly. Therefore client apps could experience ClassNotFoundExceptions.<div><br></div><div>As the time passed we migrated many of them to JBoss Logging so that the problem naturally went away and Ryan removed it completely. </div></div><br><div class="gmail_quote"><div dir="ltr">On Mon, Apr 24, 2017 at 12:57 PM Sanne Grinovero <<a href="mailto:sanne@infinispan.org">sanne@infinispan.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Just to add, I see now that JBoss Logging is included as well.<br>
<br>
<br>
On 24 April 2017 at 11:43, Sanne Grinovero <<a href="mailto:sanne@infinispan.org" target="_blank">sanne@infinispan.org</a>> wrote:<br>
> Thanks Ryan. Beyond removing the relocation, I also doubt if it should<br>
> be included at all? I'm sincerely puzzled so I think we really need to<br>
> hear from the others if this was intentional, or what the plan is.<br>
><br>
> On 24 April 2017 at 11:40, Ryan Emerson <<a href="mailto:remerson@redhat.com" target="_blank">remerson@redhat.com</a>> wrote:<br>
>> Previously slf4j was included as a dependency in infinispan-parent, so I assume this relocation was related to that. However, [1] removed slf4j from the parent so we should be to remove this relocation as well. Unless anybody else can provide more insight, I will issue a PR removing the relocation.<br>
>><br>
>> [1] <a href="https://github.com/infinispan/infinispan/pull/5058/files" rel="noreferrer" target="_blank">https://github.com/infinispan/infinispan/pull/5058/files</a><br>
>><br>
>> Cheers<br>
>> Ryan<br>
>><br>
>> ----- Original Message -----<br>
>>> When inspecting the stuff included in the "shaded" jar<br>
>>> infinispan-query-embedded, I even found a copy of SLF4J in there.<br>
>>><br>
>>> It's being relocated to the package "/infinispan/org/slf4j/"<br>
>>><br>
>>> Is that intentional? Does it even work in this way? I doubt it would<br>
>>> be able to bind to the right appenders, or be configured as intended.<br>
>>><br>
>>> Thanks,<br>
>>> Sanne<br>
>>> _______________________________________________<br>
>>> infinispan-dev mailing list<br>
>>> <a href="mailto:infinispan-dev@lists.jboss.org" target="_blank">infinispan-dev@lists.jboss.org</a><br>
>>> <a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a><br>
>>><br>
>> _______________________________________________<br>
>> infinispan-dev mailing list<br>
>> <a href="mailto:infinispan-dev@lists.jboss.org" target="_blank">infinispan-dev@lists.jboss.org</a><br>
>> <a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a><br>
<br>
_______________________________________________<br>
infinispan-dev mailing list<br>
<a href="mailto:infinispan-dev@lists.jboss.org" target="_blank">infinispan-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a><br>
</blockquote></div><div dir="ltr">-- <br></div><div data-smartmail="gmail_signature"><div dir="ltr"><p class="inbox-inbox-fullname-container" style="box-sizing:border-box;color:rgb(0,0,0);font-family:overpass,sans-serif;font-weight:bold;margin:0px;padding:0px;font-size:14px;text-transform:uppercase"><span class="inbox-inbox-firstname-container" style="box-sizing:border-box">SEBASTIAN</span><span class="inbox-inbox-Apple-converted-space"> </span><span class="inbox-inbox-lastname-container" style="box-sizing:border-box">ŁASKAWIEC</span></p><p class="inbox-inbox-position-container" style="box-sizing:border-box;color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:10px;margin:0px 0px 4px;text-transform:uppercase"><span class="inbox-inbox-position" style="box-sizing:border-box">INFINISPAN DEVELOPER</span></p><p class="inbox-inbox-legal-container" style="box-sizing:border-box;font-family:overpass,sans-serif;margin:0px;font-size:10px;color:rgb(153,153,153)"><a class="inbox-inbox-redhat-anchor" href="https://www.redhat.com/" target="_blank" style="box-sizing:border-box;color:rgb(0,136,206);margin:0px;text-decoration:none">Red Hat<span class="inbox-inbox-Apple-converted-space"> </span><span style="box-sizing:border-box">EMEA</span></a></p><table border="0" style="box-sizing:border-box;color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:medium"><tbody style="box-sizing:border-box"><tr style="box-sizing:border-box"><td width="100px" style="box-sizing:border-box"><a href="https://red.ht/sig" style="box-sizing:border-box"><img width="90" height="auto" style="box-sizing: border-box;" src="https://www.redhat.com/files/brand/email/sig-redhat.png"></a></td></tr></tbody></table></div></div>