<div dir="ltr">Thank you for your thoughts ! I do agree with you.<div><br></div><div>Dan, do you have any objection to this ?</div><div><br></div><div>Katia</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, May 5, 2017 at 6:54 PM, Wolf Fink <span dir="ltr"><<a href="mailto:wfink@redhat.com" target="_blank">wfink@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>+1 for Sanne<br></div>I would expect the same and I suppose one or more customers will raise this issue<br></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Apr 28, 2017 at 12:56 PM, Sanne Grinovero <span dir="ltr"><<a href="mailto:sanne@infinispan.org" target="_blank">sanne@infinispan.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Personally as a user I'd expect to have a CacheException raised if and<br>
only if it's not caused by my own code.<br>
<br>
Imagine my own lambda is explicitly throwing an exception of a type of<br>
my choice, it would be nice to receive that error and not a different<br>
one.<br>
<div><div class="m_2420724129146422078h5"><br>
On 28 April 2017 at 11:38, Katia Aresti <<a href="mailto:karesti@redhat.com" target="_blank">karesti@redhat.com</a>> wrote:<br>
> Hi all !<br>
><br>
> Radim pointed me to this thread discussing the exceptions launched by the<br>
> lambda executed by the user.<br>
><br>
> So, I've came accros this problem right now with the compute method.<br>
><br>
> ComputeIfAbsent is used by the QueryCache [1]<br>
><br>
> This method is now a Command, so when the wrapped lambda throws an<br>
> exception, [2], the expected exception is the one raised by the lambda. But<br>
> with my modifications, this exception is wrapped in a CacheException.<br>
><br>
> I discussed with Adrien yesterday, and IMHO and his, a CacheException is not<br>
> the same thing as the exception raised inside the lambda. Moreover, in this<br>
> particular case, I don't know if users some code could be broken if we make<br>
> the user get a CacheException that wrappes the ParseException instead of the<br>
> ParseException itself.<br>
><br>
> How can I fix the problem ?<br>
> Should we correct the tests and say that, from now on, CacheException will<br>
> be raised ?<br>
> Should we handle this CacheException in the QueryCache class when<br>
> computeIfAbsent is called ?<br>
> Should we propagate the lambda's exception as it is ?<br>
><br>
> Katia<br>
><br>
> [1]<br>
> <a href="https://github.com/infinispan/infinispan/blob/master/query/src/main/java/org/infinispan/query/dsl/embedded/impl/QueryCache.java#L79" rel="noreferrer" target="_blank">https://github.com/infinispan/<wbr>infinispan/blob/master/query/s<wbr>rc/main/java/org/infinispan/qu<wbr>ery/dsl/embedded/impl/QueryCac<wbr>he.java#L79</a><br>
> [2]<br>
> <a href="https://github.com/infinispan/infinispan/blob/master/query/src/test/java/org/infinispan/query/dsl/embedded/QueryDslConditionsTest.java#L1913" rel="noreferrer" target="_blank">https://github.com/infinispan/<wbr>infinispan/blob/master/query/s<wbr>rc/test/java/org/infinispan/qu<wbr>ery/dsl/embedded/QueryDslCondi<wbr>tionsTest.java#L1913</a><br>
><br>
><br>
</div></div>> ______________________________<wbr>_________________<br>
> infinispan-dev mailing list<br>
> <a href="mailto:infinispan-dev@lists.jboss.org" target="_blank">infinispan-dev@lists.jboss.org</a><br>
> <a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailma<wbr>n/listinfo/infinispan-dev</a><br>
______________________________<wbr>_________________<br>
infinispan-dev mailing list<br>
<a href="mailto:infinispan-dev@lists.jboss.org" target="_blank">infinispan-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailma<wbr>n/listinfo/infinispan-dev</a><br>
</blockquote></div><br></div>
</div></div><br>______________________________<wbr>_________________<br>
infinispan-dev mailing list<br>
<a href="mailto:infinispan-dev@lists.jboss.org">infinispan-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/<wbr>mailman/listinfo/infinispan-<wbr>dev</a><br></blockquote></div><br></div>