<div dir="ltr">I agree with Alan here. Maven Central is a free "download area", so I wouldn't give it up for free. BTW, what is the point of creating and not shipping them?<div><br></div><div>I would lean towards to removing them completely or limiting the number of use cases to the minimum e.g. we shouldn't support using infinispan-embedded and jcache; if jcache is essential it should be inside infinispan-embedded; the same for Spring integration modules - either we should put them in uber jars or say that you can use Spring integration with small jars.</div></div><br><div class="gmail_quote"><div dir="ltr">On Fri, Jun 9, 2017 at 5:05 AM Alan Field <<a href="mailto:afield@redhat.com">afield@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Wasn't the ability to add a single dependency to a project to start using Infinispan the whole purpose for the uber jars? I'm not trying to make an argument for keeping them, because I know they have caused many issues. I just think that if we are going to remove them from Maven, then there should be a way to achieve the same easy developer on boarding that uber jars were supposed to provide. Whether this is Maven project templates, or something else doesn't matter.<br>
<br>
Thanks,<br>
Alan<br>
<br>
----- Original Message -----<br>
> From: "Tristan Tarrant" <<a href="mailto:ttarrant@redhat.com" target="_blank">ttarrant@redhat.com</a>><br>
> To: <a href="mailto:infinispan-dev@lists.jboss.org" target="_blank">infinispan-dev@lists.jboss.org</a><br>
> Sent: Thursday, June 8, 2017 4:05:08 AM<br>
> Subject: Re: [infinispan-dev] Why JCache embedded has core as provided dependency<br>
><br>
> I think we should turn off maven deployment for uber jars.<br>
><br>
> Tristan<br>
><br>
> On 6/7/17 5:10 PM, Gustavo Fernandes wrote:<br>
> > On Wed, Jun 7, 2017 at 11:02 AM, Galder Zamarreño <<a href="mailto:galder@redhat.com" target="_blank">galder@redhat.com</a><br>
> > <mailto:<a href="mailto:galder@redhat.com" target="_blank">galder@redhat.com</a>>> wrote:<br>
> ><br>
> > As far as I see it:<br>
> ><br>
> > * infinispan-embedded should never be a dependency in a Maven project.<br>
> ><br>
> > * No uber jars should really be used as Maven dependencies because<br>
> > all the exclusion that fine grained dependencies allow you to do<br>
> > goes out of the window when all classes are inside a jar. This is<br>
> > not just theory, I've personally had such issues.<br>
> ><br>
> > * Uber jars are designed for Ant or other build tool users that<br>
> > don't have a dependency resolution engine in place.<br>
> ><br>
> > Cheers,<br>
> ><br>
> > p.s. I thought we had already discussed this before?<br>
> ><br>
> ><br>
> ><br>
> > I totally agree. In addition, uberjars should not be an osgi bundle or a<br>
> > jboss module, for similar reasons.<br>
> ><br>
> > P.S: Even Ant has a dependency mgmt available, which is Ivy.<br>
> ><br>
> > Cheers,<br>
> > Gustavo<br>
> ><br>
> > --<br>
> > Galder Zamarreño<br>
> > Infinispan, Red Hat<br>
> ><br>
> > > On 7 Jun 2017, at 11:50, Sebastian Laskawiec <<a href="mailto:slaskawi@redhat.com" target="_blank">slaskawi@redhat.com</a><br>
> > <mailto:<a href="mailto:slaskawi@redhat.com" target="_blank">slaskawi@redhat.com</a>>> wrote:<br>
> > ><br>
> > > Hey,<br>
> > ><br>
> > > The change was introduced by this commit [1] and relates to this<br>
> > JIRAs [2][3]. The root cause is in [3].<br>
> > ><br>
> > > Imagine a scenario where you add JCache module to your together<br>
> > infinispan-embedded. If your classpath was constructed in such a way<br>
> > that infinispan-embedded was before infinispan-core (classpath is<br>
> > scanned from left to right in standalone apps), we could get a<br>
> > relocated (uber jars move some classes into other packages) logger.<br>
> > That caused class mismatch errors. It is worth to mention that it<br>
> > will happen to all relocated classes, logger was just an example.<br>
> > And we need to relocate them, since a user might want to use his<br>
> > own, newer version of DMR or any other library. So there's no<br>
> > perfect solution here.<br>
> > ><br>
> > > Now a lot of time passed since then and we changed quite a few<br>
> > things. So this topic probably needs to be revisited.<br>
> > ><br>
> > > So the first question that we should ask, shall we allow putting<br>
> > jcache and infinispan-embedded together on the classpath. If the<br>
> > answer is yes, I believe it should stay as it is (since the user<br>
> > always have a choice whether he wants to use jcache with or without<br>
> > uber jar). The same question needs to be asked for Spring modules as<br>
> > well as all cache stores. The behavior needs to be consistent across<br>
> > all those modules.<br>
> > ><br>
> > > If the answer is no (which is also valid because jcache is<br>
> > already present in embedded uber jar), we should migrate all JBoss<br>
> > Logging references to Infinispan Common Logging (as Tristan did here<br>
> > [4]) and we can make infinispan-core as a compile time dependency to<br>
> > jcache. Even though migrating to Infinispan logger is not necessary,<br>
> > this way we won't break users app which used infinispan-embedded +<br>
> > jcache approach. Of course the same applies to Spring and Cache<br>
> > stores modules.<br>
> > ><br>
> > > I think the latter approach deserves some exploration. I would<br>
> > vote for moving that way.<br>
> > ><br>
> > > Thanks,<br>
> > > Sebastian<br>
> > ><br>
> > > [1]<br>
> > <a href="https://github.com/infinispan/infinispan/commit/720f158cce38d86b292e1ce77b75509342007739" rel="noreferrer" target="_blank">https://github.com/infinispan/infinispan/commit/720f158cce38d86b292e1ce77b75509342007739</a><br>
> > <<a href="https://github.com/infinispan/infinispan/commit/720f158cce38d86b292e1ce77b75509342007739" rel="noreferrer" target="_blank">https://github.com/infinispan/infinispan/commit/720f158cce38d86b292e1ce77b75509342007739</a>><br>
> > > [2] <a href="https://issues.jboss.org/browse/ISPN-6295" rel="noreferrer" target="_blank">https://issues.jboss.org/browse/ISPN-6295</a><br>
> > <<a href="https://issues.jboss.org/browse/ISPN-6295" rel="noreferrer" target="_blank">https://issues.jboss.org/browse/ISPN-6295</a>><br>
> > > [3] <a href="https://issues.jboss.org/browse/ISPN-6132" rel="noreferrer" target="_blank">https://issues.jboss.org/browse/ISPN-6132</a><br>
> > <<a href="https://issues.jboss.org/browse/ISPN-6132" rel="noreferrer" target="_blank">https://issues.jboss.org/browse/ISPN-6132</a>><br>
> > > [4] <a href="https://github.com/infinispan/infinispan/pull/4140/files" rel="noreferrer" target="_blank">https://github.com/infinispan/infinispan/pull/4140/files</a><br>
> > <<a href="https://github.com/infinispan/infinispan/pull/4140/files" rel="noreferrer" target="_blank">https://github.com/infinispan/infinispan/pull/4140/files</a>><br>
> > ><br>
> > ><br>
> > > On Wed, Jun 7, 2017 at 11:19 AM Galder Zamarreño<br>
> > <<a href="mailto:galder@redhat.com" target="_blank">galder@redhat.com</a> <mailto:<a href="mailto:galder@redhat.com" target="_blank">galder@redhat.com</a>>> wrote:<br>
> > > Hi all,<br>
> > ><br>
> > > Re:<br>
> > <a href="https://github.com/spring-projects/spring-boot/pull/9417#discussion_r120375579" rel="noreferrer" target="_blank">https://github.com/spring-projects/spring-boot/pull/9417#discussion_r120375579</a><br>
> > <<a href="https://github.com/spring-projects/spring-boot/pull/9417#discussion_r120375579" rel="noreferrer" target="_blank">https://github.com/spring-projects/spring-boot/pull/9417#discussion_r120375579</a>><br>
> > ><br>
> > > Stéphane makes a good point there, why did we make core provided<br>
> > dependency? It does feel a bit of a pain that anyone that depends on<br>
> > jcache embedded also needs to depend on core.<br>
> > ><br>
> > > Any more details behind this decision?<br>
> > ><br>
> > > Cheers,<br>
> > > --<br>
> > > Galder Zamarreño<br>
> > > Infinispan, Red Hat<br>
> > ><br>
> > > --<br>
> > > SEBASTIAN ŁASKAWIEC<br>
> > > INFINISPAN DEVELOPER<br>
> > > Red Hat EMEA<br>
> > ><br>
> ><br>
> ><br>
> > _______________________________________________<br>
> > infinispan-dev mailing list<br>
> > <a href="mailto:infinispan-dev@lists.jboss.org" target="_blank">infinispan-dev@lists.jboss.org</a> <mailto:<a href="mailto:infinispan-dev@lists.jboss.org" target="_blank">infinispan-dev@lists.jboss.org</a>><br>
> > <a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a><br>
> > <<a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a>><br>
> ><br>
> ><br>
> ><br>
> ><br>
> > _______________________________________________<br>
> > infinispan-dev mailing list<br>
> > <a href="mailto:infinispan-dev@lists.jboss.org" target="_blank">infinispan-dev@lists.jboss.org</a><br>
> > <a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a><br>
> ><br>
><br>
> --<br>
> Tristan Tarrant<br>
> Infinispan Lead<br>
> JBoss, a division of Red Hat<br>
> _______________________________________________<br>
> infinispan-dev mailing list<br>
> <a href="mailto:infinispan-dev@lists.jboss.org" target="_blank">infinispan-dev@lists.jboss.org</a><br>
> <a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a><br>
<br>
_______________________________________________<br>
infinispan-dev mailing list<br>
<a href="mailto:infinispan-dev@lists.jboss.org" target="_blank">infinispan-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a></blockquote></div><div dir="ltr">-- <br></div><div data-smartmail="gmail_signature"><div dir="ltr"><p class="inbox-inbox-fullname-container" style="box-sizing:border-box;color:rgb(0,0,0);font-family:overpass,sans-serif;font-weight:bold;margin:0px;padding:0px;font-size:14px;text-transform:uppercase"><span class="inbox-inbox-firstname-container" style="box-sizing:border-box">SEBASTIAN</span><span class="inbox-inbox-Apple-converted-space"> </span><span class="inbox-inbox-lastname-container" style="box-sizing:border-box">ŁASKAWIEC</span></p><p class="inbox-inbox-position-container" style="box-sizing:border-box;color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:10px;margin:0px 0px 4px;text-transform:uppercase"><span class="inbox-inbox-position" style="box-sizing:border-box">INFINISPAN DEVELOPER</span></p><p class="inbox-inbox-legal-container" style="box-sizing:border-box;font-family:overpass,sans-serif;margin:0px;font-size:10px;color:rgb(153,153,153)"><a class="inbox-inbox-redhat-anchor" href="https://www.redhat.com/" target="_blank" style="box-sizing:border-box;color:rgb(0,136,206);margin:0px;text-decoration:none">Red Hat<span class="inbox-inbox-Apple-converted-space"> </span><span style="box-sizing:border-box">EMEA</span></a></p><table border="0" style="box-sizing:border-box;color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:medium"><tbody style="box-sizing:border-box"><tr style="box-sizing:border-box"><td width="100px" style="box-sizing:border-box"><a href="https://red.ht/sig" style="box-sizing:border-box"><img width="90" height="auto" style="box-sizing: border-box;" src="https://www.redhat.com/files/brand/email/sig-redhat.png"></a></td></tr></tbody></table></div></div>