<br><br><div class="gmail_quote"><div dir="ltr">On Tue, Jun 13, 2017, 3:54 AM Radim Vansa <<a href="mailto:rvansa@redhat.com">rvansa@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On 06/12/2017 04:52 PM, William Burns wrote:<br>
><br>
><br>
> On Sat, Jun 10, 2017 at 12:56 AM Radim Vansa <<a href="mailto:rvansa@redhat.com" target="_blank">rvansa@redhat.com</a><br>
> <mailto:<a href="mailto:rvansa@redhat.com" target="_blank">rvansa@redhat.com</a>>> wrote:<br>
><br>
> Hi guys,<br>
><br>
> when the functional API has been outline, the interfaces were put into<br>
> infinispan-commons to make it possible to share these between remote<br>
> clients and embedded use case. However, it seems that reusing this<br>
> as-is<br>
> impossible or at least impractical as we cannot send the lambdas in a<br>
> language neutral way. In the future, we may implement a way to share<br>
> functions between client and a server but that will most likely result<br>
> in an interface accepting something else than Function<ReadWriteEntry,<br>
> R>. Also, it's rather weird to have two EntryVersion interfaces.<br>
><br>
> Therefore I suggest moving org.infinispan.commons.api.functional to<br>
> infinispan-core, package org.infinispan.api.functional<br>
><br>
> You might say that the server-side code would use the interfaces, but<br>
> once it's running on server, it should depend on core (or core-api) -<br>
> commons is what is shared with the client, and if the client will in<br>
> future register a new function on the server, the user code should<br>
> depend on core-api as well (client-hotrod itself does not have to).<br>
><br>
> If you wonder what led me to this is that I've tried to add<br>
> SerializableFunction overloads to the FunctionalMap and found out that<br>
> SerializableFunction et all are only in infinispan-core (for good).<br>
><br>
><br>
> We could move these into commons in a major version if we need to as<br>
> well. I never thought about using them in the client code as we never<br>
> planned on supporting serialized lambdas there, but if it makes other<br>
> things easier I am for it.<br>
><br>
> Also there is nothing stopping us from having these in commons right<br>
> now, there is nothing special about the interfaces, they can just be<br>
> copied over.<br>
<br>
-1 These can't be simply copied, because two modules cannot share a<br>
package name (org.infinispan.util), therefore we would have to move the<br>
SerializableFunction to org.infinispan.commons.util.function.</blockquote></div><div><br></div><div>I never said they had to be on the same package :-P</div><div><br></div><div class="gmail_quote"></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">But as you<br>
say; we can't/don't want to support lambdas in any remote client<br>
operations and therefore these would be superfluous in commons.</blockquote></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
We have to think about a pattern for the building-blocks (counters,<br>
locks, multimaps...): in embedded case we want to expose API using<br>
lambdas, in remote client this should be named filter, script or Ickle<br>
query. Obvious solution is having BaseFeature -> EmbeddedFeature,<br>
RemoteFeature that would expose the functional operations symmetrically<br>
but with different API, but it seems to me a bit inelegant.<br></blockquote></div><div><br></div><div>This is always our problem, we never have a solution and then client API falls behind.</div><div><br></div><div>Also even though we wouldn't serialize lambdas with client, doesn't mean we can't use lambdas with the client. Just means the operation would have slower performance, since it would be evaluated in the client.</div><div><br></div><div>I personally welcome the BaseFeature you mentioned because we need that asap so that we can create these API while maintaining some type of semblance between them.</div><div><br></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Note that embedded/remote building blocks will have different<br>
properties/behaviour anyway - e.g. for embedded it could be useful to<br>
execute an action once the 'owning node' crashes (e.g. release a lock)<br>
while it does not make much sense with remote client.<br>
<br>
Radim<br>
<br>
><br>
> Please let me know if you have objections/if there something I<br>
> have missed.<br>
><br>
> Radim<br>
><br>
> --<br>
> Radim Vansa <<a href="mailto:rvansa@redhat.com" target="_blank">rvansa@redhat.com</a> <mailto:<a href="mailto:rvansa@redhat.com" target="_blank">rvansa@redhat.com</a>>><br>
> JBoss Performance Team<br>
><br>
> _______________________________________________<br>
> infinispan-dev mailing list<br>
> <a href="mailto:infinispan-dev@lists.jboss.org" target="_blank">infinispan-dev@lists.jboss.org</a> <mailto:<a href="mailto:infinispan-dev@lists.jboss.org" target="_blank">infinispan-dev@lists.jboss.org</a>><br>
> <a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a><br>
><br>
><br>
><br>
> _______________________________________________<br>
> infinispan-dev mailing list<br>
> <a href="mailto:infinispan-dev@lists.jboss.org" target="_blank">infinispan-dev@lists.jboss.org</a><br>
> <a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a><br>
<br>
<br>
--<br>
Radim Vansa <<a href="mailto:rvansa@redhat.com" target="_blank">rvansa@redhat.com</a>><br>
JBoss Performance Team<br>
<br>
_______________________________________________<br>
infinispan-dev mailing list<br>
<a href="mailto:infinispan-dev@lists.jboss.org" target="_blank">infinispan-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a><br>
</blockquote></div>