<div dir="ltr">Hi everyone,<div><br></div><div>Thank you for this great work, the dependency diet and the extra port removal are both very useful. The extra port removal is key to enable Vert.x clustering in Openshift S2I environments.</div><div><br></div><div>I tried the new KUBE_PING (beta1) with vertx-infinispan and it worked fine. I have a few questions though.</div><div><br></div><div>I couldn't configure it with env variables. Before you ask, yes I noticed the name changes ;-) I only had a quick look at JGroups config code but it seems it only resolves system properties. Did it work for you because you tried with an Infinispan server?</div><div><br></div><div>Since I couldn't configure it externally I had to create a custom JGroups file. Usually, we recommend [1] Vert.x users to add the infinispan-cloud dependency and a system property:</div><div>-Dvertx.jgroups.config=default-configs/default-jgroups-kubernetes.xml<br></div><div><br></div><div>My custom JGroups file is a just a copy of default-configs/default-jgroups-kubernetes.xml in which I added the masterHost and namespace properties.</div><div><br></div><div>Is it still recommended to use the default-configs/default-jgroups-kubernetes.xml stack ? Or is any change planned after the KUBE_PING changes?</div><div>I wouldn't expect a protocol implementation change to impact a stack configuration but they say there are no stupid questions :)</div><div><br></div><div>Thank you,</div><div>Thomas</div><div><br></div><div><br></div><div>[1] <a href="http://vertx.io/docs/vertx-infinispan/java/#_configuring_for_openshift_3">http://vertx.io/docs/vertx-infinispan/java/#_configuring_for_openshift_3</a><br><div class="gmail_extra"><br><div class="gmail_quote">2017-06-15 8:21 GMT+02:00 Sebastian Laskawiec <span dir="ltr"><<a href="mailto:slaskawi@redhat.com" target="_blank">slaskawi@redhat.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Yep, no problems found!!! <div><br></div><div>I had also impression that the new implementation is "faster". Though I haven't measured it... it just my impression.<div><br></div><div>Awesome work Bela!</div></div></div><div><div class="gmail-h5"><br><div class="gmail_quote"><div dir="ltr">On Thu, Jun 15, 2017 at 7:42 AM Bela Ban <<a href="mailto:belaban@mailbox.org" target="_blank">belaban@mailbox.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Thanks, Sebastian!<br>
<br>
I assume testing on GKE and minikube/openshift was successful?<br>
<br>
<br>
On 14/06/17 13:15, Sebastian Laskawiec wrote:<br>
> Hey guys,<br>
><br>
> Just a heads up, I've just created a PR that upgrades KUBE_PING to<br>
> 1.0.0.Beta1 [1]. As you probably seen in [2], 1.0.0.Beta1 was completely<br>
> rewritten and might behave slightly differently.<br>
><br>
> Here is a summary of changes:<br>
><br>
> * The latest KUBE_PING doesn't require embedded HTTP server for<br>
> discovery. Thus it is no longer required to expose port 8888 in Pods.<br>
> * The number of dependencies has been decreased. Currently we only<br>
> require JGroups and OAuth library.<br>
> * The new KUBE_PING works only with JGroups 4. There will be no<br>
> JGroups 3 support.<br>
> * Some of the environmental variables were shortened and we removed<br>
> `OPENSHIFT` prefix. So if you use `OPENSHIFT_KUBE_PING_<wbr>NAMESPACE`,<br>
> you will need to change it to `KUBERNETES_NAMESPACE`. Please refer<br>
> to [3] for more information.<br>
><br>
> I also switched default branch in Kubernetes Ping repository to master [4].<br>
><br>
> Thanks,<br>
> Sebastian<br>
><br>
> [1] <a href="https://github.com/infinispan/infinispan/pull/5201" rel="noreferrer" target="_blank">https://github.com/infinispan/<wbr>infinispan/pull/5201</a><br>
> [2] <a href="http://belaban.blogspot.ch/2017/05/running-infinispan-cluster-with.html" rel="noreferrer" target="_blank">http://belaban.blogspot.ch/<wbr>2017/05/running-infinispan-<wbr>cluster-with.html</a><br>
> [3] <a href="https://github.com/jgroups-extras/jgroups-kubernetes/blob/master/README.adoc" rel="noreferrer" target="_blank">https://github.com/jgroups-<wbr>extras/jgroups-kubernetes/<wbr>blob/master/README.adoc</a><br>
> [4] <a href="https://github.com/jgroups-extras/jgroups-kubernetes" rel="noreferrer" target="_blank">https://github.com/jgroups-<wbr>extras/jgroups-kubernetes</a><br>
> --<br>
><br>
> SEBASTIAN ŁASKAWIEC<br>
><br>
> INFINISPAN DEVELOPER<br>
><br>
> Red Hat EMEA <<a href="https://www.redhat.com/" rel="noreferrer" target="_blank">https://www.redhat.com/</a>><br>
><br>
> <<a href="https://red.ht/sig" rel="noreferrer" target="_blank">https://red.ht/sig</a>><br>
><br>
><br>
><br>
> ______________________________<wbr>_________________<br>
> infinispan-dev mailing list<br>
> <a href="mailto:infinispan-dev@lists.jboss.org" target="_blank">infinispan-dev@lists.jboss.org</a><br>
> <a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/<wbr>mailman/listinfo/infinispan-<wbr>dev</a><br>
><br>
<br>
--<br>
Bela Ban | <a href="http://www.jgroups.org" rel="noreferrer" target="_blank">http://www.jgroups.org</a><br>
<br>
______________________________<wbr>_________________<br>
infinispan-dev mailing list<br>
<a href="mailto:infinispan-dev@lists.jboss.org" target="_blank">infinispan-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/<wbr>mailman/listinfo/infinispan-<wbr>dev</a></blockquote></div><div dir="ltr">-- <br></div></div></div><div><div dir="ltr"><div><div class="gmail-h5"><p class="gmail-m_-6521034226295539714inbox-inbox-fullname-container" style="box-sizing:border-box;color:rgb(0,0,0);font-family:overpass,sans-serif;font-weight:bold;margin:0px;padding:0px;font-size:14px;text-transform:uppercase"><span class="gmail-m_-6521034226295539714inbox-inbox-firstname-container" style="box-sizing:border-box">SEBASTIAN</span><span class="gmail-m_-6521034226295539714inbox-inbox-Apple-converted-space"> </span><span class="gmail-m_-6521034226295539714inbox-inbox-lastname-container" style="box-sizing:border-box">ŁASKAWIEC</span></p><p class="gmail-m_-6521034226295539714inbox-inbox-position-container" style="box-sizing:border-box;color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:10px;margin:0px 0px 4px;text-transform:uppercase"><span class="gmail-m_-6521034226295539714inbox-inbox-position" style="box-sizing:border-box">INFINISPAN DEVELOPER</span></p><p class="gmail-m_-6521034226295539714inbox-inbox-legal-container" style="box-sizing:border-box;font-family:overpass,sans-serif;margin:0px;font-size:10px;color:rgb(153,153,153)"><a class="gmail-m_-6521034226295539714inbox-inbox-redhat-anchor" href="https://www.redhat.com/" style="box-sizing:border-box;color:rgb(0,136,206);margin:0px;text-decoration:none" target="_blank">Red Hat<span class="gmail-m_-6521034226295539714inbox-inbox-Apple-converted-space"> </span><span style="box-sizing:border-box">EMEA</span></a></p></div></div><table border="0" style="box-sizing:border-box;color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:medium"><tbody style="box-sizing:border-box"><tr style="box-sizing:border-box"><td width="100px" style="box-sizing:border-box"><a href="https://red.ht/sig" style="box-sizing:border-box" target="_blank"><img width="90" height="auto" style="box-sizing: border-box;" src="https://www.redhat.com/files/brand/email/sig-redhat.png"></a></td></tr></tbody></table></div></div>
<br>______________________________<wbr>_________________<br>
infinispan-dev mailing list<br>
<a href="mailto:infinispan-dev@lists.jboss.org">infinispan-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/<wbr>mailman/listinfo/infinispan-<wbr>dev</a><br></blockquote></div><br></div></div></div>