<div dir="ltr">FYI: <a href="https://github.com/infinispan/infinispan/pull/5257">https://github.com/infinispan/infinispan/pull/5257</a><div><br></div><div>But we first need to fix 9.0.x branch :D</div></div><br><div class="gmail_quote"><div dir="ltr">On Mon, Jul 3, 2017 at 10:48 AM Bela Ban <<a href="mailto:belaban@mailbox.org">belaban@mailbox.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Thomas,<br>
<br>
has this issue been resolved? Env variables were introduced in 4.0.2<br>
[1], so you need at least that version of JGroups.<br>
<br>
[1] <a href="https://issues.jboss.org/browse/JGRP-2166" rel="noreferrer" target="_blank">https://issues.jboss.org/browse/JGRP-2166</a><br>
<br>
On 30/06/17 11:40, Thomas SEGISMONT wrote:<br>
> Hi everyone,<br>
><br>
> Thank you for this great work, the dependency diet and the extra port<br>
> removal are both very useful. The extra port removal is key to enable<br>
> Vert.x clustering in Openshift S2I environments.<br>
><br>
> I tried the new KUBE_PING (beta1) with vertx-infinispan and it worked<br>
> fine. I have a few questions though.<br>
><br>
> I couldn't configure it with env variables. Before you ask, yes I<br>
> noticed the name changes ;-) I only had a quick look at JGroups config<br>
> code but it seems it only resolves system properties. Did it work for<br>
> you because you tried with an Infinispan server?<br>
><br>
> Since I couldn't configure it externally I had to create a custom<br>
> JGroups file. Usually, we recommend [1] Vert.x users to add the<br>
> infinispan-cloud dependency and a system property:<br>
> -Dvertx.jgroups.config=default-configs/default-jgroups-kubernetes.xml<br>
><br>
> My custom JGroups file is a just a copy of<br>
> default-configs/default-jgroups-kubernetes.xml in which I added the<br>
> masterHost and namespace properties.<br>
><br>
> Is it still recommended to use the<br>
> default-configs/default-jgroups-kubernetes.xml stack ? Or is any change<br>
> planned after the KUBE_PING changes?<br>
> I wouldn't expect a protocol implementation change to impact a stack<br>
> configuration but they say there are no stupid questions :)<br>
><br>
> Thank you,<br>
> Thomas<br>
><br>
><br>
> [1] <a href="http://vertx.io/docs/vertx-infinispan/java/#_configuring_for_openshift_3" rel="noreferrer" target="_blank">http://vertx.io/docs/vertx-infinispan/java/#_configuring_for_openshift_3</a><br>
><br>
> 2017-06-15 8:21 GMT+02:00 Sebastian Laskawiec <<a href="mailto:slaskawi@redhat.com" target="_blank">slaskawi@redhat.com</a><br>
> <mailto:<a href="mailto:slaskawi@redhat.com" target="_blank">slaskawi@redhat.com</a>>>:<br>
><br>
> Yep, no problems found!!!<br>
><br>
> I had also impression that the new implementation is "faster".<br>
> Though I haven't measured it... it just my impression.<br>
><br>
> Awesome work Bela!<br>
><br>
> On Thu, Jun 15, 2017 at 7:42 AM Bela Ban <<a href="mailto:belaban@mailbox.org" target="_blank">belaban@mailbox.org</a><br>
> <mailto:<a href="mailto:belaban@mailbox.org" target="_blank">belaban@mailbox.org</a>>> wrote:<br>
><br>
> Thanks, Sebastian!<br>
><br>
> I assume testing on GKE and minikube/openshift was successful?<br>
><br>
><br>
> On 14/06/17 13:15, Sebastian Laskawiec wrote:<br>
> > Hey guys,<br>
> ><br>
> > Just a heads up, I've just created a PR that upgrades KUBE_PING to<br>
> > 1.0.0.Beta1 [1]. As you probably seen in [2], 1.0.0.Beta1 was<br>
> completely<br>
> > rewritten and might behave slightly differently.<br>
> ><br>
> > Here is a summary of changes:<br>
> ><br>
> > * The latest KUBE_PING doesn't require embedded HTTP server for<br>
> > discovery. Thus it is no longer required to expose port<br>
> 8888 in Pods.<br>
> > * The number of dependencies has been decreased. Currently<br>
> we only<br>
> > require JGroups and OAuth library.<br>
> > * The new KUBE_PING works only with JGroups 4. There will be no<br>
> > JGroups 3 support.<br>
> > * Some of the environmental variables were shortened and we<br>
> removed<br>
> > `OPENSHIFT` prefix. So if you use<br>
> `OPENSHIFT_KUBE_PING_NAMESPACE`,<br>
> > you will need to change it to `KUBERNETES_NAMESPACE`.<br>
> Please refer<br>
> > to [3] for more information.<br>
> ><br>
> > I also switched default branch in Kubernetes Ping repository<br>
> to master [4].<br>
> ><br>
> > Thanks,<br>
> > Sebastian<br>
> ><br>
> > [1] <a href="https://github.com/infinispan/infinispan/pull/5201" rel="noreferrer" target="_blank">https://github.com/infinispan/infinispan/pull/5201</a><br>
> <<a href="https://github.com/infinispan/infinispan/pull/5201" rel="noreferrer" target="_blank">https://github.com/infinispan/infinispan/pull/5201</a>><br>
> > [2]<br>
> <a href="http://belaban.blogspot.ch/2017/05/running-infinispan-cluster-with.html" rel="noreferrer" target="_blank">http://belaban.blogspot.ch/2017/05/running-infinispan-cluster-with.html</a><br>
> <<a href="http://belaban.blogspot.ch/2017/05/running-infinispan-cluster-with.html" rel="noreferrer" target="_blank">http://belaban.blogspot.ch/2017/05/running-infinispan-cluster-with.html</a>><br>
> > [3]<br>
> <a href="https://github.com/jgroups-extras/jgroups-kubernetes/blob/master/README.adoc" rel="noreferrer" target="_blank">https://github.com/jgroups-extras/jgroups-kubernetes/blob/master/README.adoc</a><br>
> <<a href="https://github.com/jgroups-extras/jgroups-kubernetes/blob/master/README.adoc" rel="noreferrer" target="_blank">https://github.com/jgroups-extras/jgroups-kubernetes/blob/master/README.adoc</a>><br>
> > [4] <a href="https://github.com/jgroups-extras/jgroups-kubernetes" rel="noreferrer" target="_blank">https://github.com/jgroups-extras/jgroups-kubernetes</a><br>
> <<a href="https://github.com/jgroups-extras/jgroups-kubernetes" rel="noreferrer" target="_blank">https://github.com/jgroups-extras/jgroups-kubernetes</a>><br>
> > --<br>
> ><br>
> > SEBASTIAN ŁASKAWIEC<br>
> ><br>
> > INFINISPAN DEVELOPER<br>
> ><br>
> > Red Hat EMEA <<a href="https://www.redhat.com/" rel="noreferrer" target="_blank">https://www.redhat.com/</a>><br>
> ><br>
> > <<a href="https://red.ht/sig" rel="noreferrer" target="_blank">https://red.ht/sig</a>><br>
> ><br>
> ><br>
> ><br>
> > _______________________________________________<br>
> > infinispan-dev mailing list<br>
> > <a href="mailto:infinispan-dev@lists.jboss.org" target="_blank">infinispan-dev@lists.jboss.org</a><br>
> <mailto:<a href="mailto:infinispan-dev@lists.jboss.org" target="_blank">infinispan-dev@lists.jboss.org</a>><br>
> > <a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a><br>
> <<a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a>><br>
> ><br>
><br>
> --<br>
> Bela Ban | <a href="http://www.jgroups.org" rel="noreferrer" target="_blank">http://www.jgroups.org</a><br>
><br>
> _______________________________________________<br>
> infinispan-dev mailing list<br>
> <a href="mailto:infinispan-dev@lists.jboss.org" target="_blank">infinispan-dev@lists.jboss.org</a><br>
> <mailto:<a href="mailto:infinispan-dev@lists.jboss.org" target="_blank">infinispan-dev@lists.jboss.org</a>><br>
> <a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a><br>
> <<a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a>><br>
><br>
> --<br>
><br>
> SEBASTIAN ŁASKAWIEC<br>
><br>
> INFINISPAN DEVELOPER<br>
><br>
> Red Hat EMEA <<a href="https://www.redhat.com/" rel="noreferrer" target="_blank">https://www.redhat.com/</a>><br>
><br>
> <<a href="https://red.ht/sig" rel="noreferrer" target="_blank">https://red.ht/sig</a>><br>
><br>
><br>
> _______________________________________________<br>
> infinispan-dev mailing list<br>
> <a href="mailto:infinispan-dev@lists.jboss.org" target="_blank">infinispan-dev@lists.jboss.org</a> <mailto:<a href="mailto:infinispan-dev@lists.jboss.org" target="_blank">infinispan-dev@lists.jboss.org</a>><br>
> <a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a><br>
> <<a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a>><br>
><br>
><br>
><br>
><br>
> _______________________________________________<br>
> infinispan-dev mailing list<br>
> <a href="mailto:infinispan-dev@lists.jboss.org" target="_blank">infinispan-dev@lists.jboss.org</a><br>
> <a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a><br>
><br>
<br>
--<br>
Bela Ban | <a href="http://www.jgroups.org" rel="noreferrer" target="_blank">http://www.jgroups.org</a><br>
<br>
_______________________________________________<br>
infinispan-dev mailing list<br>
<a href="mailto:infinispan-dev@lists.jboss.org" target="_blank">infinispan-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a></blockquote></div><div dir="ltr">-- <br></div><div data-smartmail="gmail_signature"><div dir="ltr"><p class="inbox-inbox-inbox-fullname-container" style="box-sizing:border-box;color:rgb(0,0,0);font-family:overpass,sans-serif;font-weight:bold;margin:0px;padding:0px;font-size:14px;text-transform:uppercase"><span class="inbox-inbox-inbox-firstname-container" style="box-sizing:border-box">SEBASTIAN</span><span class="inbox-inbox-inbox-Apple-converted-space"> </span><span class="inbox-inbox-inbox-lastname-container" style="box-sizing:border-box">ŁASKAWIEC</span></p><p class="inbox-inbox-inbox-position-container" style="box-sizing:border-box;color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:10px;margin:0px 0px 4px;text-transform:uppercase"><span class="inbox-inbox-inbox-position" style="box-sizing:border-box">INFINISPAN DEVELOPER</span></p><p class="inbox-inbox-inbox-legal-container" style="box-sizing:border-box;font-family:overpass,sans-serif;margin:0px;font-size:10px;color:rgb(153,153,153)"><a class="inbox-inbox-inbox-redhat-anchor" href="https://www.redhat.com/" target="_blank" style="box-sizing:border-box;color:rgb(0,136,206);margin:0px;text-decoration:none">Red Hat<span class="inbox-inbox-inbox-Apple-converted-space"> </span><span style="box-sizing:border-box">EMEA</span></a></p><table border="0" style="box-sizing:border-box;color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:medium"><tbody style="box-sizing:border-box"><tr style="box-sizing:border-box"><td width="100px" style="box-sizing:border-box"><a href="https://red.ht/sig" style="box-sizing:border-box"><img width="90" height="auto" style="box-sizing: border-box;" src="https://www.redhat.com/files/brand/email/sig-redhat.png"></a></td></tr></tbody></table></div></div>