<div dir="ltr">Hi Bela,<div><br></div><div>Yes, upgrading to 4.0.3.Final solved the issue.</div><div><br></div><div>Thank you!</div></div><div class="gmail_extra"><br><div class="gmail_quote">2017-07-03 10:45 GMT+02:00 Bela Ban <span dir="ltr">&lt;<a href="mailto:belaban@mailbox.org" target="_blank">belaban@mailbox.org</a>&gt;</span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Thomas,<br>
<br>
has this issue been resolved? Env variables were introduced in 4.0.2<br>
[1], so you need at least that version of JGroups.<br>
<br>
[1] <a href="https://issues.jboss.org/browse/JGRP-2166" rel="noreferrer" target="_blank">https://issues.jboss.org/<wbr>browse/JGRP-2166</a><br>
<div><div class="h5"><br>
On 30/06/17 11:40, Thomas SEGISMONT wrote:<br>
&gt; Hi everyone,<br>
&gt;<br>
&gt; Thank you for this great work, the dependency diet and the extra port<br>
&gt; removal are both very useful. The extra port removal is key to enable<br>
&gt; Vert.x clustering in Openshift S2I environments.<br>
&gt;<br>
&gt; I tried the new KUBE_PING (beta1) with vertx-infinispan and it worked<br>
&gt; fine. I have a few questions though.<br>
&gt;<br>
&gt; I couldn&#39;t configure it with env variables. Before you ask, yes I<br>
&gt; noticed the name changes ;-) I only had a quick look at JGroups config<br>
&gt; code but it seems it only resolves system properties. Did it work for<br>
&gt; you because you tried with an Infinispan server?<br>
&gt;<br>
&gt; Since I couldn&#39;t configure it externally I had to create a custom<br>
&gt; JGroups file. Usually, we recommend [1] Vert.x users to add the<br>
&gt; infinispan-cloud dependency and a system property:<br>
&gt; -Dvertx.jgroups.config=<wbr>default-configs/default-<wbr>jgroups-kubernetes.xml<br>
&gt;<br>
&gt; My custom JGroups file is a just a copy of<br>
&gt; default-configs/default-<wbr>jgroups-kubernetes.xml in which I added the<br>
&gt; masterHost and namespace properties.<br>
&gt;<br>
&gt; Is it still recommended to use the<br>
&gt; default-configs/default-<wbr>jgroups-kubernetes.xml stack ? Or is any change<br>
&gt; planned after the KUBE_PING changes?<br>
&gt; I wouldn&#39;t expect a protocol implementation change to impact a stack<br>
&gt; configuration but they say there are no stupid questions :)<br>
&gt;<br>
&gt; Thank you,<br>
&gt; Thomas<br>
&gt;<br>
&gt;<br>
&gt; [1] <a href="http://vertx.io/docs/vertx-infinispan/java/#_configuring_for_openshift_3" rel="noreferrer" target="_blank">http://vertx.io/docs/vertx-<wbr>infinispan/java/#_configuring_<wbr>for_openshift_3</a><br>
&gt;<br>
&gt; 2017-06-15 8:21 GMT+02:00 Sebastian Laskawiec &lt;<a href="mailto:slaskawi@redhat.com">slaskawi@redhat.com</a><br>
</div></div>&gt; &lt;mailto:<a href="mailto:slaskawi@redhat.com">slaskawi@redhat.com</a>&gt;&gt;:<br>
<span class="">&gt;<br>
&gt;     Yep, no problems found!!!<br>
&gt;<br>
&gt;     I had also impression that the new implementation is &quot;faster&quot;.<br>
&gt;     Though I haven&#39;t measured it... it just my impression.<br>
&gt;<br>
&gt;     Awesome work Bela!<br>
&gt;<br>
&gt;     On Thu, Jun 15, 2017 at 7:42 AM Bela Ban &lt;<a href="mailto:belaban@mailbox.org">belaban@mailbox.org</a><br>
</span><div><div class="h5">&gt;     &lt;mailto:<a href="mailto:belaban@mailbox.org">belaban@mailbox.org</a>&gt;&gt; wrote:<br>
&gt;<br>
&gt;         Thanks, Sebastian!<br>
&gt;<br>
&gt;         I assume testing on GKE and minikube/openshift was successful?<br>
&gt;<br>
&gt;<br>
&gt;         On 14/06/17 13:15, Sebastian Laskawiec wrote:<br>
&gt;         &gt; Hey guys,<br>
&gt;         &gt;<br>
&gt;         &gt; Just a heads up, I&#39;ve just created a PR that upgrades KUBE_PING to<br>
&gt;         &gt; 1.0.0.Beta1 [1]. As you probably seen in [2], 1.0.0.Beta1 was<br>
&gt;         completely<br>
&gt;         &gt; rewritten and might behave slightly differently.<br>
&gt;         &gt;<br>
&gt;         &gt; Here is a summary of changes:<br>
&gt;         &gt;<br>
&gt;         &gt;   * The latest KUBE_PING doesn&#39;t require embedded HTTP server for<br>
&gt;         &gt;     discovery. Thus it is no longer required to expose port<br>
&gt;         8888 in Pods.<br>
&gt;         &gt;   * The number of dependencies has been decreased. Currently<br>
&gt;         we only<br>
&gt;         &gt;     require JGroups and OAuth library.<br>
&gt;         &gt;   * The new KUBE_PING works only with JGroups 4. There will be no<br>
&gt;         &gt;     JGroups 3 support.<br>
&gt;         &gt;   * Some of the environmental variables were shortened and we<br>
&gt;         removed<br>
&gt;         &gt;     `OPENSHIFT` prefix. So if you use<br>
&gt;         `OPENSHIFT_KUBE_PING_<wbr>NAMESPACE`,<br>
&gt;         &gt;     you will need to change it to `KUBERNETES_NAMESPACE`.<br>
&gt;         Please refer<br>
&gt;         &gt;     to [3] for more information.<br>
&gt;         &gt;<br>
&gt;         &gt; I also switched default branch in Kubernetes Ping repository<br>
&gt;         to master [4].<br>
&gt;         &gt;<br>
&gt;         &gt; Thanks,<br>
&gt;         &gt; Sebastian<br>
&gt;         &gt;<br>
&gt;         &gt; [1] <a href="https://github.com/infinispan/infinispan/pull/5201" rel="noreferrer" target="_blank">https://github.com/infinispan/<wbr>infinispan/pull/5201</a><br>
&gt;         &lt;<a href="https://github.com/infinispan/infinispan/pull/5201" rel="noreferrer" target="_blank">https://github.com/<wbr>infinispan/infinispan/pull/<wbr>5201</a>&gt;<br>
&gt;         &gt; [2]<br>
&gt;         <a href="http://belaban.blogspot.ch/2017/05/running-infinispan-cluster-with.html" rel="noreferrer" target="_blank">http://belaban.blogspot.ch/<wbr>2017/05/running-infinispan-<wbr>cluster-with.html</a><br>
&gt;         &lt;<a href="http://belaban.blogspot.ch/2017/05/running-infinispan-cluster-with.html" rel="noreferrer" target="_blank">http://belaban.blogspot.ch/<wbr>2017/05/running-infinispan-<wbr>cluster-with.html</a>&gt;<br>
&gt;         &gt; [3]<br>
&gt;         <a href="https://github.com/jgroups-extras/jgroups-kubernetes/blob/master/README.adoc" rel="noreferrer" target="_blank">https://github.com/jgroups-<wbr>extras/jgroups-kubernetes/<wbr>blob/master/README.adoc</a><br>
&gt;         &lt;<a href="https://github.com/jgroups-extras/jgroups-kubernetes/blob/master/README.adoc" rel="noreferrer" target="_blank">https://github.com/jgroups-<wbr>extras/jgroups-kubernetes/<wbr>blob/master/README.adoc</a>&gt;<br>
&gt;         &gt; [4] <a href="https://github.com/jgroups-extras/jgroups-kubernetes" rel="noreferrer" target="_blank">https://github.com/jgroups-<wbr>extras/jgroups-kubernetes</a><br>
&gt;         &lt;<a href="https://github.com/jgroups-extras/jgroups-kubernetes" rel="noreferrer" target="_blank">https://github.com/jgroups-<wbr>extras/jgroups-kubernetes</a>&gt;<br>
&gt;         &gt; --<br>
&gt;         &gt;<br>
&gt;         &gt; SEBASTIAN ŁASKAWIEC<br>
&gt;         &gt;<br>
&gt;         &gt; INFINISPAN DEVELOPER<br>
&gt;         &gt;<br>
&gt;         &gt; Red Hat EMEA &lt;<a href="https://www.redhat.com/" rel="noreferrer" target="_blank">https://www.redhat.com/</a>&gt;<br>
&gt;         &gt;<br>
&gt;         &gt; &lt;<a href="https://red.ht/sig" rel="noreferrer" target="_blank">https://red.ht/sig</a>&gt;<br>
&gt;         &gt;<br>
&gt;         &gt;<br>
&gt;         &gt;<br>
&gt;         &gt; ______________________________<wbr>_________________<br>
&gt;         &gt; infinispan-dev mailing list<br>
&gt;         &gt; <a href="mailto:infinispan-dev@lists.jboss.org">infinispan-dev@lists.jboss.org</a><br>
</div></div>&gt;         &lt;mailto:<a href="mailto:infinispan-dev@lists.jboss.org">infinispan-dev@lists.<wbr>jboss.org</a>&gt;<br>
&gt;         &gt; <a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/<wbr>mailman/listinfo/infinispan-<wbr>dev</a><br>
<span class="">&gt;         &lt;<a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/<wbr>mailman/listinfo/infinispan-<wbr>dev</a>&gt;<br>
&gt;         &gt;<br>
&gt;<br>
&gt;         --<br>
&gt;         Bela Ban | <a href="http://www.jgroups.org" rel="noreferrer" target="_blank">http://www.jgroups.org</a><br>
&gt;<br>
&gt;         ______________________________<wbr>_________________<br>
&gt;         infinispan-dev mailing list<br>
&gt;         <a href="mailto:infinispan-dev@lists.jboss.org">infinispan-dev@lists.jboss.org</a><br>
</span>&gt;         &lt;mailto:<a href="mailto:infinispan-dev@lists.jboss.org">infinispan-dev@lists.<wbr>jboss.org</a>&gt;<br>
&gt;         <a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/<wbr>mailman/listinfo/infinispan-<wbr>dev</a><br>
<span class="">&gt;         &lt;<a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/<wbr>mailman/listinfo/infinispan-<wbr>dev</a>&gt;<br>
&gt;<br>
&gt;     --<br>
&gt;<br>
&gt;     SEBASTIAN ŁASKAWIEC<br>
&gt;<br>
&gt;     INFINISPAN DEVELOPER<br>
&gt;<br>
</span><span class="">&gt;     Red Hat EMEA &lt;<a href="https://www.redhat.com/" rel="noreferrer" target="_blank">https://www.redhat.com/</a>&gt;<br>
&gt;<br>
&gt;     &lt;<a href="https://red.ht/sig" rel="noreferrer" target="_blank">https://red.ht/sig</a>&gt;<br>
&gt;<br>
&gt;<br>
&gt;     ______________________________<wbr>_________________<br>
&gt;     infinispan-dev mailing list<br>
</span>&gt;     <a href="mailto:infinispan-dev@lists.jboss.org">infinispan-dev@lists.jboss.org</a> &lt;mailto:<a href="mailto:infinispan-dev@lists.jboss.org">infinispan-dev@lists.<wbr>jboss.org</a>&gt;<br>
&gt;     <a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/<wbr>mailman/listinfo/infinispan-<wbr>dev</a><br>
&gt;     &lt;<a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/<wbr>mailman/listinfo/infinispan-<wbr>dev</a>&gt;<br>
<div class="HOEnZb"><div class="h5">&gt;<br>
&gt;<br>
&gt;<br>
&gt;<br>
&gt; ______________________________<wbr>_________________<br>
&gt; infinispan-dev mailing list<br>
&gt; <a href="mailto:infinispan-dev@lists.jboss.org">infinispan-dev@lists.jboss.org</a><br>
&gt; <a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/<wbr>mailman/listinfo/infinispan-<wbr>dev</a><br>
&gt;<br>
<br>
--<br>
Bela Ban | <a href="http://www.jgroups.org" rel="noreferrer" target="_blank">http://www.jgroups.org</a><br>
<br>
______________________________<wbr>_________________<br>
infinispan-dev mailing list<br>
<a href="mailto:infinispan-dev@lists.jboss.org">infinispan-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/<wbr>mailman/listinfo/infinispan-<wbr>dev</a></div></div></blockquote></div><br></div>