<div dir="ltr">Hi everyone,<div><br></div><div>Here is most of the implementation with example use outlined in <a href="https://github.com/infinispan/infinispan/pull/5570">https://github.com/infinispan/infinispan/pull/5570</a></div><div><br></div><div>Would you please review it as I am not an expert in DMR and I need one now :-)</div><div><br></div><div>Regards,</div><div>Vladimir</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Nov 3, 2017 at 8:58 AM, Vladimir Blagojevic <span dir="ltr"><<a href="mailto:vblagoje@redhat.com" target="_blank">vblagoje@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF">
<div class="m_1024833283421768596moz-cite-prefix">Thanks Galder and Pedro. I'll implement
them as you suggested!<br>
Cheers<br>
On 2017-11-03 6:02 AM, Galder Zamarreño wrote:<br>
</div>
<blockquote type="cite">
<div class="m_1024833283421768596ApplePlainTextBody">At first glance, I'd agree with
Pedro.<br>
<br>
<blockquote type="cite"><div><div class="h5">On 2 Nov 2017, at 16:07, Pedro Ruivo
<a class="m_1024833283421768596moz-txt-link-rfc2396E" href="mailto:pedro@infinispan.org" target="_blank"><pedro@infinispan.org></a> wrote:<br>
<br>
Hi,<br>
<br>
IMO, I would separate the concept of counter and
configuration.<br>
<br>
Even if an user doesn't create many counters, I think most of
them will <br>
share the same configuration. As a bad example, if you want to
counter <br>
oranges and apples, you're going to use the same
configuration... <br>
probably :)<br>
<br>
In addition, it is symmetric to the cache DMR tree. This would
reduce <br>
the learning curve if the user is already used to cli (i.e
create caches).<br>
<br>
Cheers,<br>
Pedro<br>
<br>
<br>
<br>
On 02-11-2017 12:33, Vladimir Blagojevic wrote:<br>
</div></div><blockquote type="cite"><div><div class="h5">Hey guys,<br>
<br>
How do you anticipate users are going to deal with counters?
Are they<br>
going to be creating a lot of them in their applications,
say dozens,<br>
hundreds, thousands?<br>
<br>
I am asking because I have a dilemma about their
representation in DMR<br>
and therefore in the admin console and potentially wider.
The dilemma is<br>
related to splitting the concepts and the mapping between
counter<br>
configuration and counter instances. On one end of the
possible spectrum<br>
use, if users are going to have many counters that have the
same<br>
configuration then it makes sense to delineate the DMR
concept of the<br>
counter configuration and its counter instance just like we
do for<br>
caches and cache configuration templates. We deal with cache<br>
configurations as templates; one could create hundreds of
caches from<br>
the same template. Similarly, we can do with counters. On
the other end<br>
if users are going to create very few counters then it
likely does not<br>
make much sense to separate counter configurations from its
instance,<br>
they would have one to one mapping. For each new counter,
users would<br>
just enter counter configuration and launch an instance of a<br>
corresponding counter.<br>
<br>
The first approach saves resources and makes large counter<br>
instantiations easier while the second approach is easier to
understand<br>
conceptually but is inefficient if we are going to have many
counter<br>
instance.<br>
<br>
Thoughts?<br>
<br>
Vladimir<br>
<br></div></div><div><div class="h5">
______________________________<wbr>_________________<br>
infinispan-dev mailing list<br>
<a class="m_1024833283421768596moz-txt-link-abbreviated" href="mailto:infinispan-dev@lists.jboss.org" target="_blank">infinispan-dev@lists.jboss.org</a><br>
<a class="m_1024833283421768596moz-txt-link-freetext" href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" target="_blank">https://lists.jboss.org/<wbr>mailman/listinfo/infinispan-<wbr>dev</a><br>
<br>
</div></div></blockquote><div><div class="h5">
______________________________<wbr>_________________<br>
infinispan-dev mailing list<br>
<a class="m_1024833283421768596moz-txt-link-abbreviated" href="mailto:infinispan-dev@lists.jboss.org" target="_blank">infinispan-dev@lists.jboss.org</a><br>
<a class="m_1024833283421768596moz-txt-link-freetext" href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" target="_blank">https://lists.jboss.org/<wbr>mailman/listinfo/infinispan-<wbr>dev</a><br>
</div></div></blockquote>
<br><span class="HOEnZb"><font color="#888888">
--<br>
Galder Zamarreño<br>
Infinispan, Red Hat<br>
<br>
</font></span></div><div><div class="h5">
<br>
<fieldset class="m_1024833283421768596mimeAttachmentHeader"></fieldset>
<br>
<pre>______________________________<wbr>_________________
infinispan-dev mailing list
<a class="m_1024833283421768596moz-txt-link-abbreviated" href="mailto:infinispan-dev@lists.jboss.org" target="_blank">infinispan-dev@lists.jboss.org</a>
<a class="m_1024833283421768596moz-txt-link-freetext" href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" target="_blank">https://lists.jboss.org/<wbr>mailman/listinfo/infinispan-<wbr>dev</a></pre>
</div></div></blockquote>
<p><br>
</p>
</div>
<br>______________________________<wbr>_________________<br>
infinispan-dev mailing list<br>
<a href="mailto:infinispan-dev@lists.jboss.org">infinispan-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/<wbr>mailman/listinfo/infinispan-<wbr>dev</a><br></blockquote></div><br></div>