<div dir="ltr">Hey Tristan,<div><br></div><div>Comments inlined.</div><div><br></div><div>Thanks,</div><div>Sebastian<br><br><div class="gmail_quote"><div dir="ltr">On Fri, Dec 1, 2017 at 9:28 AM Tristan Tarrant <<a href="mailto:ttarrant@redhat.com">ttarrant@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hello people,<br>
<br>
I'd like to rationalize the PR labels because I believe some of them are<br>
useless:<br>
<br>
[Ready for review] - Any PR without the [Preview] label must fall under<br>
this category<br></blockquote><div><br></div><div>If a PR doesn't fall into Preview category, it must be Ready for Review. In my opinion "Ready for Review" is redundant.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
[Backport] - The burden should be on the PR owner to create relevant<br>
backport PRs, not on the reviewer<br></blockquote><div><br></div><div>+1<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
[Wait CI Results] - PRs should only be integrated after a successful CI<br>
run (or when failures can be proven to be pre-existing)<br></blockquote><div><br></div><div>All PRs should be evaluated by Jenkins. The CI check has 3 icons on Github Pull Request page - green tick, red cross and yellow dot. Yellow dot means that the PR is being built right now (or waiting in the queue). I believe "Wait CI Results" and that yellow dot are identical and "Wait CI Result" is redundant.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
[Check CI Failures!] - The CI runs already add failure/success to the PR<br>
status. Checking CI failures should apply to ALL PRs.<br>
[On Ice] PR should be closed and reopened when relevant again.<br></blockquote><div><br></div><div>Let just close such PRs! Redundant...</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Comments/suggestions ?<br>
<br>
Tristan<br>
--<br>
Tristan Tarrant<br>
Infinispan Lead<br>
JBoss, a division of Red Hat<br>
_______________________________________________<br>
infinispan-dev mailing list<br>
<a href="mailto:infinispan-dev@lists.jboss.org" target="_blank">infinispan-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a><br>
</blockquote></div></div></div>